From: Marc Zyngier <maz@kernel.org>
To: Andrew Scull <ascull@google.com>
Cc: kvm@vger.kernel.org, kernel-team@android.com,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure
Date: Mon, 08 Jun 2020 16:42:42 +0100 [thread overview]
Message-ID: <1a00887a4af019fa83380b68afd43a29@kernel.org> (raw)
In-Reply-To: <20200608145145.GA96714@google.com>
Hi Andrew,
On 2020-06-08 15:51, Andrew Scull wrote:
> On Mon, Jun 08, 2020 at 09:56:57AM +0100, Marc Zyngier wrote:
>> For very long, we have kept this pointer back to the per-cpu
>> host state, despite having working per-cpu accessors at EL2
>> for some time now.
>>
>> Recent investigations have shown that this pointer is easy
>> to abuse in preemptible context, which is a sure sign that
>> it would better be gone. Not to mention that a per-cpu
>> pointer is faster to access at all times.
>
> Helps to make the references to `kvm_host_data` clearer with there now
> being just one way to get to it and shows that it is scoped to the
> current CPU. A good change IMO!
Thanks! Can I take this as a Reviewed-by or Acked-by tag? Just let me
know.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Andrew Scull <ascull@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
kvm@vger.kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure
Date: Mon, 08 Jun 2020 16:42:42 +0100 [thread overview]
Message-ID: <1a00887a4af019fa83380b68afd43a29@kernel.org> (raw)
In-Reply-To: <20200608145145.GA96714@google.com>
Hi Andrew,
On 2020-06-08 15:51, Andrew Scull wrote:
> On Mon, Jun 08, 2020 at 09:56:57AM +0100, Marc Zyngier wrote:
>> For very long, we have kept this pointer back to the per-cpu
>> host state, despite having working per-cpu accessors at EL2
>> for some time now.
>>
>> Recent investigations have shown that this pointer is easy
>> to abuse in preemptible context, which is a sure sign that
>> it would better be gone. Not to mention that a per-cpu
>> pointer is faster to access at all times.
>
> Helps to make the references to `kvm_host_data` clearer with there now
> being just one way to get to it and shows that it is scoped to the
> current CPU. A good change IMO!
Thanks! Can I take this as a Reviewed-by or Acked-by tag? Just let me
know.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Andrew Scull <ascull@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
kernel-team@android.com
Subject: Re: [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure
Date: Mon, 08 Jun 2020 16:42:42 +0100 [thread overview]
Message-ID: <1a00887a4af019fa83380b68afd43a29@kernel.org> (raw)
In-Reply-To: <20200608145145.GA96714@google.com>
Hi Andrew,
On 2020-06-08 15:51, Andrew Scull wrote:
> On Mon, Jun 08, 2020 at 09:56:57AM +0100, Marc Zyngier wrote:
>> For very long, we have kept this pointer back to the per-cpu
>> host state, despite having working per-cpu accessors at EL2
>> for some time now.
>>
>> Recent investigations have shown that this pointer is easy
>> to abuse in preemptible context, which is a sure sign that
>> it would better be gone. Not to mention that a per-cpu
>> pointer is faster to access at all times.
>
> Helps to make the references to `kvm_host_data` clearer with there now
> being just one way to get to it and shows that it is scoped to the
> current CPU. A good change IMO!
Thanks! Can I take this as a Reviewed-by or Acked-by tag? Just let me
know.
Cheers,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-06-08 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 8:56 [PATCH v2] KVM: arm64: Remove host_cpu_context member from vcpu structure Marc Zyngier
2020-06-08 8:56 ` Marc Zyngier
2020-06-08 8:56 ` Marc Zyngier
2020-06-08 14:51 ` Andrew Scull
2020-06-08 14:51 ` Andrew Scull
2020-06-08 14:51 ` Andrew Scull
2020-06-08 15:42 ` Marc Zyngier [this message]
2020-06-08 15:42 ` Marc Zyngier
2020-06-08 15:42 ` Marc Zyngier
2020-06-08 17:09 ` Andrew Scull
2020-06-08 17:09 ` Andrew Scull
2020-06-08 17:09 ` Andrew Scull
2020-06-08 16:29 ` Mark Rutland
2020-06-08 16:29 ` Mark Rutland
2020-06-08 16:29 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a00887a4af019fa83380b68afd43a29@kernel.org \
--to=maz@kernel.org \
--cc=ascull@google.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.