All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] migration-guide: 5.1: Remove duplicated typo
@ 2026-06-24  8:19 Jaekyu Lee
  2026-06-24  9:38 ` [docs] " Quentin Schulz
  0 siblings, 1 reply; 3+ messages in thread
From: Jaekyu Lee @ 2026-06-24  8:19 UTC (permalink / raw)
  To: docs, jaekyu.lee

From: "jaekyu.lee" <jaekyu.lee@lge.com>

- Remove duplicated typo, do_compile
---
 documentation/migration-guides/migration-5.1.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/documentation/migration-guides/migration-5.1.rst b/documentation/migration-guides/migration-5.1.rst
index 94b527bdc..f1c953c7e 100644
--- a/documentation/migration-guides/migration-5.1.rst
+++ b/documentation/migration-guides/migration-5.1.rst
@@ -23,8 +23,8 @@ supported, and an error will be issued. The recipe should be changed to::
     S = "${UNPACKDIR}"
 
 Any :term:`WORKDIR` references where files from :term:`SRC_URI` are referenced
-should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`,
-:ref:`ref-tasks-compile`, :ref:`ref-tasks-install` and :term:`LIC_FILES_CHKSUM`.
+should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`, 
+:ref:`ref-tasks-install` and :term:`LIC_FILES_CHKSUM`.
 
 :term:`WORKDIR` references in recipes
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [docs] [PATCH] migration-guide: 5.1: Remove duplicated typo
  2026-06-24  8:19 [PATCH] migration-guide: 5.1: Remove duplicated typo Jaekyu Lee
@ 2026-06-24  9:38 ` Quentin Schulz
  0 siblings, 0 replies; 3+ messages in thread
From: Quentin Schulz @ 2026-06-24  9:38 UTC (permalink / raw)
  To: jaekyu.lee, docs

Hi Jaekyu Lee,

On 6/24/26 10:19 AM, Jaekyu Lee via lists.yoctoproject.org wrote:
> [You don't often get email from jaekyu.lee=lge.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: "jaekyu.lee" <jaekyu.lee@lge.com>
> 
> - Remove duplicated typo, do_compile

Thanks for the patch!

We need a proper Signed-off-by here. C.f. 
https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes

> ---
>   documentation/migration-guides/migration-5.1.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/documentation/migration-guides/migration-5.1.rst b/documentation/migration-guides/migration-5.1.rst
> index 94b527bdc..f1c953c7e 100644
> --- a/documentation/migration-guides/migration-5.1.rst
> +++ b/documentation/migration-guides/migration-5.1.rst
> @@ -23,8 +23,8 @@ supported, and an error will be issued. The recipe should be changed to::
>       S = "${UNPACKDIR}"
> 
>   Any :term:`WORKDIR` references where files from :term:`SRC_URI` are referenced
> -should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`,
> -:ref:`ref-tasks-compile`, :ref:`ref-tasks-install` and :term:`LIC_FILES_CHKSUM`.
> +should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`,
> +:ref:`ref-tasks-install` and :term:`LIC_FILES_CHKSUM`.
> 

Did we mean ref-tasks-configure maybe? Seems like commit 1f18b9a51280 
("recipes: Start WORKDIR -> UNPACKDIR transition") in OE-Core modifies a 
few do_configure tasks.

Cheers,
Quentin


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [docs] [PATCH] migration-guide: 5.1: Remove duplicated typo
  2026-06-24  9:47 Jaekyu Lee
@ 2026-06-24  9:50 ` Quentin Schulz
  0 siblings, 0 replies; 3+ messages in thread
From: Quentin Schulz @ 2026-06-24  9:50 UTC (permalink / raw)
  To: jaekyu.lee, docs

Hi jaekyu.lee, Antonin,

On 6/24/26 11:47 AM, Jaekyu Lee via lists.yoctoproject.org wrote:
> [You don't often get email from jaekyu.lee=lge.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: "jaekyu.lee" <jaekyu.lee@lge.com>
> 
> - Remove duplicated typo, do_compile
> 
> Signed-off-by: jaekyu.lee <jaekyu.lee@lge.com>
> ---
>   documentation/migration-guides/migration-5.1.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/documentation/migration-guides/migration-5.1.rst b/documentation/migration-guides/migration-5.1.rst
> index 94b527bdc..f1c953c7e 100644
> --- a/documentation/migration-guides/migration-5.1.rst
> +++ b/documentation/migration-guides/migration-5.1.rst
> @@ -23,8 +23,8 @@ supported, and an error will be issued. The recipe should be changed to::
>       S = "${UNPACKDIR}"
> 
>   Any :term:`WORKDIR` references where files from :term:`SRC_URI` are referenced
> -should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`,
> -:ref:`ref-tasks-compile`, :ref:`ref-tasks-install` and :term:`LIC_FILES_CHKSUM`.
> +should be changed to :term:`S`. These are commonly in :ref:`ref-tasks-compile`,
> +:ref:`ref-tasks-install` and :term:`LIC_FILES_CHKSUM`.
> 

Asking the same question since it was ignored on v1 such that Antonin is 
aware of it. I am wondering whether we didn't rather mean configure, 
compile and install tasks instead of the compile task being duplicated.

Cheers,
Quentin


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-24  9:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-24  8:19 [PATCH] migration-guide: 5.1: Remove duplicated typo Jaekyu Lee
2026-06-24  9:38 ` [docs] " Quentin Schulz
  -- strict thread matches above, loose matches on Subject: below --
2026-06-24  9:47 Jaekyu Lee
2026-06-24  9:50 ` [docs] " Quentin Schulz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.