From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Simone Ballarin <simone.ballarin@bugseng.com>
Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com,
"Gianluca Luparini" <gianluca.luparini@bugseng.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jan Beulich" <jbeulich@suse.com>
Subject: Re: [XEN PATCH v4 2/4] xen/vpci: address violations of MISRA C:2012 Rule 7.2
Date: Thu, 24 Aug 2023 12:40:28 +0200 [thread overview]
Message-ID: <1b4e6569c0c8d17c73341e43ed46c232@bugseng.com> (raw)
In-Reply-To: <2cb770d946c4bf858a41271fd7b9985f789ca149.1690368810.git.simone.ballarin@bugseng.com>
On 26/07/2023 13:03, Simone Ballarin wrote:
> From: Gianluca Luparini <gianluca.luparini@bugseng.com>
>
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> "A 'u' or 'U' suffix shall be applied to all integer constants
> that are represented in an unsigned type".
>
> Add the 'U' suffix to integers literals with unsigned type and also to
> other
> literals used in the same contexts or near violations, when their
> positive
> nature is immediately clear. The latter changes are done for the sake
> of
> uniformity.
>
> Signed-off-by: Gianluca Luparini <gianluca.luparini@bugseng.com>
> Signed-off-by: Simone Ballarin <simone.ballarin@bugseng.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changes in v4:
> - change commit headline
>
> Changes in v3:
> - change 'Signed-off-by' ordering
> - add 'uint32_t' casts in 'msi.c' and 'msix.c'
>
> Changes in v2:
> - minor change to commit title
> - change commit message
> ---
> xen/drivers/vpci/msi.c | 2 +-
> xen/drivers/vpci/msix.c | 2 +-
> xen/drivers/vpci/vpci.c | 6 +++---
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
Like other patches in this series, this one could also benefit from an
ack from
VPCI maintainers to get committed, as it does apply cleanly on staging.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
next prev parent reply other threads:[~2023-08-24 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:03 [XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 7.2 Simone Ballarin
2023-07-26 11:03 ` [XEN PATCH v4 1/4] x86/vmx: " Simone Ballarin
2023-08-24 10:28 ` Nicola Vetrini
2023-08-24 22:04 ` Stefano Stabellini
2023-08-28 10:11 ` Simone Ballarin
2023-07-26 11:03 ` [XEN PATCH v4 2/4] xen/vpci: " Simone Ballarin
2023-08-24 10:40 ` Nicola Vetrini [this message]
2023-08-24 22:05 ` Need Ack, " Stefano Stabellini
2023-08-24 12:20 ` Roger Pau Monné
2023-08-24 22:05 ` Stefano Stabellini
2023-07-26 11:03 ` [XEN PATCH v4 3/4] x86/viridian: " Simone Ballarin
2023-08-24 10:34 ` Nicola Vetrini
2023-08-24 22:03 ` Need Ack, " Stefano Stabellini
2023-07-26 11:03 ` [XEN PATCH v4 4/4] xen/x86: " Simone Ballarin
2023-07-27 12:15 ` Jan Beulich
2023-07-26 12:02 ` [XEN PATCH 0/4] xen: " Jan Beulich
2023-07-26 12:33 ` Simone Ballarin
2023-08-09 8:58 ` Simone Ballarin
2023-08-09 9:15 ` Jan Beulich
2023-08-10 7:27 ` Simone Ballarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4e6569c0c8d17c73341e43ed46c232@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=consulting@bugseng.com \
--cc=gianluca.luparini@bugseng.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=simone.ballarin@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.