Re: [XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 7.2

[Simone Ballarin <simone.ballarin@bugseng.com>]

On 09/08/2023 11:15, Jan Beulich wrote:
> On 09.08.2023 10:58, Simone Ballarin wrote:
>> Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin <
>> simone.ballarin@bugseng.com> ha scritto:
>> 
>>> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose 
>>> headline
>>> states:
>>> "A 'u' or 'U' suffix shall be applied to all integer constants that 
>>> are
>>> represented in an unsigned type".
>>> 
>>> These violations are caused by the missing "u" or "U" suffix in 
>>> unsigned
>>> integer constants, such as:
>>> 
>>> xen/arch/x86/hvm/hypercall.c:132.17-132.26
>>> if ( (eax & 0x80000000) && is_viridian_domain(currd) )
>>> 
>>> If a rule is not met, changes are needed in order to achieve 
>>> compliance.
>>> The patches in this series achieve compliance for MISRA C:2012 Rule 
>>> 7.2 by
>>> adding the 'U' suffix to integers literals with unsigned type and 
>>> also to
>>> other
>>> literals used in the same contexts or near violations, when their 
>>> positive
>>> nature is immediately clear. The latter changes are done for the sake 
>>> of
>>> uniformity.
>>> 
>>> Gianluca Luparini (4):
>>>   x86/vmx: address violations of MISRA C:2012 Rule 7.2
>>>   xen/vpci: address violations of MISRA C:2012 Rule 7.2
>>>   x86/viridian: address violations of MISRA C:2012 Rule 7.2
>>>   xen/x86: address violations of MISRA C:2012 Rule 7.2
>>> 
>>>  xen/arch/x86/apic.c                          |   2 +-
>>>  xen/arch/x86/cpu-policy.c                    |  18 +-
>>>  xen/arch/x86/cpu/mcheck/mce-apei.c           |   4 +-
>>>  xen/arch/x86/cpu/vpmu_intel.c                |   2 +-
>>>  xen/arch/x86/cpuid.c                         |   8 +-
>>>  xen/arch/x86/efi/efi-boot.h                  |   6 +-
>>>  xen/arch/x86/extable.c                       |   2 +-
>>>  xen/arch/x86/hvm/hypercall.c                 |   2 +-
>>>  xen/arch/x86/hvm/pmtimer.c                   |   4 +-
>>>  xen/arch/x86/hvm/stdvga.c                    |  50 +++---
>>>  xen/arch/x86/hvm/viridian/viridian.c         |   2 +-
>>>  xen/arch/x86/hvm/vlapic.c                    |   6 +-
>>>  xen/arch/x86/hvm/vmx/vmcs.c                  |   6 +-
>>>  xen/arch/x86/hvm/vmx/vvmx.c                  |   8 +-
>>>  xen/arch/x86/include/asm/apicdef.h           |   2 +-
>>>  xen/arch/x86/include/asm/config.h            |   2 +-
>>>  xen/arch/x86/include/asm/guest/hyperv-tlfs.h |  28 +--
>>>  xen/arch/x86/include/asm/hpet.h              |   2 +-
>>>  xen/arch/x86/include/asm/hvm/trace.h         |   4 +-
>>>  xen/arch/x86/include/asm/hvm/vioapic.h       |   2 +-
>>>  xen/arch/x86/include/asm/hvm/vmx/vmcs.h      |  84 ++++-----
>>>  xen/arch/x86/include/asm/hvm/vmx/vmx.h       |  16 +-
>>>  xen/arch/x86/include/asm/msi.h               |   2 +-
>>>  xen/arch/x86/include/asm/msr-index.h         | 180 
>>> +++++++++----------
>>>  xen/arch/x86/include/asm/pci.h               |   8 +-
>>>  xen/arch/x86/include/asm/x86-defns.h         |  24 +--
>>>  xen/arch/x86/percpu.c                        |   2 +-
>>>  xen/arch/x86/psr.c                           |   2 +-
>>>  xen/arch/x86/spec_ctrl.c                     |   8 +-
>>>  xen/arch/x86/x86_64/pci.c                    |   2 +-
>>>  xen/arch/x86/x86_emulate/x86_emulate.h       |   2 +-
>>>  xen/drivers/vpci/msi.c                       |   2 +-
>>>  xen/drivers/vpci/msix.c                      |   2 +-
>>>  xen/drivers/vpci/vpci.c                      |   6 +-
>>>  xen/lib/x86/cpuid.c                          |   8 +-
>>>  xen/lib/x86/policy.c                         |   2 +-
>>>  36 files changed, 255 insertions(+), 255 deletions(-)
>>> 
>>> --
>>> 2.34.1
>>> 
>>> 
>> Hi all,
>> the entire series has not received yet any feedback or Acked-by.
>> I would kindly ask if it is possible to have at least some feedback
> 
> I did reply to patch 4 on July 27th. For patch 2, Roger is on PTO for
> another week and a half.
> 
> Jan
Thanks for the information.
-- 
Simone Ballarin, M.Sc.

Field Application Engineer, BUGSENG (https://bugseng.com)