From: Laurence Oberman <loberman@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stuart hayes <stuart.w.hayes@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Martin Belanger <Martin.Belanger@dell.com>,
Oliver O'Halloran <oohall@gmail.com>,
Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
David Jeffery <djeffery@redhat.com>,
Jeremy Allison <jallison@ciq.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Nathan Chancellor <nathan@kernel.org>,
Jan Kiszka <jan.kiszka@seimens.com>
Subject: Re: [PATCH] driver core: fix async device shutdown hang
Date: Wed, 18 Sep 2024 17:07:57 -0400 [thread overview]
Message-ID: <1b5cc9421cfd8dced181335b426646aef2f7309a.camel@redhat.com> (raw)
In-Reply-To: <2024091838-keenly-scrabble-8cce@gregkh>
On Wed, 2024-09-18 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 17, 2024 at 07:20:41PM -0500, stuart hayes wrote:
> >
> >
> > On 9/17/2024 3:42 PM, Greg Kroah-Hartman wrote:
> > > On Tue, Sep 17, 2024 at 03:15:17PM -0500, Stuart Hayes wrote:
> > > > Modify device_shutdown() so that supplier devices do not wait
> > > > for
> > > > consumer devices to be shut down first when the devlink is sync
> > > > state
> > > > only, since the consumer is not dependent on the supplier in
> > > > this case.
> > > >
> > > > Without this change, a circular dependency could hang the
> > > > system.
> > > >
> > > > Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
> > >
> > > What commit id does this fix? Should it go to stable?
> > >
> > > And what driver is causing this problem, is this a regression or
> > > for
> > > something new that just got added to the tree?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > This fixes commit 8064952c65045f05ee2671fe437770e50c151776, in
> > driver-core-next & linux-next... it's problem with code that was
> > just
> > added to the tree (in drivers/base/core.c). It is not in stable.
>
> Ah, that wasn't obvious, sorry.
>
> > Apologies, I should have mentioned that from the start.
>
> Can you resend this with a "Fixes:" tag in it so I can just take it
> that
> way and not have to edit it by hand?
>
> thanks,
>
> greg k-h
>
FYI
This patch plus the rest of the original Bundle has been tested
at Red Hat on a system with 24 nvme devices.
Improvement was almost 8 times faster to shutdown.
Tested-by: Laurence Oberman <loberman@redhat.com>
next prev parent reply other threads:[~2024-09-18 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 20:15 [PATCH] driver core: fix async device shutdown hang Stuart Hayes
2024-09-17 20:42 ` Greg Kroah-Hartman
2024-09-18 0:20 ` stuart hayes
2024-09-18 6:12 ` Greg Kroah-Hartman
2024-09-18 21:07 ` Laurence Oberman [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-19 4:31 Stuart Hayes
2024-09-19 5:17 ` Greg Kroah-Hartman
2024-09-19 14:16 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5cc9421cfd8dced181335b426646aef2f7309a.camel@redhat.com \
--to=loberman@redhat.com \
--cc=Martin.Belanger@dell.com \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jallison@ciq.com \
--cc=jan.kiszka@seimens.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=nathan@kernel.org \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.