From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Martin Belanger <Martin.Belanger@dell.com>,
Oliver O'Halloran <oohall@gmail.com>,
Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
David Jeffery <djeffery@redhat.com>,
Jeremy Allison <jallison@ciq.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Nathan Chancellor <nathan@kernel.org>,
Jan Kiszka <jan.kiszka@seimens.com>
Subject: Re: [PATCH] driver core: fix async device shutdown hang
Date: Thu, 19 Sep 2024 07:17:26 +0200 [thread overview]
Message-ID: <2024091938-pamphlet-chapped-56ed@gregkh> (raw)
In-Reply-To: <20240919043143.1194950-1-stuart.w.hayes@gmail.com>
On Wed, Sep 18, 2024 at 11:31:43PM -0500, Stuart Hayes wrote:
> Modify device_shutdown() so that supplier devices do not wait for
> consumer devices to be shut down first when the devlink is sync state
> only, since the consumer is not dependent on the supplier in this case.
>
> Without this change, a circular dependency could hang the system.
>
> Fixes: 8064952c6504 ("driver core: shut down devices asynchronously")
>
> Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Nit, no blank line between Fixes: and signed-off-by is needed.
> ---
> The patch this fixes is in driver-core-next and linux-next.
>
> Please let me know if this needs to be a V2 or if it needs anything
> else... it is the identical patch I sent in yesterday, except I added
> a "Fixes:" tag and the comments. Thank you for the help!
In theory, yes, this is a v2 as something did change, but I can take
this as-is for now, thanks.
greg k-h
next prev parent reply other threads:[~2024-09-19 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 4:31 [PATCH] driver core: fix async device shutdown hang Stuart Hayes
2024-09-19 5:17 ` Greg Kroah-Hartman [this message]
2024-09-19 14:16 ` Nathan Chancellor
-- strict thread matches above, loose matches on Subject: below --
2024-09-17 20:15 Stuart Hayes
2024-09-17 20:42 ` Greg Kroah-Hartman
2024-09-18 0:20 ` stuart hayes
2024-09-18 6:12 ` Greg Kroah-Hartman
2024-09-18 21:07 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091938-pamphlet-chapped-56ed@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Martin.Belanger@dell.com \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=jallison@ciq.com \
--cc=jan.kiszka@seimens.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=nathan@kernel.org \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.