From: Sinan Kaya <okaya@kernel.org>
To: "Kuppuswamy,
Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, ashok.raj@intel.com,
Jay Vosburgh <jay.vosburgh@canonical.com>
Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call
Date: Fri, 25 Sep 2020 19:50:55 -0400 [thread overview]
Message-ID: <1bbbdfde-2493-7ff5-fd13-b6340b1228e7@kernel.org> (raw)
In-Reply-To: <8beca800-ffb5-c535-6d43-7e750cbf06d0@linux.intel.com>
On 9/25/2020 2:16 PM, Kuppuswamy, Sathyanarayanan wrote:
>> One approach is to share the restore code between hotplug driver and
>> DPC driver.
>>
>> If this is a too involved change, DPC driver should restore state
>> when hotplug is not supported.
> Yes. we can add a condition for hotplug capability check.
Now that I think about this more...
This won't work. Link is brought down automatically by the DPC hardware.
Therefore, all software state is lost. Restore won't help here.
The only solution I can see is to force driver disconnect and rescan.
next prev parent reply other threads:[~2020-09-25 23:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3cad1a07-509b-ef51-f635-71def2ff8293@linux.intel.com>
2020-09-22 23:33 ` [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call Bjorn Helgaas
2020-09-22 23:44 ` Kuppuswamy, Sathyanarayanan
2020-09-24 1:15 ` Sinan Kaya
2020-09-24 2:04 ` Kuppuswamy, Sathyanarayanan
2020-09-24 2:16 ` Sinan Kaya
2020-09-24 2:51 ` Kuppuswamy, Sathyanarayanan
2020-09-24 3:13 ` Sinan Kaya
2020-09-24 4:06 ` Kuppuswamy, Sathyanarayanan
2020-09-24 20:52 ` Sinan Kaya
2020-09-25 5:11 ` Kuppuswamy, Sathyanarayanan
2020-09-25 16:55 ` Sinan Kaya
2020-09-25 17:11 ` Kuppuswamy, Sathyanarayanan
2020-09-25 17:47 ` Sinan Kaya
2020-09-25 18:16 ` Kuppuswamy, Sathyanarayanan
2020-09-25 18:30 ` Sinan Kaya
2020-09-28 2:43 ` Kuppuswamy, Sathyanarayanan
2020-09-28 8:41 ` Ethan Zhao
2020-09-28 11:17 ` Sinan Kaya
2020-09-28 12:16 ` Sinan Kaya
2020-09-28 17:15 ` Kuppuswamy, Sathyanarayanan
2020-09-28 18:02 ` Sinan Kaya
2020-09-28 18:25 ` Sinan Kaya
2020-09-28 18:32 ` Kuppuswamy, Sathyanarayanan
2020-10-12 5:13 ` Kuppuswamy, Sathyanarayanan
2020-10-12 14:51 ` Sinan Kaya
2020-09-28 12:11 ` Sinan Kaya
2020-09-25 23:50 ` Sinan Kaya [this message]
2020-07-24 19:07 sathyanarayanan.kuppuswamy
2020-09-01 5:41 ` Kuppuswamy, Sathyanarayanan
2020-09-22 18:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bbbdfde-2493-7ff5-fd13-b6340b1228e7@kernel.org \
--to=okaya@kernel.org \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jay.vosburgh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.