Re: [PATCH v2 6/8] drm/amdgpu: Unmap entire device address space on device remove.

["Christian König" <christian.koenig@amd.com>]

Am 23.06.20 um 12:22 schrieb Daniel Vetter:
> On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote:
>> On Mon, Jun 22, 2020 at 3:38 PM Christian König
>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>> Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
>>>> Use the new TTM interface to invalidate all exsisting BO CPU mappings
>>>> form all user proccesses.
>>>>
>>>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>>
>>> I think those two patches could already land in amd-staging-drm-next
>>> since they are a good idea independent of how else we fix the other issues.
>> Please make sure they land in drm-misc as well.
> Not sure that's much use, since without any of the fault side changes you
> just blow up on the first refault. Seems somewhat silly to charge ahead on
> this with the other bits still very much under discussion.

Well what I wanted to say is that we don't need to send out those simple 
patches once more.

> Plus I suggested a possible bikeshed here :-)

No bikeshed, but indeed a rather good idea to not make this a TTM function.

Christian.

> -Daniel
>
>> Alex
>>
>>>> ---
>>>>    drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>>> index 43592dc..6932d75 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>>> @@ -1135,6 +1135,7 @@ amdgpu_pci_remove(struct pci_dev *pdev)
>>>>        struct drm_device *dev = pci_get_drvdata(pdev);
>>>>
>>>>        drm_dev_unplug(dev);
>>>> +     ttm_bo_unmap_virtual_address_space(&adev->mman.bdev);
>>>>        amdgpu_driver_unload_kms(dev);
>>>>
>>>>        pci_disable_device(pdev);

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx