From: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] memory: tegra: fix fdc test bug
Date: Fri, 07 Apr 2017 22:54:19 +0100 [thread overview]
Message-ID: <1bfab352ccd1581882d6e82b6eb72cb4@codethink.com> (raw)
In-Reply-To: <20170407174301.GA4386-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
On 2017-04-07 18:43, Thierry Reding wrote:
> On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote:
>> The fdc variable is a bool, taking the address of this will generally
>> produce true, thus skewing any users of the
>> tegra_mc_set_latency_allowance
>> code.
>>
>> Note, this does not seem to be producing a compiler warning. This was
>> only
>> spotted as it meant a caller was seeing 3 times higher than expected
>> register results.
>>
>> Signed-off-by: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
>> ---
>> drivers/memory/tegra/mc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What tree is this based on? I don't see this code anywhere in mainline.
Apologies, turns out this a vendor added function.
--
Ben
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@lists.codethink.co.uk, swarren@wwwdotorg.org,
gnurou@gmail.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] memory: tegra: fix fdc test bug
Date: Fri, 07 Apr 2017 22:54:19 +0100 [thread overview]
Message-ID: <1bfab352ccd1581882d6e82b6eb72cb4@codethink.com> (raw)
In-Reply-To: <20170407174301.GA4386@ulmo.ba.sec>
On 2017-04-07 18:43, Thierry Reding wrote:
> On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote:
>> The fdc variable is a bool, taking the address of this will generally
>> produce true, thus skewing any users of the
>> tegra_mc_set_latency_allowance
>> code.
>>
>> Note, this does not seem to be producing a compiler warning. This was
>> only
>> spotted as it meant a caller was seeing 3 times higher than expected
>> register results.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/memory/tegra/mc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What tree is this based on? I don't see this code anywhere in mainline.
Apologies, turns out this a vendor added function.
--
Ben
next prev parent reply other threads:[~2017-04-07 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 17:28 [PATCH 1/1] memory: tegra: fix fdc test bug Ben Dooks
2017-04-07 17:28 ` Ben Dooks
[not found] ` <20170407172820.21292-1-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2017-04-07 17:43 ` Thierry Reding
2017-04-07 17:43 ` Thierry Reding
[not found] ` <20170407174301.GA4386-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2017-04-07 21:54 ` Ben Dooks [this message]
2017-04-07 21:54 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bfab352ccd1581882d6e82b6eb72cb4@codethink.com \
--to=ben.dooks-4ydnlxn2s6swdatgbsphta@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.