From: Markus Elfring <Markus.Elfring@web.de>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Chen Tao <chentao107@huawei.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Drew Davenport <ddavenport@chromium.org>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Rob Clark <robdclark@gmail.com>, Sam Ravnborg <sam@ravnborg.org>,
Sean Paul <sean@poorly.run>, zhengbin <zhengbin13@huawei.com>
Subject: Re: [PATCH] drm/msm/dpu: fix wrong return value in dpu_encoder_init()
Date: Thu, 2 Jul 2020 16:04:07 +0200 [thread overview]
Message-ID: <1c338c4c-c185-0b37-eabb-1072a6502ec0@web.de> (raw)
> A positive value ENOMEM is returned here. I thinr this is a typo error.
> It is necessary to return a negative error value.
I imagine that a small adjustment could be nice for this change description.
How do you think about to follow progress for the integration of
a previous patch like “[RESEND] drm/msm/dpu: fix error return code in dpu_encoder_init”?
https://lore.kernel.org/dri-devel/20200618062803.152097-1-chentao107@huawei.com/
https://lore.kernel.org/patchwork/patch/1257957/
https://lkml.org/lkml/2020/6/18/46
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Sean Paul <sean@poorly.run>,
linux-kernel@vger.kernel.org, zhengbin <zhengbin13@huawei.com>,
Chen Tao <chentao107@huawei.com>,
Kalyan Thota <kalyan_t@codeaurora.org>,
Drew Davenport <ddavenport@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm/msm/dpu: fix wrong return value in dpu_encoder_init()
Date: Thu, 2 Jul 2020 16:04:07 +0200 [thread overview]
Message-ID: <1c338c4c-c185-0b37-eabb-1072a6502ec0@web.de> (raw)
> A positive value ENOMEM is returned here. I thinr this is a typo error.
> It is necessary to return a negative error value.
I imagine that a small adjustment could be nice for this change description.
How do you think about to follow progress for the integration of
a previous patch like “[RESEND] drm/msm/dpu: fix error return code in dpu_encoder_init”?
https://lore.kernel.org/dri-devel/20200618062803.152097-1-chentao107@huawei.com/
https://lore.kernel.org/patchwork/patch/1257957/
https://lkml.org/lkml/2020/6/18/46
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-07-02 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:04 Markus Elfring [this message]
2020-07-02 14:04 ` [PATCH] drm/msm/dpu: fix wrong return value in dpu_encoder_init() Markus Elfring
2020-07-03 4:19 ` Tianjia Zhang
2020-07-03 4:19 ` Tianjia Zhang
-- strict thread matches above, loose matches on Subject: below --
2020-07-02 14:04 Markus Elfring
2020-07-02 14:04 ` Markus Elfring
2020-07-01 4:11 Tianjia Zhang
2020-07-01 4:11 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c338c4c-c185-0b37-eabb-1072a6502ec0@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=chentao107@huawei.com \
--cc=daniel@ffwll.ch \
--cc=ddavenport@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.