* [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed
@ 2025-06-10 11:40 Alexander Stein
2025-06-10 15:32 ` Sean Anderson
2025-06-11 21:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2025-06-10 11:40 UTC (permalink / raw)
To: Madalin Bucur, Sean Anderson, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Russell King
Cc: Alexander Stein, netdev, linux-kernel
'managed' is a non-boolean property specified in ethernet-controller.yaml.
Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is
used on non-boolean properties") this raises a warning. Use the
replacement of_property_present() instead.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 3925441143fac..0291093f2e4e4 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -1225,7 +1225,7 @@ int memac_initialization(struct mac_device *mac_dev,
* be careful and not enable this if we are using MII or RGMII, since
* those configurations modes don't use in-band autonegotiation.
*/
- if (!of_property_read_bool(mac_node, "managed") &&
+ if (!of_property_present(mac_node, "managed") &&
mac_dev->phy_if != PHY_INTERFACE_MODE_MII &&
!phy_interface_mode_is_rgmii(mac_dev->phy_if))
mac_dev->phylink_config.default_an_inband = true;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed
2025-06-10 11:40 [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed Alexander Stein
@ 2025-06-10 15:32 ` Sean Anderson
2025-06-11 21:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Sean Anderson @ 2025-06-10 15:32 UTC (permalink / raw)
To: Alexander Stein, Madalin Bucur, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Russell King
Cc: netdev, linux-kernel
On 6/10/25 07:40, Alexander Stein wrote:
> 'managed' is a non-boolean property specified in ethernet-controller.yaml.
> Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is
> used on non-boolean properties") this raises a warning. Use the
> replacement of_property_present() instead.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
> index 3925441143fac..0291093f2e4e4 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -1225,7 +1225,7 @@ int memac_initialization(struct mac_device *mac_dev,
> * be careful and not enable this if we are using MII or RGMII, since
> * those configurations modes don't use in-band autonegotiation.
> */
> - if (!of_property_read_bool(mac_node, "managed") &&
> + if (!of_property_present(mac_node, "managed") &&
> mac_dev->phy_if != PHY_INTERFACE_MODE_MII &&
> !phy_interface_mode_is_rgmii(mac_dev->phy_if))
> mac_dev->phylink_config.default_an_inband = true;
Reviewed-by: Sean Anderson <sean.anderson@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed
2025-06-10 11:40 [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed Alexander Stein
2025-06-10 15:32 ` Sean Anderson
@ 2025-06-11 21:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-06-11 21:40 UTC (permalink / raw)
To: Alexander Stein
Cc: madalin.bucur, sean.anderson, andrew+netdev, davem, edumazet,
kuba, pabeni, linux, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 10 Jun 2025 13:40:56 +0200 you wrote:
> 'managed' is a non-boolean property specified in ethernet-controller.yaml.
> Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is
> used on non-boolean properties") this raises a warning. Use the
> replacement of_property_present() instead.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> [...]
Here is the summary with links:
- [1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed
https://git.kernel.org/netdev/net-next/c/7781c4f70305
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-11 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-10 11:40 [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on non-boolean property managed Alexander Stein
2025-06-10 15:32 ` Sean Anderson
2025-06-11 21:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.