All of lore.kernel.org
 help / color / mirror / Atom feed
From: cang@codeaurora.org
To: Avri Altman <Avri.Altman@wdc.com>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
	rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
	kernel-team@android.com, saravanak@google.com,
	salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
	Pedro Sousa <pedrom.sousa@synopsys.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Bean Huo <beanhuo@micron.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/5] scsi: ufs: Add new bit field PA_INIT to UECDL register
Date: Wed, 13 Nov 2019 08:41:23 +0800	[thread overview]
Message-ID: <1ca07e76a0b6c95a116c44c4115508d4@codeaurora.org> (raw)
In-Reply-To: <MN2PR04MB69910D7CB55980F2C498A468FC770@MN2PR04MB6991.namprd04.prod.outlook.com>

On 2019-11-12 15:53, Avri Altman wrote:
>> 
>> Add new bit field (bit-15) PA_INIT to UECDL register, this will 
>> correctly handle
>> any PA_INIT error.
>> 
>> Signed-off-by: Can Guo <cang@codeaurora.org>
> Acked-by Avri Altman <avri.altman@wdc.com>
> 
> This is a HCI3.0 change, so maybe make note of that?
> But UIC_DATA_LINK_LAYER_ERROR_CODE_MASK isn't being used anywhere,
> better just remove it, don't you think?
> Instead, while at it, fix ufshcd_update_uic_error to check
> UIC_DATA_LINK_LAYER_ERROR when checking for data link layer errors?

Hi Avri,

I will squash this change to my patch, it is used there.
[PATCH v3 5/7] scsi: ufs: Fix irq return code
url - https://lore.kernel.org/patchwork/patch/1148656/

Thanks,
Can Guo.

  reply	other threads:[~2019-11-13  0:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08  8:15 [PATCH v1 0/5] UFS driver general fixes bundle 5 Can Guo
2019-11-08  8:15 ` [PATCH v1 1/5] scsi: ufs: Recheck bkops level if bkops is disabled Can Guo
2019-11-12  7:10   ` Avri Altman
2019-11-13 21:35   ` [EXT] " Bean Huo (beanhuo)
2019-11-08  8:15 ` [PATCH v1 2/5] scsi: ufs: Add new bit field PA_INIT to UECDL register Can Guo
2019-11-12  7:53   ` Avri Altman
2019-11-13  0:41     ` cang [this message]
2019-11-08  8:15 ` [PATCH v1 3/5] scsi: ufs: Update VCCQ2 and VCCQ min voltage hard codes Can Guo
2019-11-12  7:56   ` Avri Altman
2019-11-13  2:56     ` cang
2019-11-08  8:15 ` [PATCH v1 4/5] scsi: ufs: Avoid messing up the compl_time_stamp of lrbs Can Guo
2019-11-12  8:06   ` Avri Altman
2019-11-08  8:15 ` [PATCH v1 5/5] scsi: ufs: Complete pending requests in host reset and restore path Can Guo
2019-11-13  2:24   ` Alim Akhtar
2019-11-13  3:01     ` cang
2019-11-13 22:04   ` [EXT] " Bean Huo (beanhuo)
2019-11-14  1:03     ` cang
2019-11-14  1:18       ` cang
2019-11-14 13:03   ` Bean Huo (beanhuo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ca07e76a0b6c95a116c44c4115508d4@codeaurora.org \
    --to=cang@codeaurora.org \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nguyenb@codeaurora.org \
    --cc=pedrom.sousa@synopsys.com \
    --cc=rnayak@codeaurora.org \
    --cc=salyzyn@google.com \
    --cc=saravanak@google.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.