All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaoyao Li <xiaoyao.li@intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"kas@kernel.org" <kas@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>
Subject: Re: [PATCH v3 4/4] KVM: TDX: Enable Bus Lock VM exit
Date: Thu, 13 Aug 2026 19:17:53 +0800	[thread overview]
Message-ID: <1cf47118-2a19-44d5-ab74-b4c7ffa8890c@intel.com> (raw)
In-Reply-To: <868c0d3c792d789347c767031612977c31cc227f.camel@intel.com>

On 8/13/2026 6:58 AM, Edgecombe, Rick P wrote:
> On Wed, 2026-08-12 at 16:02 +0800, Xiaoyao Li wrote:
>> -	if (unlikely(READ_ONCE(to_kvm_tdx(vcpu->kvm)->wait_for_sept_zap)))
>> +	if (unlikely(READ_ONCE(to_kvm_tdx(vcpu->kvm)->wait_for_sept_zap))) {
>> +		vt->exit_reason.bus_lock_detected = 0;
>>   		return EXIT_FASTPATH_EXIT_HANDLED;
>> +	}
>>   
> 
> This still feels hacky to me. It at least deserves a comment I think. If you
> spin another version.

I spent more time on this today and I find there is an existing issue. 
When the previous Exit Reason is EXIT_REASON_EXTERNAL_INTERRUPT, the 
early return here can go to the path due to the stale exit_reason.

kvm_x86_call(handle_exit_irqoff)(vcpu)
   vmx_handle_exit_irqoff()
     handle_external_interrupt_irqoff()

This makes the host process the external interrupt twice, and maybe more 
times if the wait_for_sept_zap remains longer.

I think we need an separate fix to set

	vt->exit_reasons.full = TDX_INVALID_EXIT_REASON;

so that if some patch is going to consume the stale Exit Reason, it can 
be caught by TDX_INVALID_EXIT_REASON.

  reply	other threads:[~2026-08-13 11:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  8:02 [PATCH v3 0/4] KVM: TDX: Enable VM-DoS Prevention Features for TDX Xiaoyao Li
2026-08-12  8:02 ` [PATCH v3 1/4] KVM: TDX: Enable Notify VM exit Xiaoyao Li
2026-08-12  8:02 ` [PATCH v3 2/4] KVM: TDX: Set bits 31:16 to 0 for the synthesized Exit Reason Xiaoyao Li
2026-08-12 21:58   ` Edgecombe, Rick P
2026-08-12  8:02 ` [PATCH v3 3/4] KVM: TDX: Don't assume exit_reason[31:16] as all-0 in tdx_to_vmx_exit_reason() Xiaoyao Li
2026-08-12  8:23   ` sashiko-bot
2026-08-12  9:07     ` Xiaoyao Li
2026-08-12 22:55       ` Edgecombe, Rick P
2026-08-13 23:44         ` Sean Christopherson
2026-08-14  1:02           ` Xiaoyao Li
2026-08-14 15:12             ` Sean Christopherson
2026-08-17  2:49               ` Xiaoyao Li
2026-08-17 18:19                 ` Sean Christopherson
2026-08-18  8:14                   ` Xiaoyao Li
2026-08-18 20:18                     ` Sean Christopherson
2026-08-13  0:14       ` Sean Christopherson
2026-08-13  8:42         ` Xiaoyao Li
2026-08-12  8:02 ` [PATCH v3 4/4] KVM: TDX: Enable Bus Lock VM exit Xiaoyao Li
2026-08-12  8:20   ` sashiko-bot
2026-08-12  9:11     ` Xiaoyao Li
2026-08-13  0:06       ` Sean Christopherson
2026-08-12 22:58   ` Edgecombe, Rick P
2026-08-13 11:17     ` Xiaoyao Li [this message]
2026-08-13 14:43       ` Sean Christopherson
2026-08-14  0:49         ` Xiaoyao Li
2026-08-14 15:46           ` Sean Christopherson
2026-08-15 13:28             ` Xiaoyao Li
2026-08-17 18:06               ` Sean Christopherson
2026-08-18  7:47                 ` Xiaoyao Li
2026-08-18 16:17                   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cf47118-2a19-44d5-ab74-b4c7ffa8890c@intel.com \
    --to=xiaoyao.li@intel.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.