All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Sean Christopherson <seanjc@google.com>,
	Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: "sashiko-reviews@lists.linux.dev"
	<sashiko-reviews@lists.linux.dev>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] KVM: TDX: Don't assume exit_reason[31:16] as all-0 in tdx_to_vmx_exit_reason()
Date: Fri, 14 Aug 2026 09:02:36 +0800	[thread overview]
Message-ID: <eddf28d4-c211-41fb-b0a3-586e5afde030@intel.com> (raw)
In-Reply-To: <an5W5XC97HK229MX@google.com>

On 8/14/2026 7:44 AM, Sean Christopherson wrote:
> On Wed, Aug 12, 2026, Rick P Edgecombe wrote:
>> Side note. I really dislike how tangled this area is for something that seems
>> like it should be much more straightforward. Deriving partially I think from the
>> overloading of the TDVMCALL leafs with the exit reasons. So we have things like:
>> ...
>> 	case EXIT_REASON_EPT_VIOLATION:
>> 		return EXIT_REASON_EPT_MISCONFIG;
>> ...
> 
> I peeked at that code again, and FWIW I still think swizzling the exit_reason for
> TDVMCALL is the least awful solution.  If we don't do that, then we'll have to
> update every single use of the exit_reason to demux TDVMCALL into the "real" exit
> reason, which will be a mess.

I'm not sure if you read my idea[1]?

I think there is only one place KVM cares about the exit_reason 
TDVMCALL, just the

	case EXIT_REASON_TDCALL:

in tdx_handle_exit().
[1] 
https://lore.kernel.org/all/646f9595-459f-4224-b4e5-4ec2eecc0bc6@intel.com/
> And once we track the exit_reason separately from vp_enter_ret, IMO it all becomes
> more logical and easier to follow.  vp_enter_ret holds the information about why
> VP.ENTER returned/exited, while exit_reason holds information about why the _guest_
> exited.  Obviously it's imperfect since we're still fudging EXIT_REASON_EPT_MISCONFIG,
> but again, I think that's a better alternative than demuxing exit_reason in multiple
> locations.

The question do we really need to swizzle EXIT_REASON_TDCALL to other 
exit reasons ahead? why cannot them just be handled in the central 
handler for EXIT_REASON_TDCALL?

I think there will be more problems when TDX can exit with the reasons 
that are currently swizzled from the TDVMCALL. e.g., when EPT_MISCONFIG 
can happen on private memory.


  reply	other threads:[~2026-08-14  1:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  8:02 [PATCH v3 0/4] KVM: TDX: Enable VM-DoS Prevention Features for TDX Xiaoyao Li
2026-08-12  8:02 ` [PATCH v3 1/4] KVM: TDX: Enable Notify VM exit Xiaoyao Li
2026-08-12  8:02 ` [PATCH v3 2/4] KVM: TDX: Set bits 31:16 to 0 for the synthesized Exit Reason Xiaoyao Li
2026-08-12 21:58   ` Edgecombe, Rick P
2026-08-12  8:02 ` [PATCH v3 3/4] KVM: TDX: Don't assume exit_reason[31:16] as all-0 in tdx_to_vmx_exit_reason() Xiaoyao Li
2026-08-12  8:23   ` sashiko-bot
2026-08-12  9:07     ` Xiaoyao Li
2026-08-12 22:55       ` Edgecombe, Rick P
2026-08-13 23:44         ` Sean Christopherson
2026-08-14  1:02           ` Xiaoyao Li [this message]
2026-08-13  0:14       ` Sean Christopherson
2026-08-13  8:42         ` Xiaoyao Li
2026-08-12  8:02 ` [PATCH v3 4/4] KVM: TDX: Enable Bus Lock VM exit Xiaoyao Li
2026-08-12  8:20   ` sashiko-bot
2026-08-12  9:11     ` Xiaoyao Li
2026-08-13  0:06       ` Sean Christopherson
2026-08-12 22:58   ` Edgecombe, Rick P
2026-08-13 11:17     ` Xiaoyao Li
2026-08-13 14:43       ` Sean Christopherson
2026-08-14  0:49         ` Xiaoyao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eddf28d4-c211-41fb-b0a3-586e5afde030@intel.com \
    --to=xiaoyao.li@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.