From: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: krzk@kernel.org, avri.altman@wdc.com, martin.petersen@oracle.com,
kwmad.kim@samsung.com, stanley.chu@mediatek.com,
cang@codeaurora.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI
Date: Thu, 19 Mar 2020 20:42:19 +0100 [thread overview]
Message-ID: <1d128596eeefb414b7b621b0db5ca0697030dbfc.camel@gmail.com> (raw)
In-Reply-To: <20200319150031.11024-1-alim.akhtar@samsung.com>
On Thu, 2020-03-19 at 20:30 +0530, Alim Akhtar wrote:
> This patch-set introduces UFS (Universal Flash Storage) host controller support
> for Samsung family SoC. Mostly, it consists of UFS PHY and host specific driver.
>
> - Changes since v2:
> * fixed build warning by kbuild test robot
> * Added Reported-by tags
>
> - Changes since v1:
> * fixed make dt_binding_check error as pointed by Rob
> * Addressed Krzysztof's review comments
> * Added Reviewed-by tags
>
>
> patch 1/5: define devicetree bindings for UFS PHY
> patch 2/5: Adds UFS PHY driver
> patch 3/5: define devicetree bindings for UFS HCI
> patch 4/5: Adds Samsung UFS HCI driver
> patch 5/5: Enabled UFS on exynos7 platform
Hi
Is this compatible with Exynos7420? Looking at u-boot source code,
there is Espresso7420 - isn't it the same device? Also this driver
looks very similar to the one from vendor kernel sources (for my
device).
I did tried to run this on my Exynos7420 based device (Samsung S6 Edge
phone) with 5.6-rc6, to get any storage working (since it doesn't have sdcard slot).
At first i got error in exynos_ufs_config_smu. Looking at vendor
sources, on my device only secureos is able to write to those registers
so i fixed it by using smc calls and driver probes fine. Will this be
also supported by driver (maybe in future)?
But now got another error
[ 1.610464] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled
interrupt 0x00000000
[ 1.610629] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000
[ 1.610747] host_regs: 00000010: 00000101 00007fce 00000000 00000000
[ 1.610863] host_regs: 00000020: 00000000 00030e75 00000000 00000000
[ 1.614727] host_regs: 00000030: 0000000f 00000000 00000000 00000000
[ 1.621061] host_regs: 00000040: 00000000 00000000 00000000 00000000
[ 1.627396] host_regs: 00000050: f8c37000 00000000 00000001 00000000
[ 1.633730] host_regs: 00000060: 00000001 00000000 00000000 00000000
[ 1.640065] host_regs: 00000070: f9644000 00000000 00000000 00000000
[ 1.646400] host_regs: 00000080: 00000001 00000000 00000000 00000000
[ 1.652734] host_regs: 00000090: 00000002 95290000 00000000 00000000
[ 1.747649] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled
interrupt 0x00000000
[ 1.747807] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000
[ 1.747924] host_regs: 00000010: 00000101 00007fce 00000000 00000000
[ 1.748041] host_regs: 00000020: 00000000 00030e75 00000000 00000000
[ 1.751909] host_regs: 00000030: 0000000f 00000000 00000000 00000000
[ 1.758244] host_regs: 00000040: 00000000 00000000 00000000 00000000
[ 1.764578] host_regs: 00000050: f8c37000 00000000 00000001 00000000
[ 1.770913] host_regs: 00000060: 00000001 00000000 00000000 00000000
[ 1.777248] host_regs: 00000070: f9644000 00000000 00000000 00000000
[ 1.783582] host_regs: 00000080: 00000001 00000000 00000000 00000000
[ 1.789917] host_regs: 00000090: 00000002 95290000 00000000 00000000
[ 1.884841] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled
interrupt 0x00000000
[ 1.884999] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000
[ 1.885116] host_regs: 00000010: 00000101 00007fce 00000000 00000000
[ 1.885233] host_regs: 00000020: 00000000 00030e75 00000000 00000000
[ 1.889100] host_regs: 00000030: 0000000f 00000000 00000000 00000000
[ 1.895435] host_regs: 00000040: 00000000 00000000 00000000 00000000
[ 1.901770] host_regs: 00000050: f8c37000 00000000 00000001 00000000
[ 1.908104] host_regs: 00000060: 00000001 00000000 00000000 00000000
[ 1.914439] host_regs: 00000070: f9644000 00000000 00000000 00000000
[ 1.920773] host_regs: 00000080: 00000001 00000000 00000000 00000000
[ 1.927108] host_regs: 00000090: 00000002 95290000 00000000 00000000
[ 2.998155] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending
flag query for idn 1 failed, err = -11
[ 4.502138] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending
flag query for idn 1 failed, err = -11
[ 6.006137] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending
flag query for idn 1 failed, err = -11
[ 6.006311] exynos-ufshc 15570000.ufs: ufshcd_query_flag_retry:
query attribute, opcode 5, idn 1, failed with error -11 after 3 retires
[ 6.006545] exynos-ufshc 15570000.ufs: ufshcd_complete_dev_init
reading fDeviceInit flag failed with error -11
Do You have any idea what could be wrong?
Thanks
>
> Note: This series is based on Linux-5.6-rc6 (commit: fb33c6510d55)
>
>
> Alim Akhtar (5):
> dt-bindings: phy: Document Samsung UFS PHY bindings
> phy: samsung-ufs: add UFS PHY driver for samsung SoC
> Documentation: devicetree: ufs: Add DT bindings for exynos UFS host
> controller
> scsi: ufs-exynos: add UFS host support for Exynos SoCs
> arm64: dts: Add node for ufs exynos7
>
> .../bindings/phy/samsung,ufs-phy.yaml | 62 +
> .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++
> .../boot/dts/exynos/exynos7-espresso.dts | 16 +
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 44 +-
> drivers/phy/samsung/Kconfig | 9 +
> drivers/phy/samsung/Makefile | 1 +
> drivers/phy/samsung/phy-exynos7-ufs.h | 85 +
> drivers/phy/samsung/phy-samsung-ufs.c | 311 ++++
> drivers/phy/samsung/phy-samsung-ufs.h | 100 ++
> drivers/scsi/ufs/Kconfig | 12 +
> drivers/scsi/ufs/Makefile | 1 +
> drivers/scsi/ufs/ufs-exynos.c | 1399 +++++++++++++++++
> drivers/scsi/ufs/ufs-exynos.h | 268 ++++
> drivers/scsi/ufs/unipro.h | 41 +
> include/linux/phy/phy-samsung-ufs.h | 70 +
> 15 files changed, 2521 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-exynos.txt
> create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h
> create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c
> create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h
> create mode 100644 drivers/scsi/ufs/ufs-exynos.c
> create mode 100644 drivers/scsi/ufs/ufs-exynos.h
> create mode 100644 include/linux/phy/phy-samsung-ufs.h
>
WARNING: multiple messages have this Message-ID (diff)
From: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
robh+dt@kernel.org, martin.petersen@oracle.com,
linux-kernel@vger.kernel.org, krzk@kernel.org,
kwmad.kim@samsung.com, avri.altman@wdc.com, cang@codeaurora.org,
linux-scsi@vger.kernel.org, stanley.chu@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI
Date: Thu, 19 Mar 2020 20:42:19 +0100 [thread overview]
Message-ID: <1d128596eeefb414b7b621b0db5ca0697030dbfc.camel@gmail.com> (raw)
In-Reply-To: <20200319150031.11024-1-alim.akhtar@samsung.com>
On Thu, 2020-03-19 at 20:30 +0530, Alim Akhtar wrote:
> This patch-set introduces UFS (Universal Flash Storage) host controller support
> for Samsung family SoC. Mostly, it consists of UFS PHY and host specific driver.
>
> - Changes since v2:
> * fixed build warning by kbuild test robot
> * Added Reported-by tags
>
> - Changes since v1:
> * fixed make dt_binding_check error as pointed by Rob
> * Addressed Krzysztof's review comments
> * Added Reviewed-by tags
>
>
> patch 1/5: define devicetree bindings for UFS PHY
> patch 2/5: Adds UFS PHY driver
> patch 3/5: define devicetree bindings for UFS HCI
> patch 4/5: Adds Samsung UFS HCI driver
> patch 5/5: Enabled UFS on exynos7 platform
Hi
Is this compatible with Exynos7420? Looking at u-boot source code,
there is Espresso7420 - isn't it the same device? Also this driver
looks very similar to the one from vendor kernel sources (for my
device).
I did tried to run this on my Exynos7420 based device (Samsung S6 Edge
phone) with 5.6-rc6, to get any storage working (since it doesn't have sdcard slot).
At first i got error in exynos_ufs_config_smu. Looking at vendor
sources, on my device only secureos is able to write to those registers
so i fixed it by using smc calls and driver probes fine. Will this be
also supported by driver (maybe in future)?
But now got another error
[ 1.610464] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled
interrupt 0x00000000
[ 1.610629] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000
[ 1.610747] host_regs: 00000010: 00000101 00007fce 00000000 00000000
[ 1.610863] host_regs: 00000020: 00000000 00030e75 00000000 00000000
[ 1.614727] host_regs: 00000030: 0000000f 00000000 00000000 00000000
[ 1.621061] host_regs: 00000040: 00000000 00000000 00000000 00000000
[ 1.627396] host_regs: 00000050: f8c37000 00000000 00000001 00000000
[ 1.633730] host_regs: 00000060: 00000001 00000000 00000000 00000000
[ 1.640065] host_regs: 00000070: f9644000 00000000 00000000 00000000
[ 1.646400] host_regs: 00000080: 00000001 00000000 00000000 00000000
[ 1.652734] host_regs: 00000090: 00000002 95290000 00000000 00000000
[ 1.747649] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled
interrupt 0x00000000
[ 1.747807] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000
[ 1.747924] host_regs: 00000010: 00000101 00007fce 00000000 00000000
[ 1.748041] host_regs: 00000020: 00000000 00030e75 00000000 00000000
[ 1.751909] host_regs: 00000030: 0000000f 00000000 00000000 00000000
[ 1.758244] host_regs: 00000040: 00000000 00000000 00000000 00000000
[ 1.764578] host_regs: 00000050: f8c37000 00000000 00000001 00000000
[ 1.770913] host_regs: 00000060: 00000001 00000000 00000000 00000000
[ 1.777248] host_regs: 00000070: f9644000 00000000 00000000 00000000
[ 1.783582] host_regs: 00000080: 00000001 00000000 00000000 00000000
[ 1.789917] host_regs: 00000090: 00000002 95290000 00000000 00000000
[ 1.884841] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled
interrupt 0x00000000
[ 1.884999] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000
[ 1.885116] host_regs: 00000010: 00000101 00007fce 00000000 00000000
[ 1.885233] host_regs: 00000020: 00000000 00030e75 00000000 00000000
[ 1.889100] host_regs: 00000030: 0000000f 00000000 00000000 00000000
[ 1.895435] host_regs: 00000040: 00000000 00000000 00000000 00000000
[ 1.901770] host_regs: 00000050: f8c37000 00000000 00000001 00000000
[ 1.908104] host_regs: 00000060: 00000001 00000000 00000000 00000000
[ 1.914439] host_regs: 00000070: f9644000 00000000 00000000 00000000
[ 1.920773] host_regs: 00000080: 00000001 00000000 00000000 00000000
[ 1.927108] host_regs: 00000090: 00000002 95290000 00000000 00000000
[ 2.998155] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending
flag query for idn 1 failed, err = -11
[ 4.502138] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending
flag query for idn 1 failed, err = -11
[ 6.006137] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending
flag query for idn 1 failed, err = -11
[ 6.006311] exynos-ufshc 15570000.ufs: ufshcd_query_flag_retry:
query attribute, opcode 5, idn 1, failed with error -11 after 3 retires
[ 6.006545] exynos-ufshc 15570000.ufs: ufshcd_complete_dev_init
reading fDeviceInit flag failed with error -11
Do You have any idea what could be wrong?
Thanks
>
> Note: This series is based on Linux-5.6-rc6 (commit: fb33c6510d55)
>
>
> Alim Akhtar (5):
> dt-bindings: phy: Document Samsung UFS PHY bindings
> phy: samsung-ufs: add UFS PHY driver for samsung SoC
> Documentation: devicetree: ufs: Add DT bindings for exynos UFS host
> controller
> scsi: ufs-exynos: add UFS host support for Exynos SoCs
> arm64: dts: Add node for ufs exynos7
>
> .../bindings/phy/samsung,ufs-phy.yaml | 62 +
> .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++
> .../boot/dts/exynos/exynos7-espresso.dts | 16 +
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 44 +-
> drivers/phy/samsung/Kconfig | 9 +
> drivers/phy/samsung/Makefile | 1 +
> drivers/phy/samsung/phy-exynos7-ufs.h | 85 +
> drivers/phy/samsung/phy-samsung-ufs.c | 311 ++++
> drivers/phy/samsung/phy-samsung-ufs.h | 100 ++
> drivers/scsi/ufs/Kconfig | 12 +
> drivers/scsi/ufs/Makefile | 1 +
> drivers/scsi/ufs/ufs-exynos.c | 1399 +++++++++++++++++
> drivers/scsi/ufs/ufs-exynos.h | 268 ++++
> drivers/scsi/ufs/unipro.h | 41 +
> include/linux/phy/phy-samsung-ufs.h | 70 +
> 15 files changed, 2521 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-exynos.txt
> create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h
> create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c
> create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h
> create mode 100644 drivers/scsi/ufs/ufs-exynos.c
> create mode 100644 drivers/scsi/ufs/ufs-exynos.h
> create mode 100644 include/linux/phy/phy-samsung-ufs.h
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-19 19:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200319150701epcas5p4bb4365de0a0f4a4a6c7bc533e16d66ec@epcas5p4.samsung.com>
2020-03-19 15:00 ` [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI Alim Akhtar
2020-03-19 15:00 ` Alim Akhtar
2020-03-19 15:00 ` [PATCH v3 1/5] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
2020-03-19 15:00 ` Alim Akhtar
2020-03-20 0:21 ` Rob Herring
2020-03-20 0:21 ` Rob Herring
2020-03-20 0:38 ` Alim Akhtar
2020-03-20 0:38 ` Alim Akhtar
2020-03-19 15:00 ` [PATCH v3 2/5] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
2020-03-19 15:00 ` Alim Akhtar
2020-03-20 5:40 ` Kishon Vijay Abraham I
2020-03-20 5:40 ` Kishon Vijay Abraham I
2020-03-20 11:46 ` Alim Akhtar
2020-03-20 11:46 ` Alim Akhtar
2020-03-19 15:00 ` [PATCH v3 3/5] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Alim Akhtar
2020-03-19 15:00 ` Alim Akhtar
2020-03-19 15:00 ` [PATCH v3 4/5] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2020-03-19 15:00 ` Alim Akhtar
2020-03-22 12:24 ` Avri Altman
2020-03-22 12:24 ` Avri Altman
2020-03-25 16:30 ` Alim Akhtar
2020-03-25 16:30 ` Alim Akhtar
2020-03-19 15:00 ` [PATCH v3 5/5] arm64: dts: Add node for ufs exynos7 Alim Akhtar
2020-03-19 15:00 ` Alim Akhtar
2020-03-19 19:42 ` Paweł Chmiel [this message]
2020-03-19 19:42 ` [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI Paweł Chmiel
2020-03-20 14:10 ` Alim Akhtar
2020-03-20 14:10 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d128596eeefb414b7b621b0db5ca0697030dbfc.camel@gmail.com \
--to=pawel.mikolaj.chmiel@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.