All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts
Date: Wed, 13 Nov 2013 20:57:23 +1300	[thread overview]
Message-ID: <1d531dbddb96cdcb0dfbc1183ee6d443@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1311121956480.30673@ionos.tec.linutronix.de>

Thomas,

>> I suppose setting the flag can be done in the corresponding irq 
>> startup
>> function, instead of when setting up the irq controller?
>
> irq_startup() is called with irq_desc->lock held and
> irq_set_status_flags() wants desc->lock as well. Deadlock

Thanks, point taken.

> And no, you don't want to fiddle manually in the irq descriptor data
> fields. See commit a6967caf00eb :)

I'm not that crazy :-)

>
>> Geert - I will send the patch to ataints.c implementing this as soon 
>> as
>> Thomas' fix is merged.
>
> I'll expedite it for 3.13.

Thanks, that'll help.

Cheers,

	Michael


>
> Thanks,
>
> 	tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" 
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-11-13  7:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31  0:23 [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts Michael Schmitz
2013-02-10 10:36 ` Geert Uytterhoeven
2013-03-20  8:54   ` Geert Uytterhoeven
2013-11-06 11:30     ` Thomas Gleixner
2013-11-07  7:59       ` Michael Schmitz
2013-11-10  8:33       ` Michael Schmitz
2013-11-12 19:08         ` Thomas Gleixner
2013-11-13  7:57           ` Michael Schmitz [this message]
2013-11-13 19:42       ` [tip:irq/urgent] genirq: Prevent spurious detection for unconditionally polled interrupts tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d531dbddb96cdcb0dfbc1183ee6d443@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.