From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.com, shuah@kernel.org, alsa-devel@alsa-project.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH] Fix snprintf format warnings during 'alsa' kselftest compilation
Date: Thu, 23 Feb 2023 23:14:56 +0300 [thread overview]
Message-ID: <1db3bfe5-0982-b445-9c94-784478279028@gmail.com> (raw)
In-Reply-To: <Y/eAyrYs+wEu180d@sirena.org.uk>
On 23.02.2023 18:05, Mark Brown wrote:
> What warnings are you seeing in what configuration (arch, toolchain, any
> custom options...)? I'm not seeing anything when I test. Are these
> perhaps architecture dependent warnings?
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Thank you for the review! I will follow the common subject lines style
in the future.
I compiled the test via gcc 11.3.0 without any custom options, the arch
is x86_64. There were five warnings during the test compilation, and all
of them were caused by incorrect format in 'snprintf' function calls. As
I know, using incorrect format in 'snprintf' creates an undefined
behavior. Maybe there is a point to fix it?
WARNING: multiple messages have this Message-ID (diff)
From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: perex@perex.cz, tiwai@suse.com, shuah@kernel.org,
alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] Fix snprintf format warnings during 'alsa' kselftest compilation
Date: Thu, 23 Feb 2023 23:14:56 +0300 [thread overview]
Message-ID: <1db3bfe5-0982-b445-9c94-784478279028@gmail.com> (raw)
In-Reply-To: <Y/eAyrYs+wEu180d@sirena.org.uk>
On 23.02.2023 18:05, Mark Brown wrote:
> What warnings are you seeing in what configuration (arch, toolchain, any
> custom options...)? I'm not seeing anything when I test. Are these
> perhaps architecture dependent warnings?
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Thank you for the review! I will follow the common subject lines style
in the future.
I compiled the test via gcc 11.3.0 without any custom options, the arch
is x86_64. There were five warnings during the test compilation, and all
of them were caused by incorrect format in 'snprintf' function calls. As
I know, using incorrect format in 'snprintf' creates an undefined
behavior. Maybe there is a point to fix it?
next prev parent reply other threads:[~2023-02-24 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 14:32 [PATCH] Fix snprintf format warnings during 'alsa' kselftest compilation Ivan Orlov
2023-02-23 15:05 ` Mark Brown
2023-02-23 15:05 ` Mark Brown
2023-02-23 20:14 ` Ivan Orlov [this message]
2023-02-23 20:14 ` Ivan Orlov
2023-02-27 14:12 ` Mark Brown
2023-02-27 14:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db3bfe5-0982-b445-9c94-784478279028@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.