All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Amos Kong <akong@redhat.com>
Cc: <etherboot-developers@lists.sourceforge.net>,
	<jasowang@redhat.com>, <mdc@etherboot.org>, <ehabkost@redhat.com>,
	<kvm@vger.kernel.org>
Subject: Re: [PATCH] [dhcp] Use random transaction ID to associate messages
Date: Thu, 15 Sep 2011 15:28:07 +0200	[thread overview]
Message-ID: <1dcfd0cfb392de1b74b78b7ecb05fb4c@localhost> (raw)
In-Reply-To: <20110915130038.5049.51425.stgit@localhost6.localdomain6>


On Thu, 15 Sep 2011 21:00:38 +0800, Amos Kong <akong@redhat.com> wrote:



> +	netdev->xid = random();



This will not work for reboots. The decision that the hardware address is

choosen was not accidental. Not sure if some DHCP server will count on the

ID. (RFC 2131 "Retain DHCP client configuration across server reboots, and,

whenever possible, a DHCP client should be assigned the same configuration

parameters despite restarts of the DHCP mechanism"). If not so I am fine

with the patch.



Hagen



  reply	other threads:[~2011-09-15 13:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 13:00 [PATCH] [dhcp] Use random transaction ID to associate messages Amos Kong
2011-09-15 13:28 ` Hagen Paul Pfeifer [this message]
2011-09-15 14:13   ` Yaniv Kaul
2011-09-15 14:34     ` Sasha Levin
     [not found]     ` <1441335413.692660.1316096032278.JavaMail.root-rwXUz/BPrj9+R5eDjrG6zsCp5Q1pQRjfhaY/URYTgi6ny3qCrzbmXA@public.gmane.org>
2011-09-15 14:43       ` Amos Kong
2011-09-15 14:53         ` Sasha Levin
2011-09-15 15:55           ` Amos Kong
     [not found]             ` <1339054677.695312.1316102130826.JavaMail.root-rwXUz/BPrj9+R5eDjrG6zsCp5Q1pQRjfhaY/URYTgi6ny3qCrzbmXA@public.gmane.org>
2011-09-18  1:05               ` Amos Kong
2011-09-15 18:09           ` Eduardo Habkost
2011-09-17  0:36           ` Amos Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dcfd0cfb392de1b74b78b7ecb05fb4c@localhost \
    --to=hagen@jauu.net \
    --cc=akong@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=etherboot-developers@lists.sourceforge.net \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mdc@etherboot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.