All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Anup Patel <apatel@ventanamicro.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Conor Dooley <conor@kernel.org>,
	Andrew Jones <ajones@ventanamicro.com>,
	linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Atish Patra <atishp@rivosinc.com>
Subject: Re: [PATCH v4 4/5] tty: Add SBI debug console support to HVC SBI driver
Date: Mon, 20 Nov 2023 08:16:00 +0100	[thread overview]
Message-ID: <1dd7f7b4-d2ba-4216-ac3f-3552c2bee24b@kernel.org> (raw)
In-Reply-To: <20231118033859.726692-5-apatel@ventanamicro.com>

On 18. 11. 23, 4:38, Anup Patel wrote:
> diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c
> index 31f53fa77e4a..697c981221b5 100644
> --- a/drivers/tty/hvc/hvc_riscv_sbi.c
> +++ b/drivers/tty/hvc/hvc_riscv_sbi.c
...
> -static int __init hvc_sbi_console_init(void)
> +static int hvc_sbi_dbcn_tty_get(uint32_t vtermno, char *buf, int count)
>   {
> -	hvc_instantiate(0, 0, &hvc_sbi_ops);
> +	phys_addr_t pa;
> +
> +	if (is_vmalloc_addr(buf)) {

I wonder, where does this buf come from, so that you have to check for 
vmalloc?

> +		pa = page_to_phys(vmalloc_to_page(buf)) + offset_in_page(buf);
> +		if (PAGE_SIZE < (offset_in_page(buf) + count))

Am I the only one who would prefer:
   if (count + offset_in_page(buf) > PAGE_SIZE)
?

> +			count = PAGE_SIZE - offset_in_page(buf);
> +	} else {
> +		pa = __pa(buf);
> +	}
> +
> +	return sbi_debug_console_read(count, pa);
> +}


thanks,
-- 
js
suse labs


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: Anup Patel <apatel@ventanamicro.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Conor Dooley <conor@kernel.org>,
	Andrew Jones <ajones@ventanamicro.com>,
	linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Atish Patra <atishp@rivosinc.com>
Subject: Re: [PATCH v4 4/5] tty: Add SBI debug console support to HVC SBI driver
Date: Mon, 20 Nov 2023 08:16:00 +0100	[thread overview]
Message-ID: <1dd7f7b4-d2ba-4216-ac3f-3552c2bee24b@kernel.org> (raw)
In-Reply-To: <20231118033859.726692-5-apatel@ventanamicro.com>

On 18. 11. 23, 4:38, Anup Patel wrote:
> diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c
> index 31f53fa77e4a..697c981221b5 100644
> --- a/drivers/tty/hvc/hvc_riscv_sbi.c
> +++ b/drivers/tty/hvc/hvc_riscv_sbi.c
...
> -static int __init hvc_sbi_console_init(void)
> +static int hvc_sbi_dbcn_tty_get(uint32_t vtermno, char *buf, int count)
>   {
> -	hvc_instantiate(0, 0, &hvc_sbi_ops);
> +	phys_addr_t pa;
> +
> +	if (is_vmalloc_addr(buf)) {

I wonder, where does this buf come from, so that you have to check for 
vmalloc?

> +		pa = page_to_phys(vmalloc_to_page(buf)) + offset_in_page(buf);
> +		if (PAGE_SIZE < (offset_in_page(buf) + count))

Am I the only one who would prefer:
   if (count + offset_in_page(buf) > PAGE_SIZE)
?

> +			count = PAGE_SIZE - offset_in_page(buf);
> +	} else {
> +		pa = __pa(buf);
> +	}
> +
> +	return sbi_debug_console_read(count, pa);
> +}


thanks,
-- 
js
suse labs


WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: Anup Patel <apatel@ventanamicro.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Atish Patra <atishp@rivosinc.com>,
	linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>,
	linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org,
	Andrew Jones <ajones@ventanamicro.com>
Subject: Re: [PATCH v4 4/5] tty: Add SBI debug console support to HVC SBI driver
Date: Mon, 20 Nov 2023 08:16:00 +0100	[thread overview]
Message-ID: <1dd7f7b4-d2ba-4216-ac3f-3552c2bee24b@kernel.org> (raw)
In-Reply-To: <20231118033859.726692-5-apatel@ventanamicro.com>

On 18. 11. 23, 4:38, Anup Patel wrote:
> diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c
> index 31f53fa77e4a..697c981221b5 100644
> --- a/drivers/tty/hvc/hvc_riscv_sbi.c
> +++ b/drivers/tty/hvc/hvc_riscv_sbi.c
...
> -static int __init hvc_sbi_console_init(void)
> +static int hvc_sbi_dbcn_tty_get(uint32_t vtermno, char *buf, int count)
>   {
> -	hvc_instantiate(0, 0, &hvc_sbi_ops);
> +	phys_addr_t pa;
> +
> +	if (is_vmalloc_addr(buf)) {

I wonder, where does this buf come from, so that you have to check for 
vmalloc?

> +		pa = page_to_phys(vmalloc_to_page(buf)) + offset_in_page(buf);
> +		if (PAGE_SIZE < (offset_in_page(buf) + count))

Am I the only one who would prefer:
   if (count + offset_in_page(buf) > PAGE_SIZE)
?

> +			count = PAGE_SIZE - offset_in_page(buf);
> +	} else {
> +		pa = __pa(buf);
> +	}
> +
> +	return sbi_debug_console_read(count, pa);
> +}


thanks,
-- 
js
suse labs


  reply	other threads:[~2023-11-20  7:16 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  3:38 [PATCH v4 0/5] RISC-V SBI debug console extension support Anup Patel
2023-11-18  3:38 ` Anup Patel
2023-11-18  3:38 ` Anup Patel
2023-11-18  3:38 ` [PATCH v4 1/5] RISC-V: Add stubs for sbi_console_putchar/getchar() Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-21 22:36   ` Samuel Holland
2023-11-21 22:36     ` Samuel Holland
2023-11-21 22:36     ` Samuel Holland
2023-11-23 10:38     ` Anup Patel
2023-11-23 10:38       ` Anup Patel
2023-11-23 10:38       ` Anup Patel
2023-11-23 14:45       ` Samuel Holland
2023-11-23 14:45         ` Samuel Holland
2023-11-23 14:45         ` Samuel Holland
2023-11-18  3:38 ` [PATCH v4 2/5] RISC-V: Add SBI debug console helper routines Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-20  8:05   ` Andrew Jones
2023-11-20  8:05     ` Andrew Jones
2023-11-20  8:05     ` Andrew Jones
2023-11-23 10:47     ` Anup Patel
2023-11-23 10:47       ` Anup Patel
2023-11-23 10:47       ` Anup Patel
2023-11-21 22:45   ` Samuel Holland
2023-11-21 22:45     ` Samuel Holland
2023-11-21 22:45     ` Samuel Holland
2023-11-23 10:44     ` Anup Patel
2023-11-23 10:44       ` Anup Patel
2023-11-23 10:44       ` Anup Patel
2023-11-18  3:38 ` [PATCH v4 3/5] tty/serial: Add RISC-V SBI debug console based earlycon Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-21 22:41   ` Samuel Holland
2023-11-21 22:41     ` Samuel Holland
2023-11-21 22:41     ` Samuel Holland
2023-11-23 10:43     ` Anup Patel
2023-11-23 10:43       ` Anup Patel
2023-11-23 10:43       ` Anup Patel
2023-11-18  3:38 ` [PATCH v4 4/5] tty: Add SBI debug console support to HVC SBI driver Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-20  7:16   ` Jiri Slaby [this message]
2023-11-20  7:16     ` Jiri Slaby
2023-11-20  7:16     ` Jiri Slaby
2023-11-21  8:21     ` Atish Kumar Patra
2023-11-21  8:21       ` Atish Kumar Patra
2023-11-21  8:21       ` Atish Kumar Patra
2023-11-18  3:38 ` [PATCH v4 5/5] RISC-V: Enable SBI based earlycon support Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-18  3:38   ` Anup Patel
2023-11-21 22:48   ` Samuel Holland
2023-11-21 22:48     ` Samuel Holland
2023-11-21 22:48     ` Samuel Holland
2023-11-23 10:39     ` Anup Patel
2023-11-23 10:39       ` Anup Patel
2023-11-23 10:39       ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dd7f7b4-d2ba-4216-ac3f-3552c2bee24b@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=ajones@ventanamicro.com \
    --cc=apatel@ventanamicro.com \
    --cc=atishp@rivosinc.com \
    --cc=conor@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.