From: Mark Salyzyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jan Kara <jack@suse.cz>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Brandenburg <martin@omnibond.com>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Paris <eparis@parisplace.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.c>
Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 07:37:04 -0800 [thread overview]
Message-ID: <1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com> (raw)
In-Reply-To: <20191105094830.GL22379@quack2.suse.cz>
On 11/5/19 1:48 AM, Jan Kara wrote:
>> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
>> break;
>> case 1:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> break;
>> case 2:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> break;
>> case 3:
> These scnprintf() changes (and there are more in the patch) probably
> shouldn't be here... Otherwise the patch still looks good to me :).
>
> Honza
>
Good catch, they were done in locality, I forgot about them, this patch
series has been living for almost a year now and time has become its
enemy ... will spin this as a separate patch. They strike as a security
issue with the possibility of fragile UAF when the code is maintained by
future selves.
-- Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 07:37:04 -0800 [thread overview]
Message-ID: <1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com> (raw)
In-Reply-To: <20191105094830.GL22379@quack2.suse.cz>
On 11/5/19 1:48 AM, Jan Kara wrote:
>> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
>> break;
>> case 1:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> break;
>> case 2:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> break;
>> case 3:
> These scnprintf() changes (and there are more in the patch) probably
> shouldn't be here... Otherwise the patch still looks good to me :).
>
> Honza
>
Good catch, they were done in locality, I forgot about them, this patch
series has been living for almost a year now and time has become its
enemy ... will spin this as a separate patch. They strike as a security
issue with the possibility of fragile UAF when the code is maintained by
future selves.
-- Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Jan Kara <jack@suse.cz>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Brandenburg <martin@omnibond.com>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Paris <eparis@parisplace.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>, Eric Biggers <ebiggers@google.com>,
Hugh Dickins <hughd@google.com>, James Morris <jmorris@namei.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
cluster-devel@redhat.com, selinux@vger.kernel.org,
Benjamin Coddington <bcodding@redhat.com>,
Casey Schaufler <casey@schaufler-ca.com>,
v9fs-developer@lists.sourceforge.net,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
linux-mm@kvack.org, Mark Salyzyn <salyzyn@google.com>,
Serge Hallyn <serge@hallyn.com>,
ecryptfs@vger.kernel.org, linux-cifs@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>,
linux-erofs@lists.ozlabs.org, Josef Bacik <josef@toxicpanda.com>,
reiserfs-devel@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Joel Becker <jlbec@evilplan.org>,
linux-mtd@lists.infradead.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, devel@lists.orangefs.org,
Gao Xiang <xiang@kernel.org>, Mimi Zohar <zohar@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
linux-nfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Mathieu Malaterre <malat@debian.org>,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
Steve French <sfrench@samba.org>,
linux-security-module@vger.kernel.org,
ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.com>,
Bob Peterson <rpeterso@redhat.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 07:37:04 -0800 [thread overview]
Message-ID: <1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com> (raw)
In-Reply-To: <20191105094830.GL22379@quack2.suse.cz>
On 11/5/19 1:48 AM, Jan Kara wrote:
>> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
>> break;
>> case 1:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> break;
>> case 2:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> break;
>> case 3:
> These scnprintf() changes (and there are more in the patch) probably
> shouldn't be here... Otherwise the patch still looks good to me :).
>
> Honza
>
Good catch, they were done in locality, I forgot about them, this patch
series has been living for almost a year now and time has become its
enemy ... will spin this as a separate patch. They strike as a security
issue with the possibility of fragile UAF when the code is maintained by
future selves.
-- Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jan Kara <jack@suse.cz>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Brandenburg <martin@omnibond.com>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Paris <eparis@parisplace.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>, Eric Biggers <ebiggers@google.com>,
Hugh Dickins <hughd@google.com>, James Morris <jmorris@namei.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
cluster-devel@redhat.com, selinux@vger.kernel.org,
Benjamin Coddington <bcodding@redhat.com>,
Casey Schaufler <casey@schaufler-ca.com>,
v9fs-developer@lists.sourceforge.net,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
linux-mm@kvack.org, Mark Salyzyn <salyzyn@google.com>,
Serge Hallyn <serge@hallyn.com>,
ecryptfs@vger.kernel.org, linux-cifs@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>,
linux-erofs@lists.ozlabs.org, Josef Bacik <josef@toxicpanda.com>,
reiserfs-devel@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Joel Becker <jlbec@evilplan.org>,
linux-mtd@lists.infradead.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, devel@lists.orangefs.org,
Gao Xiang <xiang@kernel.org>, Mimi Zohar <zohar@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
linux-nfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Mathieu Malaterre <malat@debian.org>,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
Steve French <sfrench@samba.org>,
linux-security-module@vger.kernel.org,
ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.com>,
Bob Peterson <rpeterso@redhat.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [f2fs-dev] [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 07:37:04 -0800 [thread overview]
Message-ID: <1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com> (raw)
In-Reply-To: <20191105094830.GL22379@quack2.suse.cz>
On 11/5/19 1:48 AM, Jan Kara wrote:
>> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
>> break;
>> case 1:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> break;
>> case 2:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> break;
>> case 3:
> These scnprintf() changes (and there are more in the patch) probably
> shouldn't be here... Otherwise the patch still looks good to me :).
>
> Honza
>
Good catch, they were done in locality, I forgot about them, this patch
series has been living for almost a year now and time has become its
enemy ... will spin this as a separate patch. They strike as a security
issue with the possibility of fragile UAF when the code is maintained by
future selves.
-- Mark
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: Jan Kara <jack@suse.cz>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martin Brandenburg <martin@omnibond.com>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Eric Paris <eparis@parisplace.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
netdev@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-afs@lists.infradead.org,
Mike Marshall <hubcap@omnibond.com>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>, Eric Biggers <ebiggers@google.com>,
Hugh Dickins <hughd@google.com>, James Morris <jmorris@namei.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
cluster-devel@redhat.com, selinux@vger.kernel.org,
Benjamin Coddington <bcodding@redhat.com>,
Casey Schaufler <casey@schaufler-ca.com>,
v9fs-developer@lists.sourceforge.net,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
linux-mm@kvack.org, Mark Salyzyn <salyzyn@google.com>,
Serge Hallyn <serge@hallyn.com>,
ecryptfs@vger.kernel.org, linux-cifs@vger.kernel.org,
Eric Van Hensbergen <ericvh@gmail.com>, Chao Yu <chao@kernel.org>,
linux-erofs@lists.ozlabs.org, Josef Bacik <josef@toxicpanda.com>,
reiserfs-devel@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Joel Becker <jlbec@evilplan.org>,
linux-mtd@lists.infradead.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, devel@lists.orangefs.org,
Gao Xiang <xiang@kernel.org>, Mimi Zohar <zohar@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
linux-nfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Mathieu Malaterre <malat@debian.org>,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
Steve French <sfrench@samba.org>,
linux-security-module@vger.kernel.org,
ocfs2-devel@oss.oracle.com, Jan Kara <jack@suse.com>,
Bob Peterson <rpeterso@redhat.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 07:37:04 -0800 [thread overview]
Message-ID: <1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com> (raw)
In-Reply-To: <20191105094830.GL22379@quack2.suse.cz>
On 11/5/19 1:48 AM, Jan Kara wrote:
>> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
>> break;
>> case 1:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> break;
>> case 2:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> break;
>> case 3:
> These scnprintf() changes (and there are more in the patch) probably
> shouldn't be here... Otherwise the patch still looks good to me :).
>
> Honza
>
Good catch, they were done in locality, I forgot about them, this patch
series has been living for almost a year now and time has become its
enemy ... will spin this as a separate patch. They strike as a security
issue with the possibility of fragile UAF when the code is maintained by
future selves.
-- Mark
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
Mark Salyzyn <salyzyn@google.com>,
Jeff Layton <jlayton@kernel.org>, David Sterba <dsterba@suse.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Mike Marshall <hubcap@omnibond.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
linux-security-module@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>, Sage Weil <sage@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
Steve French <sfrench@samba.org>,
Tyler Hicks <tyhicks@canonical.com>, Gao Xiang <xiang@kernel.org>,
Chao Yu <chao@kernel.org>, Jan Kara <jack@suse.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>,
Dave Kleikamp <shaggy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Martin Brandenburg <martin@omnibond.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Phillip Lougher <phillip@squashfs.org.uk>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-xfs@vger.kernel.org, Hugh Dickins <hughd@google.com>,
"David S. Miller" <davem@davemloft.net>,
Serge Hallyn <serge@hallyn.com>, James Morris <jmorris@namei.org>,
Mimi Zohar <zohar@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@parisplace.org>,
Casey Schaufler <casey@schaufler-ca.com>,
Benjamin Coddington <bcodding@redhat.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Eric Biggers <ebiggers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Malaterre <malat@debian.org>,
linux-doc@vger.kernel.org, v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, ecryptfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr
Date: Tue, 5 Nov 2019 07:37:04 -0800 [thread overview]
Message-ID: <1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com> (raw)
In-Reply-To: <20191105094830.GL22379@quack2.suse.cz>
On 11/5/19 1:48 AM, Jan Kara wrote:
>> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler,
>> break;
>> case 1:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag);
>> break;
>> case 2:
>> data = buf;
>> - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned);
>> break;
>> case 3:
> These scnprintf() changes (and there are more in the patch) probably
> shouldn't be here... Otherwise the patch still looks good to me :).
>
> Honza
>
Good catch, they were done in locality, I forgot about them, this patch
series has been living for almost a year now and time has become its
enemy ... will spin this as a separate patch. They strike as a security
issue with the possibility of fragile UAF when the code is maintained by
future selves.
-- Mark
next prev parent reply other threads:[~2019-11-05 15:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 21:52 [PATCH v15 0/4] overlayfs override_creds=off & nested get xattr fix Mark Salyzyn
2019-11-04 21:52 ` [PATCH v15 1/4] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn via Linux-f2fs-devel
2019-11-04 21:52 ` Mark Salyzyn
2019-11-04 21:52 ` Mark Salyzyn
2019-11-04 21:52 ` [f2fs-dev] " Mark Salyzyn via Linux-f2fs-devel
2019-11-04 21:52 ` Mark Salyzyn via Linux-erofs
2019-11-04 21:52 ` [Cluster-devel] " Mark Salyzyn
2019-11-05 9:48 ` Jan Kara
2019-11-05 9:48 ` Jan Kara
2019-11-05 9:48 ` Jan Kara
2019-11-05 9:48 ` [f2fs-dev] " Jan Kara
2019-11-05 9:48 ` Jan Kara
2019-11-05 9:48 ` Jan Kara
2019-11-05 9:48 ` [Cluster-devel] " Jan Kara
2019-11-05 15:37 ` Mark Salyzyn via Linux-f2fs-devel [this message]
2019-11-05 15:37 ` Mark Salyzyn
2019-11-05 15:37 ` Mark Salyzyn
2019-11-05 15:37 ` [f2fs-dev] " Mark Salyzyn via Linux-f2fs-devel
2019-11-05 15:37 ` Mark Salyzyn via Linux-erofs
2019-11-05 15:37 ` [Cluster-devel] " Mark Salyzyn
2019-11-04 21:52 ` [PATCH v15 2/4] overlayfs: handle XATTR_NOSECURITY flag for get xattr method Mark Salyzyn
2019-11-04 21:52 ` [PATCH v15 3/4] overlayfs: internal getxattr operations without sepolicy checking Mark Salyzyn
2019-11-04 21:52 ` [PATCH v15 4/4] overlayfs: override_creds=off option bypass creator_cred Mark Salyzyn
2019-11-05 7:56 ` [PATCH v15 0/4] overlayfs override_creds=off & nested get xattr fix Amir Goldstein
2019-11-05 15:20 ` Mark Salyzyn
2019-11-05 19:25 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de43656-e751-53a2-c0da-ff44ecbabbc4@android.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.c \
--cc=asmadeus@codewreck.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=dhowells@redhat.com \
--cc=eparis@parisplace.org \
--cc=gregkh@linuxfoundation.org \
--cc=hubcap@omnibond.com \
--cc=jack@suse.cz \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-afs@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=martin@omnibond.com \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.