All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Robin Murphy <robin.murphy@arm.com>, joro@8bytes.org, will@kernel.org
Cc: linux-kernel@vger.kernel.org, willy@infradead.org,
	linux-mm@kvack.org, iommu@lists.linux-foundation.org, hch@lst.de
Subject: Re: [PATCH v3 6/9] iommu/vt-d: Use put_pages_list
Date: Mon, 20 Dec 2021 09:18:29 +0800	[thread overview]
Message-ID: <1df4cd6c-7f70-4358-e57f-754d98807abe@linux.intel.com> (raw)
In-Reply-To: <2115b560d9a0ce7cd4b948bd51a2b7bde8fdfd59.1639753638.git.robin.murphy@arm.com>

Hi Robin,

On 12/17/21 11:31 PM, Robin Murphy wrote:
> From: "Matthew Wilcox (Oracle)"<willy@infradead.org>
> 
> page->freelist is for the use of slab.  We already have the ability
> to free a list of pages in the core mm, but it requires the use of a
> list_head and for the pages to be chained together through page->lru.
> Switch the Intel IOMMU and IOVA code over to using free_pages_list().
> 
> Signed-off-by: Matthew Wilcox (Oracle)<willy@infradead.org>
> [rm: split from original patch, cosmetic tweaks, fix fq entries]
> Signed-off-by: Robin Murphy<robin.murphy@arm.com>

I had boot tests on my development machines with both strict and lazy
flushing modes. I didn't see any regression, the disk i/o and network
i/o worked good for me.

For changes in iommu/vt-d:

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Robin Murphy <robin.murphy@arm.com>, joro@8bytes.org, will@kernel.org
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
	suravee.suthikulpanit@amd.com, willy@infradead.org,
	linux-kernel@vger.kernel.org, john.garry@huawei.com,
	linux-mm@kvack.org, hch@lst.de
Subject: Re: [PATCH v3 6/9] iommu/vt-d: Use put_pages_list
Date: Mon, 20 Dec 2021 09:18:29 +0800	[thread overview]
Message-ID: <1df4cd6c-7f70-4358-e57f-754d98807abe@linux.intel.com> (raw)
In-Reply-To: <2115b560d9a0ce7cd4b948bd51a2b7bde8fdfd59.1639753638.git.robin.murphy@arm.com>

Hi Robin,

On 12/17/21 11:31 PM, Robin Murphy wrote:
> From: "Matthew Wilcox (Oracle)"<willy@infradead.org>
> 
> page->freelist is for the use of slab.  We already have the ability
> to free a list of pages in the core mm, but it requires the use of a
> list_head and for the pages to be chained together through page->lru.
> Switch the Intel IOMMU and IOVA code over to using free_pages_list().
> 
> Signed-off-by: Matthew Wilcox (Oracle)<willy@infradead.org>
> [rm: split from original patch, cosmetic tweaks, fix fq entries]
> Signed-off-by: Robin Murphy<robin.murphy@arm.com>

I had boot tests on my development machines with both strict and lazy
flushing modes. I didn't see any regression, the disk i/o and network
i/o worked good for me.

For changes in iommu/vt-d:

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu


  reply	other threads:[~2021-12-20  1:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 15:30 [PATCH v3 0/9] iommu: refactor flush queues into iommu-dma Robin Murphy
2021-12-17 15:30 ` Robin Murphy
2021-12-17 15:30 ` [PATCH v3 1/9] iommu/iova: Fix race between FQ timeout and teardown Robin Murphy
2021-12-17 15:30   ` Robin Murphy
2021-12-17 15:30 ` [PATCH v3 2/9] iommu/iova: Squash entry_dtor abstraction Robin Murphy
2021-12-17 15:30   ` Robin Murphy
2021-12-17 15:30 ` [PATCH v3 3/9] iommu/iova: Squash flush_cb abstraction Robin Murphy
2021-12-17 15:30   ` Robin Murphy
2021-12-17 15:30 ` [PATCH v3 4/9] iommu/amd: Simplify pagetable freeing Robin Murphy
2021-12-17 15:30   ` Robin Murphy
2021-12-17 15:30 ` [PATCH v3 5/9] iommu/amd: Use put_pages_list Robin Murphy
2021-12-17 15:30   ` Robin Murphy
2021-12-17 15:31 ` [PATCH v3 6/9] iommu/vt-d: " Robin Murphy
2021-12-17 15:31   ` Robin Murphy
2021-12-20  1:18   ` Lu Baolu [this message]
2021-12-20  1:18     ` Lu Baolu
2021-12-17 15:31 ` [PATCH v3 7/9] iommu/iova: Consolidate flush queue code Robin Murphy
2021-12-17 15:31   ` Robin Murphy
2021-12-17 15:31 ` [PATCH v3 8/9] iommu/iova: Move flush queue code to iommu-dma Robin Murphy
2021-12-17 15:31   ` Robin Murphy
2021-12-17 15:31 ` [PATCH v3 9/9] iommu: Move flush queue data into iommu_dma_cookie Robin Murphy
2021-12-17 15:31   ` Robin Murphy
2021-12-20  8:03 ` [PATCH v3 0/9] iommu: refactor flush queues into iommu-dma Joerg Roedel
2021-12-20  8:03   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1df4cd6c-7f70-4358-e57f-754d98807abe@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.