From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
patrick.fu@intel.com, dev@dpdk.org, chenbo.xia@intel.com
Cc: yinan.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations
Date: Mon, 20 Jul 2020 17:49:35 +0100 [thread overview]
Message-ID: <1e17ca06-a1d3-1ecb-16fc-a35164f48c41@intel.com> (raw)
In-Reply-To: <ad2568c1-51a8-3d51-1546-44048d4d8443@redhat.com>
On 7/20/2020 3:58 PM, Maxime Coquelin wrote:
> Hi Patrick,
>
> On 7/15/20 1:15 PM, patrick.fu@intel.com wrote:
>> From: Patrick Fu <patrick.fu@intel.com>
>>
>> Vhost async enqueue assumes that all async copies should break at packet
>> boundary. i.e. if a packet is splited into multiple copy segments, the
>> async engine should always report copy completion when entire packet is
>> finished. This patch removes the assumption.
>
> Could you please rework the commit message and title?
> It is hard to understand what the patch is doing and why.
Existing commit dropped from next-net and patchwork status updated.
>
> Thanks in advance,
> Maxime
>
>> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
>>
>> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
<...>
next prev parent reply other threads:[~2020-07-20 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 7:46 [dpdk-dev] [PATCH v1] vhost: support async copy free segmentations patrick.fu
2020-07-15 11:15 ` [dpdk-dev] [PATCH v2] " patrick.fu
2020-07-17 3:21 ` Xia, Chenbo
2020-07-17 11:52 ` Ferruh Yigit
2020-07-20 14:58 ` Maxime Coquelin
2020-07-20 16:49 ` Ferruh Yigit [this message]
2020-07-21 5:52 ` Fu, Patrick
2020-07-21 5:47 ` [dpdk-dev] [PATCH v3] vhost: fix wrong async completion of multi-seg packets patrick.fu
2020-07-21 8:40 ` Maxime Coquelin
2020-07-21 14:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e17ca06-a1d3-1ecb-16fc-a35164f48c41@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=patrick.fu@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.