Re: [dpdk-dev] [PATCH v3] vhost: fix wrong async completion of multi-seg packets

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 7/21/2020 9:40 AM, Maxime Coquelin wrote:
> 
> 
> On 7/21/20 7:47 AM, patrick.fu@intel.com wrote:
>> From: Patrick Fu <patrick.fu@intel.com>
>>
>> In async enqueue copy, a packet could be split into multiple copy
>> segments. When polling the copy completion status, current async data
>> path assumes the async device callbacks are aware of the packet
>> boundary and return completed segments only if all segments belonging
>> to the same packet are done. Such assumption are not generic to common
>> async devices and may degrees the copy performance if async callbacks
> 
> s/degrees/degrades/
> 
>> have to implement it in software manner.
>>
>> This patch adds tracking of the completed copy segments at vhost side.
>> If async copy device reports partial completion of a packets, only
>> vhost internal record is updated and vring status keeps unchanged
>> until remaining segments of the packet are also finished. The async
>> copy device is no longer necessary to care about the packet boundary.
>>
>> Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
>>
>> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> 
> With above typo fixed (can be done when applying, no need to resend):
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 

Applied to dpdk-next-net/master, thanks.