diff for duplicates of <1e732391d4e94bbc87ab01ee80934fd3@intel.com> diff --git a/a/1.txt b/N1/1.txt index 8487984..6a754f0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Geert Uytterhoeven Sent: Thursday, April 16, 2020 2:51 AM To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S . Miller <davem@davemloft.net> -Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; linux-kernel at vger.kernel.org; Geert Uytterhoeven <geert@linux-m68k.org> +Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Geert Uytterhoeven <geert@linux-m68k.org> Subject: [Intel-wired-lan] [PATCH] virtchnl: Add missing explicit padding to structures On e.g. m68k, the alignment of 32-bit values is only 2 bytes, leading @@ -11,55 +11,55 @@ to: ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero] { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ - ./include/linux/avf/virtchnl.h:577:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:577:1: note: in expansion of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ VIRTCHNL_CHECK_STRUCT_LEN(272, virtchnl_filter); ^~~~~~~~~~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:577:32: error: enumerator value for ?virtchnl_static_assert_virtchnl_filter? is not an integer constant + ./include/linux/avf/virtchnl.h:577:32: error: enumerator value for ‘virtchnl_static_assert_virtchnl_filter’ is not an integer constant VIRTCHNL_CHECK_STRUCT_LEN(272, virtchnl_filter); ^~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero] { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ - ./include/linux/avf/virtchnl.h:619:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:619:1: note: in expansion of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_pf_event); ^~~~~~~~~~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:619:31: error: enumerator value for ?virtchnl_static_assert_virtchnl_pf_event? is not an integer constant + ./include/linux/avf/virtchnl.h:619:31: error: enumerator value for ‘virtchnl_static_assert_virtchnl_pf_event’ is not an integer constant VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_pf_event); ^~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero] { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ - ./include/linux/avf/virtchnl.h:640:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:640:1: note: in expansion of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_iwarp_qv_info); ^~~~~~~~~~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:640:31: error: enumerator value for ?virtchnl_static_assert_virtchnl_iwarp_qv_info? is not an integer constant + ./include/linux/avf/virtchnl.h:640:31: error: enumerator value for ‘virtchnl_static_assert_virtchnl_iwarp_qv_info’ is not an integer constant VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_iwarp_qv_info); ^~~~~~~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero] { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ - ./include/linux/avf/virtchnl.h:647:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:647:1: note: in expansion of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_iwarp_qvlist_info); ^~~~~~~~~~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:647:31: error: enumerator value for ?virtchnl_static_assert_virtchnl_iwarp_qvlist_info? is not an integer constant + ./include/linux/avf/virtchnl.h:647:31: error: enumerator value for ‘virtchnl_static_assert_virtchnl_iwarp_qvlist_info’ is not an integer constant VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_iwarp_qvlist_info); ^~~~~~~~~~~~~~~~~~~~~~~~~~ - ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN? + ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ‘VIRTCHNL_CHECK_STRUCT_LEN’ { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) } ^ Fix this by adding explicit padding to structures with holes. -Reported-by: noreply at ellerman.id.au +Reported-by: noreply@ellerman.id.au Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- Exposed by the "select PCI" in commit 4be5e8648b0c287a ("media: move CEC platform drivers to a separate directory"). diff --git a/a/content_digest b/N1/content_digest index 9b57551..53b5737 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,18 @@ "ref\020200416095049.12917-1-geert@linux-m68k.org\0" "From\0Bowers, AndrewX <andrewx.bowers@intel.com>\0" - "Subject\0[Intel-wired-lan] [PATCH] virtchnl: Add missing explicit padding to structures\0" + "Subject\0RE: [Intel-wired-lan] [PATCH] virtchnl: Add missing explicit padding to structures\0" "Date\0Wed, 22 Apr 2020 18:50:26 +0000\0" - "To\0intel-wired-lan@osuosl.org\0" + "To\0unlisted-recipients:; (no To-header on input)\0" + "Cc\0netdev@vger.kernel.org <netdev@vger.kernel.org>" + intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org> + " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "-----Original Message-----\n" "From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Geert Uytterhoeven\n" "Sent: Thursday, April 16, 2020 2:51 AM\n" "To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S . Miller <davem@davemloft.net>\n" - "Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; linux-kernel at vger.kernel.org; Geert Uytterhoeven <geert@linux-m68k.org>\n" + "Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Geert Uytterhoeven <geert@linux-m68k.org>\n" "Subject: [Intel-wired-lan] [PATCH] virtchnl: Add missing explicit padding to structures\n" "\n" "On e.g. m68k, the alignment of 32-bit values is only 2 bytes, leading\n" @@ -18,55 +21,55 @@ " ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero]\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t^\n" - " ./include/linux/avf/virtchnl.h:577:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:577:1: note: in expansion of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " VIRTCHNL_CHECK_STRUCT_LEN(272, virtchnl_filter);\n" " ^~~~~~~~~~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:577:32: error: enumerator value for ?virtchnl_static_assert_virtchnl_filter? is not an integer constant\n" + " ./include/linux/avf/virtchnl.h:577:32: error: enumerator value for \342\200\230virtchnl_static_assert_virtchnl_filter\342\200\231 is not an integer constant\n" " VIRTCHNL_CHECK_STRUCT_LEN(272, virtchnl_filter);\n" "\t\t\t\t ^~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t\t\t ^\n" " ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero]\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t^\n" - " ./include/linux/avf/virtchnl.h:619:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:619:1: note: in expansion of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_pf_event);\n" " ^~~~~~~~~~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:619:31: error: enumerator value for ?virtchnl_static_assert_virtchnl_pf_event? is not an integer constant\n" + " ./include/linux/avf/virtchnl.h:619:31: error: enumerator value for \342\200\230virtchnl_static_assert_virtchnl_pf_event\342\200\231 is not an integer constant\n" " VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_pf_event);\n" "\t\t\t\t ^~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t\t\t ^\n" " ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero]\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t^\n" - " ./include/linux/avf/virtchnl.h:640:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:640:1: note: in expansion of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_iwarp_qv_info);\n" " ^~~~~~~~~~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:640:31: error: enumerator value for ?virtchnl_static_assert_virtchnl_iwarp_qv_info? is not an integer constant\n" + " ./include/linux/avf/virtchnl.h:640:31: error: enumerator value for \342\200\230virtchnl_static_assert_virtchnl_iwarp_qv_info\342\200\231 is not an integer constant\n" " VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_iwarp_qv_info);\n" "\t\t\t\t ^~~~~~~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t\t\t ^\n" " ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero]\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t^\n" - " ./include/linux/avf/virtchnl.h:647:1: note: in expansion of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:647:1: note: in expansion of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_iwarp_qvlist_info);\n" " ^~~~~~~~~~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:647:31: error: enumerator value for ?virtchnl_static_assert_virtchnl_iwarp_qvlist_info? is not an integer constant\n" + " ./include/linux/avf/virtchnl.h:647:31: error: enumerator value for \342\200\230virtchnl_static_assert_virtchnl_iwarp_qvlist_info\342\200\231 is not an integer constant\n" " VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_iwarp_qvlist_info);\n" "\t\t\t\t ^~~~~~~~~~~~~~~~~~~~~~~~~~\n" - " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro ?VIRTCHNL_CHECK_STRUCT_LEN?\n" + " ./include/linux/avf/virtchnl.h:147:53: note: in definition of macro \342\200\230VIRTCHNL_CHECK_STRUCT_LEN\342\200\231\n" " { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }\n" "\t\t\t\t\t\t\t ^\n" "\n" "Fix this by adding explicit padding to structures with holes.\n" "\n" - "Reported-by: noreply at ellerman.id.au\n" + "Reported-by: noreply@ellerman.id.au\n" "Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>\n" "---\n" "Exposed by the \"select PCI\" in commit 4be5e8648b0c287a (\"media: move CEC platform drivers to a separate directory\").\n" @@ -76,4 +79,4 @@ "\n" Tested-by: Andrew Bowers <andrewx.bowers@intel.com> -a8e64328bf09b3a1fddbe367185762a1ec8a2a30b170da5d5bad0bc6aad7b581 +fda06fa657d4abaaefc7cbd1992e574bf0f3e0dab9ad2706bc0da657f938e78f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.