Re: [PATCH] ACPI: EC: Set ec_no_wakeup for Lenovo Go S

[Mario Limonciello <superm1@kernel.org>]

>> Here are tags for linking to your patch development to be picked up.
>>
>> Link:
>> https://github.com/bazzite-org/patchwork/commit/95b93b2852718ee1e808c72e6b1836da4a95fc63
>> Co-developed-by: Antheas Kapenekakis <lkml@antheas.dev>
>> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> 

I don't believe that b4 will pick these up, so I will send out a v2 with 
them and mark this patch as superceded in patchwork so that Rafael 
doesn't have to pull everything out of this thread manually.

> 
> And to avoid having this conversation again, there is another Legion
> Go S [3] patch you nacked and froze the testing for, so you could go
> on the manhunt for the real cause of this one. But it will probably be
> needed and you will find that as you get TDP controls going. So if you
> want me to prepare that in a timely manner, because that one actually
> needs rewriting to be posted, now is the time to say so.

Can you please propose what you have in mind on the mailing lists to 
discuss?  It's relatively expensive (in the unit of tech debt) to add 
quirk infrastructure and so we need to make sure it is the right solution.

Derek is working on CPU coefficient tuning in a completely separate 
driver.  If there are issues with that, I would generally prefer the 
fixes to be in that driver.

> 
> Antheas
> 
> [1] https://github.com/bazzite-org/kernel-bazzite/releases/tag/6.12.12-201
> [2] https://gitlab.com/evlaV/linux-integration/-/commit/6c5a3a96be9b061f07bf9a1bcc33156c932ddf67
> [3] https://gitlab.freedesktop.org/drm/amd/-/issues/3929#note_2764760
> 
>>> Not that I am content with it, which you might have noticed with my
>>> absence in the amd/drm issue tracker.
>>>
>>> So, was it the touchscreen after all? Did you verify this by tweaking
>>> its firmware?
>>
>> Yes it's the touchscreen causing this issue.  It was confirmed by a
>> hardware rework.
>>
>>>
>>> Antheas
>>>
>>> [1] https://github.com/bazzite-org/patchwork/commit/95b93b2852718ee1e808c72e6b1836da4a95fc63
>>>
>>>
>>>> Thanks,
>>>>
>>>>>>
>>>>>>> Cc: Xino JS1 Ni <nijs1@lenovo.com>
>>>>>>> Reported-by: Antheas Kapenekakis <lkml@antheas.dev>
>>>>>>> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3929
>>>>>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>>>>>> ---
>>>>>>>     drivers/acpi/ec.c | 28 ++++++++++++++++++++++++++++
>>>>>>>     1 file changed, 28 insertions(+)
>>>>>>>
>>>>>>> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
>>>>>>> index 8db09d81918fb..3c5f34892734e 100644
>>>>>>> --- a/drivers/acpi/ec.c
>>>>>>> +++ b/drivers/acpi/ec.c
>>>>>>> @@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = {
>>>>>>>                            DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"),
>>>>>>>                    },
>>>>>>>            },
>>>>>>> +       /*
>>>>>>> +        * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC
>>>>>>> +        * https://gitlab.freedesktop.org/drm/amd/-/issues/3929
>>>>>>> +        */
>>>>>>> +       {
>>>>>>> +               .matches = {
>>>>>>> +                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>>>>>>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "83L3"),
>>>>>>> +               }
>>>>>>> +       },
>>>>>>> +       {
>>>>>>> +               .matches = {
>>>>>>> +                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>>>>>>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "83N6"),
>>>>>>> +               }
>>>>>>> +       },
>>>>>>> +       {
>>>>>>> +               .matches = {
>>>>>>> +                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>>>>>>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"),
>>>>>>> +               }
>>>>>>> +       },
>>>>>>> +       {
>>>>>>> +               .matches = {
>>>>>>> +                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>>>>>>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"),
>>>>>>> +               }
>>>>>>> +       },
>>>>>>>            { },
>>>>>>>     };
>>>>>>>
>>>>>>> --
>>>>>>> 2.43.0
>>>>>>>
>>>>
>>