All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Antheas Kapenekakis <lkml@antheas.dev>
Cc: mario.limonciello@amd.com, rafael@kernel.org,
	Xino JS1 Ni <nijs1@lenovo.com>,
	linux-acpi@vger.kernel.org,
	"derekjohn.clark@gmail.com" <derekjohn.clark@gmail.com>
Subject: Re: [PATCH] ACPI: EC: Set ec_no_wakeup for Lenovo Go S
Date: Thu, 3 Apr 2025 14:56:54 -0500	[thread overview]
Message-ID: <e128ae3c-8d15-4a0d-ab1a-350e062c0a51@kernel.org> (raw)
In-Reply-To: <CAGwozwFbnSwVxO4y+_XtMVGcAC+TZByzerqx9j-vVCw+VWotZA@mail.gmail.com>

On 4/2/2025 3:37 PM, Antheas Kapenekakis wrote:

>> Maybe I'm failing at my search-engine-foo, could you point me at some
>> docs about this AC/DC burst stuff?
> 
> AC/DC Burst/AC/DC Burst Suppresed are the events in Sleep Study
> https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-sleepstudy
> 
> You can see those when running a sleep study and unplugging a
> connector. I think suppressed is unplugging
> 
> Then here is the description for plugging in a charger
> https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-wake-sources#environmental-context-changes-1
> 
>> The Windows power manager will turn on the display when the battery subsystem has indicated
>> AC power has been connected. The GPIO interrupt for power source changes must cause the
>> ACPI _PSR method under the power supply device to be executed. The power subsystem must
>> wake the SoC any time the power source changes, including when the system is attached or
>> removed from a dock that has a battery or AC power source. After AC power is connected,
>> the display will remain on for five seconds, unless there is input to the system during this five-second window.
> 
> And here for unplugging:
> https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-wake-sources#environmental-context-changes-2
> 
>> The GPIO interrupt for power source changes must cause the ACPI _PSR method under
>> the power supply device to be executed. The power subsystem must wake the SoC any time
>> the power source changes, including when the system is attached or removed from a dock
>> that has a battery or AC power source.

I suppose this could actually just be another way to say that there is a 
flurry of EC activity as a result of the ACPI SCI and they characterize 
that activity as a "burst" associated with unplug or plug.  It would be 
good to find actual documentation though instead of guessing.

> 
> I guess from the description it is not clear that the device stays on
> for 5 seconds when unplugging, but from empirical testing I want to
> say it does. It has been a while. I left 3 devices like an hour ago on
> Windows and none of them managed to sleep, so I cannot verify this at
> the moment though.
> 

During "display off" there is other activity that goes on until reaching 
resiliency on Microsoft side.  So it's not really cut and dry periods of 
time.

If I was to hypothesize when the screen off wakeup occurs the OS looks 
at the amount of time that has passed and if there was any scheduled 
tasks for the next wakeup gets them done before going back down.

  reply	other threads:[~2025-04-03 19:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 20:44 [PATCH] ACPI: EC: Set ec_no_wakeup for Lenovo Go S Mario Limonciello
2025-03-31 20:51 ` Antheas Kapenekakis
2025-03-31 20:53   ` Antheas Kapenekakis
2025-03-31 20:55     ` Mario Limonciello
2025-03-31 21:16       ` Antheas Kapenekakis
2025-04-01  2:40         ` Mario Limonciello
2025-04-01  9:01           ` Antheas Kapenekakis
2025-04-01 12:29             ` Mario Limonciello
2025-04-01 12:45               ` Antheas Kapenekakis
2025-04-01 14:09                 ` Mario Limonciello
2025-04-01 15:03                   ` Antheas Kapenekakis
2025-04-01 15:24                     ` Mario Limonciello
2025-04-01 18:39                       ` Antheas Kapenekakis
2025-04-01 20:54                         ` Mario Limonciello
2025-04-01 22:06                           ` Antheas Kapenekakis
2025-04-02 19:19                             ` Mario Limonciello
2025-04-02 20:37                               ` Antheas Kapenekakis
2025-04-03 19:56                                 ` Mario Limonciello [this message]
2025-04-01 14:16             ` Xino Ni
2025-04-01 14:46               ` Antheas Kapenekakis
2025-04-01 14:58                 ` Xino Ni
2025-04-01 15:05                   ` Antheas Kapenekakis
2025-04-01 12:47 ` Antheas Kapenekakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e128ae3c-8d15-4a0d-ab1a-350e062c0a51@kernel.org \
    --to=superm1@kernel.org \
    --cc=derekjohn.clark@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=mario.limonciello@amd.com \
    --cc=nijs1@lenovo.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.