All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Varshini.Rajendran@microchip.com>
To: <tudor.ambarus@linaro.org>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
	<claudiu.beznea@microchip.com>, <linux-crypto@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES
Date: Thu, 10 Aug 2023 05:38:12 +0000	[thread overview]
Message-ID: <1ec901d0-44c2-1d28-5976-d93abfffee67@microchip.com> (raw)
In-Reply-To: <09bd1388-02aa-32c7-319e-d7150a0f3e9c@linaro.org>

On 28/07/23 4:47 pm, Tudor Ambarus wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi,
> 
> On 7/28/23 11:24, Varshini Rajendran wrote:
>> Add DT bindings for atmel TDES.
> 
> NACK. The atmel crypto drivers check the version at runtime and
> fill a capabilities structure based on the version identified.
> There's a single compatible regardless of the version of the IP
> used until now, why do you want to change it?
> 
Hi Tudor,

I am aware that there is no change in the crypto IP used. This patch is 
to add a SoC specific compatible as expected by writing-bindings 
guideline. Maybe a bit more explanation in the commit description might 
do the trick.

> Please describe what motivated you to write this patch. Some people
> can't take seriously a patch if it misses a proper description and
> they just ignore it. Maybe it is worth re-reading:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> 
> Cheers,
> ta
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>>   .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml  | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> index 3d6ed24b1b00..6a441f79efea 100644
>> --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> @@ -12,7 +12,11 @@ maintainers:
>>
>>   properties:
>>     compatible:
>> -    const: atmel,at91sam9g46-tdes
>> +    oneOf:
>> +      - const: atmel,at91sam9g46-tdes
>> +      - items:
>> +          - const: microchip,sam9x7-tdes
>> +          - const: atmel,at91sam9g46-tdes
>>
>>     reg:
>>       maxItems: 1

-- 
Thanks and Regards,
Varshini Rajendran.


WARNING: multiple messages have this Message-ID (diff)
From: <Varshini.Rajendran@microchip.com>
To: <tudor.ambarus@linaro.org>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
	<claudiu.beznea@microchip.com>, <linux-crypto@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES
Date: Thu, 10 Aug 2023 05:38:12 +0000	[thread overview]
Message-ID: <1ec901d0-44c2-1d28-5976-d93abfffee67@microchip.com> (raw)
In-Reply-To: <09bd1388-02aa-32c7-319e-d7150a0f3e9c@linaro.org>

On 28/07/23 4:47 pm, Tudor Ambarus wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi,
> 
> On 7/28/23 11:24, Varshini Rajendran wrote:
>> Add DT bindings for atmel TDES.
> 
> NACK. The atmel crypto drivers check the version at runtime and
> fill a capabilities structure based on the version identified.
> There's a single compatible regardless of the version of the IP
> used until now, why do you want to change it?
> 
Hi Tudor,

I am aware that there is no change in the crypto IP used. This patch is 
to add a SoC specific compatible as expected by writing-bindings 
guideline. Maybe a bit more explanation in the commit description might 
do the trick.

> Please describe what motivated you to write this patch. Some people
> can't take seriously a patch if it misses a proper description and
> they just ignore it. Maybe it is worth re-reading:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> 
> Cheers,
> ta
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>>   .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml  | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> index 3d6ed24b1b00..6a441f79efea 100644
>> --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> @@ -12,7 +12,11 @@ maintainers:
>>
>>   properties:
>>     compatible:
>> -    const: atmel,at91sam9g46-tdes
>> +    oneOf:
>> +      - const: atmel,at91sam9g46-tdes
>> +      - items:
>> +          - const: microchip,sam9x7-tdes
>> +          - const: atmel,at91sam9g46-tdes
>>
>>     reg:
>>       maxItems: 1

-- 
Thanks and Regards,
Varshini Rajendran.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-10  5:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 10:24 [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES Varshini Rajendran
2023-07-28 10:24 ` Varshini Rajendran
2023-07-28 11:17 ` Tudor Ambarus
2023-07-28 11:17   ` Tudor Ambarus
2023-08-10  5:38   ` Varshini.Rajendran [this message]
2023-08-10  5:38     ` Varshini.Rajendran
2023-08-10  7:22     ` Tudor Ambarus
2023-08-10  7:22       ` Tudor Ambarus
2023-08-19 14:34       ` Krzysztof Kozlowski
2023-08-19 14:34         ` Krzysztof Kozlowski
2023-08-21  8:41         ` Nicolas Ferre
2023-08-21  8:41           ` Nicolas Ferre
2023-08-21  9:54           ` Tudor Ambarus
2023-08-21  9:54             ` Tudor Ambarus
2023-08-21 12:10             ` Krzysztof Kozlowski
2023-08-21 12:10               ` Krzysztof Kozlowski
2023-08-21 13:00               ` Tudor Ambarus
2023-08-21 13:00                 ` Tudor Ambarus
2023-08-21 13:12                 ` Krzysztof Kozlowski
2023-08-21 13:12                   ` Krzysztof Kozlowski
2023-08-21  8:59 ` Nicolas Ferre
2023-08-21  8:59   ` Nicolas Ferre
2023-08-21  9:59   ` Tudor Ambarus
2023-08-21  9:59     ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ec901d0-44c2-1d28-5976-d93abfffee67@microchip.com \
    --to=varshini.rajendran@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.