From: Rajendra Nayak <rnayak@ti.com>
To: Paul Walmsley <paul@pwsan.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, Kevin Hilman <khilman@ti.com>,
Benoit Cousson <b-cousson@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support for all DPLL's
Date: Tue, 8 Feb 2011 08:58:48 +0530 [thread overview]
Message-ID: <1eea151edf0ed021258c202c6d9b5bc2@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102071952300.21991@utopia.booyaka.com>
> -----Original Message-----
> From: Paul Walmsley [mailto:paul@pwsan.com]
> Sent: Tuesday, February 08, 2011 8:27 AM
> To: rnayak@ti.com; Santosh Shilimkar
> Cc: linux-omap@vger.kernel.org; khilman@ti.com; b-cousson@ti.com;
linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support
for all DPLL's
>
> Hi
>
> On Fri, 4 Feb 2011, Santosh Shilimkar wrote:
>
> > From: Rajendra Nayak <rnayak@ti.com>
> >
> > All OMAP3/4 dpll's support hardware level autogating.
> > Populate allow_idle/deny_idle function pointers for all
> > DPLL's in clkops.
> >
> > Also for OMAP4, call omap_clk_enable_autoidle() from PM
> > core (only with CONFIG_PM) to enable hardware level
> > autogating on all clock nodes which support it (For now
> > only DPLL nodes)
> >
> > Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> > ---
> > arch/arm/mach-omap2/clock.c | 8 +++++++-
> > arch/arm/mach-omap2/clock.h | 1 +
> > arch/arm/mach-omap2/clock3xxx_data.c | 2 +-
> > arch/arm/mach-omap2/clock44xx_data.c | 2 +-
> > arch/arm/mach-omap2/pm44xx.c | 4 ++++
>
> Looks like you add the allow_idle/deny_idle functions for the OMAP3 CORE
> DPLL, but you don't change mach-omap2/pm34xx.c. Any reason for this?
Nothing specifically. My initial patchset was enabling these only for
OMAP4,
So I thought will keep it that way.
> It
> seems that the current OMAP3 PM code doesn't enable CORE DPLL autoidle.
> Do you recall why? Perhaps it is due to some of the autoidle bugs,
where
> DPLL3 would enter auto-idle while some OMAP3 IP blocks that used CORE
> clocks were not idle...
I don't recall any such bug, however I will relook at the errata docs and
also
do some validation around this on OMAP3 and report.
Regards,
Rajendra
>
>
> - Paul
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support for all DPLL's
Date: Tue, 8 Feb 2011 08:58:48 +0530 [thread overview]
Message-ID: <1eea151edf0ed021258c202c6d9b5bc2@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102071952300.21991@utopia.booyaka.com>
> -----Original Message-----
> From: Paul Walmsley [mailto:paul at pwsan.com]
> Sent: Tuesday, February 08, 2011 8:27 AM
> To: rnayak at ti.com; Santosh Shilimkar
> Cc: linux-omap at vger.kernel.org; khilman at ti.com; b-cousson at ti.com;
linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support
for all DPLL's
>
> Hi
>
> On Fri, 4 Feb 2011, Santosh Shilimkar wrote:
>
> > From: Rajendra Nayak <rnayak@ti.com>
> >
> > All OMAP3/4 dpll's support hardware level autogating.
> > Populate allow_idle/deny_idle function pointers for all
> > DPLL's in clkops.
> >
> > Also for OMAP4, call omap_clk_enable_autoidle() from PM
> > core (only with CONFIG_PM) to enable hardware level
> > autogating on all clock nodes which support it (For now
> > only DPLL nodes)
> >
> > Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> > ---
> > arch/arm/mach-omap2/clock.c | 8 +++++++-
> > arch/arm/mach-omap2/clock.h | 1 +
> > arch/arm/mach-omap2/clock3xxx_data.c | 2 +-
> > arch/arm/mach-omap2/clock44xx_data.c | 2 +-
> > arch/arm/mach-omap2/pm44xx.c | 4 ++++
>
> Looks like you add the allow_idle/deny_idle functions for the OMAP3 CORE
> DPLL, but you don't change mach-omap2/pm34xx.c. Any reason for this?
Nothing specifically. My initial patchset was enabling these only for
OMAP4,
So I thought will keep it that way.
> It
> seems that the current OMAP3 PM code doesn't enable CORE DPLL autoidle.
> Do you recall why? Perhaps it is due to some of the autoidle bugs,
where
> DPLL3 would enter auto-idle while some OMAP3 IP blocks that used CORE
> clocks were not idle...
I don't recall any such bug, however I will relook at the errata docs and
also
do some validation around this on OMAP3 and report.
Regards,
Rajendra
>
>
> - Paul
next prev parent reply other threads:[~2011-02-08 3:28 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 9:58 [PATCH v2 0/9] omap4: prcm: Few dpll, clockdomain and powerdomain updates Santosh Shilimkar
2011-02-04 9:58 ` Santosh Shilimkar
2011-02-04 9:58 ` [PATCH v2 1/9] omap4: powerdomain: Add supported INACTIVE power state Santosh Shilimkar
2011-02-04 9:58 ` Santosh Shilimkar
2011-02-06 20:42 ` Paul Walmsley
2011-02-06 20:42 ` Paul Walmsley
2011-02-07 7:03 ` Santosh Shilimkar
2011-02-07 7:03 ` Santosh Shilimkar
2011-02-08 1:32 ` Paul Walmsley
2011-02-08 1:32 ` Paul Walmsley
2011-02-08 6:41 ` Santosh Shilimkar
2011-02-08 6:41 ` Santosh Shilimkar
2011-02-04 9:58 ` [PATCH v2 2/9] omap4: prcm: Fix the CPUx clockdomain offsets Santosh Shilimkar
2011-02-04 9:58 ` Santosh Shilimkar
2011-02-08 4:55 ` Paul Walmsley
2011-02-08 4:55 ` Paul Walmsley
2011-02-25 20:07 ` Paul Walmsley
2011-02-25 20:07 ` Paul Walmsley
2011-02-04 9:58 ` [PATCH v2 3/9] omap4: powerdomain: Use intended PWRSTS_* flags instead of values Santosh Shilimkar
2011-02-04 9:58 ` Santosh Shilimkar
2011-02-08 1:45 ` Paul Walmsley
2011-02-08 1:45 ` Paul Walmsley
2011-02-08 6:37 ` Santosh Shilimkar
2011-02-08 6:37 ` Santosh Shilimkar
2011-02-25 20:10 ` Paul Walmsley
2011-02-25 20:10 ` Paul Walmsley
2011-02-04 9:58 ` [PATCH v2 4/9] omap: clocks: Add checks to see if enable/disable ops are supported Santosh Shilimkar
2011-02-04 9:58 ` Santosh Shilimkar
2011-02-08 1:48 ` Paul Walmsley
2011-02-08 1:48 ` Paul Walmsley
2011-02-08 3:25 ` Rajendra Nayak
2011-02-08 3:25 ` Rajendra Nayak
2011-02-04 9:59 ` [PATCH v2 5/9] omap: clocks: Add allow_idle/deny_idle support in clkops Santosh Shilimkar
2011-02-04 9:59 ` Santosh Shilimkar
2011-02-04 9:59 ` [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support for all DPLL's Santosh Shilimkar
2011-02-04 9:59 ` Santosh Shilimkar
2011-02-08 2:57 ` Paul Walmsley
2011-02-08 2:57 ` Paul Walmsley
2011-02-08 3:28 ` Rajendra Nayak [this message]
2011-02-08 3:28 ` Rajendra Nayak
2011-02-08 3:40 ` Paul Walmsley
2011-02-08 3:40 ` Paul Walmsley
2011-02-08 4:17 ` Rajendra Nayak
2011-02-08 4:17 ` Rajendra Nayak
2011-02-08 4:16 ` Paul Walmsley
2011-02-08 4:16 ` Paul Walmsley
2011-02-04 9:59 ` [PATCH v2 7/9] omap4: dpll: Add dpll api to control GATE_CTRL Santosh Shilimkar
2011-02-04 9:59 ` Santosh Shilimkar
2011-02-04 9:59 ` [PATCH v2 8/9] omap4: dpll: Enable auto gate control for all MX postdividers Santosh Shilimkar
2011-02-04 9:59 ` Santosh Shilimkar
2011-02-04 9:59 ` [PATCH v2 9/9] omap4: clockdomain: Fix the CPUx domain name Santosh Shilimkar
2011-02-04 9:59 ` Santosh Shilimkar
2011-02-08 4:58 ` Paul Walmsley
2011-02-08 4:58 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eea151edf0ed021258c202c6d9b5bc2@mail.gmail.com \
--to=rnayak@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.