All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: wangzijie <wangzijie1@honor.com>, jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, feng.han@honor.com,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix infinite loop in __insert_extent_tree()
Date: Tue, 16 Sep 2025 20:12:27 +0800	[thread overview]
Message-ID: <1f80bc3f-845f-49f4-93d7-cc1be8a781f5@kernel.org> (raw)
In-Reply-To: <20250915035246.98055-2-wangzijie1@honor.com>

On 9/15/25 11:52, wangzijie wrote:
> When we get wrong extent info data, and look up extent_node in rb tree,
> it will cause infinite loop (CONFIG_F2FS_CHECK_FS=n). Avoiding this by
> return NULL.
> 
> Signed-off-by: wangzijie <wangzijie1@honor.com>
> ---
>  fs/f2fs/extent_cache.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index 199c1e7a8..6ed6f3d1d 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -605,6 +605,7 @@ static struct extent_node *__insert_extent_tree(struct f2fs_sb_info *sbi,
>  			leftmost = false;
>  		} else {

Need to print some messages here as Jaegeuk suggested, IIUC.

Thanks,

>  			f2fs_bug_on(sbi, 1);
> +			return NULL;
>  		}
>  	}
>  



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: wangzijie <wangzijie1@honor.com>, jaegeuk@kernel.org
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, bintian.wang@honor.com,
	feng.han@honor.com
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix infinite loop in __insert_extent_tree()
Date: Tue, 16 Sep 2025 20:12:27 +0800	[thread overview]
Message-ID: <1f80bc3f-845f-49f4-93d7-cc1be8a781f5@kernel.org> (raw)
In-Reply-To: <20250915035246.98055-2-wangzijie1@honor.com>

On 9/15/25 11:52, wangzijie wrote:
> When we get wrong extent info data, and look up extent_node in rb tree,
> it will cause infinite loop (CONFIG_F2FS_CHECK_FS=n). Avoiding this by
> return NULL.
> 
> Signed-off-by: wangzijie <wangzijie1@honor.com>
> ---
>  fs/f2fs/extent_cache.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index 199c1e7a8..6ed6f3d1d 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -605,6 +605,7 @@ static struct extent_node *__insert_extent_tree(struct f2fs_sb_info *sbi,
>  			leftmost = false;
>  		} else {

Need to print some messages here as Jaegeuk suggested, IIUC.

Thanks,

>  			f2fs_bug_on(sbi, 1);
> +			return NULL;
>  		}
>  	}
>  


  parent reply	other threads:[~2025-09-16 12:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15  3:52 [f2fs-dev] [PATCH v2 1/2] f2fs: fix zero-sized extent for precache extents wangzijie
2025-09-15  3:52 ` wangzijie
2025-09-15  3:52 ` [f2fs-dev] [PATCH v2 2/2] f2fs: fix infinite loop in __insert_extent_tree() wangzijie
2025-09-15  3:52   ` wangzijie
2025-09-15  8:05   ` Chao Yu via Linux-f2fs-devel
2025-09-15  8:05     ` Chao Yu
2025-09-16  2:21   ` Jaegeuk Kim via Linux-f2fs-devel
2025-09-16  2:21     ` Jaegeuk Kim
2025-09-16  5:22     ` wangzijie
2025-09-16  5:22       ` wangzijie
2025-09-16  6:46       ` Chao Yu via Linux-f2fs-devel
2025-09-16  6:46         ` Chao Yu
2025-09-16  7:09         ` wangzijie
2025-09-16  7:09           ` wangzijie
2025-09-16  7:28           ` Chao Yu via Linux-f2fs-devel
2025-09-16  7:28             ` Chao Yu
2025-09-16  8:26             ` wangzijie
2025-09-16  8:26               ` wangzijie
2025-09-16  8:49               ` Chao Yu via Linux-f2fs-devel
2025-09-16  8:49                 ` Chao Yu
2025-09-16  9:02                 ` wangzijie
2025-09-16  9:02                   ` wangzijie
2025-09-16 12:12   ` Chao Yu via Linux-f2fs-devel [this message]
2025-09-16 12:12     ` Chao Yu
2025-09-16 12:36     ` wangzijie
2025-09-16 12:36       ` wangzijie
2025-09-15  8:05 ` [f2fs-dev] [PATCH v2 1/2] f2fs: fix zero-sized extent for precache extents Chao Yu via Linux-f2fs-devel
2025-09-15  8:05   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f80bc3f-845f-49f4-93d7-cc1be8a781f5@kernel.org \
    --to=linux-f2fs-devel@lists.sourceforge.net \
    --cc=chao@kernel.org \
    --cc=feng.han@honor.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzijie1@honor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.