All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"Li, Xiaoyao" <xiaoyao.li@intel.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	"kas@kernel.org" <kas@kernel.org>,
	"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
	"Xu, Yilun" <yilun.xu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"seanjc@google.com" <seanjc@google.com>,
	"Mehta, Sohil" <sohil.mehta@intel.com>,
	"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
	"Gao, Chao" <chao.gao@intel.com>,
	"djbw@kernel.org" <djbw@kernel.org>,
	"Maloor, Kishen" <kishen.maloor@intel.com>,
	"Fang, Peter" <peter.fang@intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 06/17] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update
Date: Thu, 30 Jul 2026 18:41:55 +0000	[thread overview]
Message-ID: <1f99ce03929f3272319d0f81aecaa93e86022aae.camel@intel.com> (raw)
In-Reply-To: <amt1QNCBQas95XYB@yilunxu-OptiPlex-7050>

On Fri, 2026-07-31 at 00:01 +0800, Xu Yilun wrote:
> > I've found issue in my implementation. If extensions are required at
> > boot up time but somehow not required after update, the code just skip
> > tdx_ext_init() and the update succeed, but after that the extension
> > features will break.
> > 
> > IOW, we should not update the metadata, we should follow the boot up
> > time metadata to ensure no feature changes.
> 
> Sorry, I changed my mind. I remember TDX module architector said "the
> host should not assume any feature/SEAMCALL must be associated with any
> extension, it is hidden from the host. Today a SEAMCALL is backed by an
> extension, tomorrow it may not".
> 
> So in this case, ext_required may flip across updates and we should
> honor the runtime metadata.

Then this is an incompatible update, no? Linux doesn't support incompatible
updates. We can keep it simpler.

> 
> I made another effort to combine common routines for ext init and
> update, but don't like how it turns out. If no one wants it that much,
> I'd rather stay unchanged:


  reply	other threads:[~2026-07-30 18:42 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18  8:13 [PATCH v2 00/17] Enable DICE-based TDX Quoting Extension Xu Yilun
2026-06-18  8:13 ` [PATCH v2 01/17] x86/virt/tdx: Embed version info in SEAMCALL leaf function definitions Xu Yilun
2026-06-18 14:45   ` Dave Hansen
2026-06-22 12:05     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 02/17] x86/virt/tdx: Configure add-on features on TDX module init and update Xu Yilun
2026-06-18 15:04   ` Dave Hansen
2026-06-22 13:15     ` Xu Yilun
2026-06-24 12:00     ` Xu Yilun
2026-06-24 22:10       ` Peter Fang
2026-06-25  6:33         ` Xu Yilun
2026-06-23  8:43   ` Chao Gao
2026-06-25 10:50     ` Xu Yilun
2026-07-24  8:15   ` Xiaoyao Li
2026-07-27 10:48     ` Xu Yilun
2026-07-27 17:50   ` Edgecombe, Rick P
2026-07-28 16:29     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 03/17] x86/virt/tdx: Detect if the extensions initialization is required Xu Yilun
2026-06-25  5:19   ` Tony Lindgren
2026-06-25 10:57     ` Xu Yilun
2026-07-27 17:51     ` Edgecombe, Rick P
2026-06-29  6:33   ` Chao Gao
2026-06-30 11:10     ` Xu Yilun
2026-07-24  8:44       ` Xiaoyao Li
2026-07-27 12:43         ` Xu Yilun
2026-07-24  8:42   ` Xiaoyao Li
2026-07-27 12:38     ` Xu Yilun
2026-07-27 17:56       ` Edgecombe, Rick P
2026-07-29  3:50         ` Xu Yilun
2026-07-29 13:48           ` Edgecombe, Rick P
2026-07-29 17:08             ` Xu Yilun
2026-07-29 22:55               ` Edgecombe, Rick P
2026-06-18  8:13 ` [PATCH v2 04/17] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-06-18  8:54   ` sashiko-bot
2026-06-24  1:53     ` Xu Yilun
2026-06-29  7:56   ` Chao Gao
2026-06-30 10:27     ` Xu Yilun
2026-07-27 18:16   ` Edgecombe, Rick P
2026-07-29 11:07     ` Xu Yilun
2026-06-18  8:13 ` [PATCH v2 05/17] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-06-18  8:54   ` sashiko-bot
2026-06-23 17:03     ` Xu Yilun
2026-07-27  8:23       ` Xiaoyao Li
2026-07-27 18:30   ` Edgecombe, Rick P
2026-06-18  8:13 ` [PATCH v2 06/17] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
2026-06-18  8:58   ` sashiko-bot
2026-06-25  7:01     ` Xu Yilun
2026-06-29  8:12   ` Chao Gao
2026-06-30 11:14     ` Xu Yilun
2026-07-27 18:37     ` Edgecombe, Rick P
2026-07-30 11:10       ` Xu Yilun
2026-07-30 16:01         ` Xu Yilun
2026-07-30 18:41           ` Edgecombe, Rick P [this message]
2026-07-31  2:30             ` Xu Yilun
2026-07-27 18:36   ` Edgecombe, Rick P
2026-06-18  8:13 ` [PATCH v2 07/17] x86/virt/tdx: Initialize Quoting extension Xu Yilun
2026-06-18  8:50   ` sashiko-bot
2026-06-25 10:24     ` Peter Fang
2026-06-29  8:33   ` Chao Gao
2026-06-30  5:20     ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 08/17] x86/virt/tdx: Prepare Quote buffer during extension bringup Xu Yilun
2026-06-25  6:08   ` Tony Lindgren
2026-06-30  4:12     ` Peter Fang
2026-07-01 19:56   ` Dave Hansen
2026-07-08  9:25     ` Peter Fang
2026-07-08  7:52   ` Nikolay Borisov
2026-07-13 10:19     ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 09/17] x86/virt/tdx: Add interface to check Quoting availability Xu Yilun
2026-06-25  6:09   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 10/17] x86/virt/tdx: Move tdx_tdr_pa() up in the file Xu Yilun
2026-06-25  6:10   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 11/17] x86/virt/tdx: Add interface to generate a Quote Xu Yilun
2026-06-18  8:49   ` sashiko-bot
2026-06-30 15:28     ` Peter Fang
2026-06-25  6:05   ` Tony Lindgren
2026-06-30  4:22     ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 12/17] x86/virt/tdx: Reinitialize the Quoting extension after TDX module update Xu Yilun
2026-06-25  6:12   ` Tony Lindgren
2026-07-27 18:33   ` Edgecombe, Rick P
2026-08-11  4:29     ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 13/17] x86/virt/tdx: Enable Quoting extension Xu Yilun
2026-06-25  6:13   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 14/17] x86/tdx: Move and rename Quote request structure Xu Yilun
2026-06-25  6:15   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 15/17] KVM: TDX: Factor out userspace return path from tdx_get_quote() Xu Yilun
2026-06-25  6:16   ` Tony Lindgren
2026-06-18  8:13 ` [PATCH v2 16/17] KVM: TDX: Add in-kernel Quote generation Xu Yilun
2026-06-18  9:03   ` sashiko-bot
2026-06-30 15:52     ` Peter Fang
2026-06-25 18:01   ` Sean Christopherson
2026-06-29 10:03     ` Peter Fang
2026-06-30  0:42       ` Sean Christopherson
2026-06-30 23:33         ` Edgecombe, Rick P
2026-07-01  0:24           ` Dan Williams (nvidia)
2026-07-01 17:25             ` Sean Christopherson
2026-07-01 18:45               ` Edgecombe, Rick P
2026-07-04  5:43                 ` Peter Fang
2026-07-06 17:57                   ` Sean Christopherson
2026-07-08 20:47                     ` Dave Hansen
2026-07-08 21:16                       ` Sean Christopherson
2026-07-08 22:09                       ` Peter Fang
2026-07-08 22:28                         ` Sean Christopherson
2026-07-08 23:38                           ` Edgecombe, Rick P
2026-07-10  9:01                   ` Nikolay Borisov
2026-07-10  9:38                     ` Peter Fang
2026-07-08 21:37   ` Sean Christopherson
2026-07-10 12:52     ` Peter Fang
2026-07-10 14:48       ` Sean Christopherson
2026-07-10 22:59         ` Peter Fang
2026-06-18  8:13 ` [PATCH v2 17/17] KVM: TDX: Support event-notify interrupts only with userspace Quoting Xu Yilun
2026-06-25  6:28   ` Tony Lindgren
2026-06-30  6:36     ` Peter Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f99ce03929f3272319d0f81aecaa93e86022aae.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chao.gao@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=djbw@kernel.org \
    --cc=kas@kernel.org \
    --cc=kishen.maloor@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.fang@intel.com \
    --cc=seanjc@google.com \
    --cc=sohil.mehta@intel.com \
    --cc=tony.lindgren@linux.intel.com \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    --cc=yilun.xu@intel.com \
    --cc=yilun.xu@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.