From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-integrity@vger.kernel.org, ltp@lists.linux.it,
linuxtestproject.agent@gmail.com
Subject: Re: [LTP] ima_setup.sh: Fix check_policy_writable() for kernel < 4.5
Date: Fri, 07 Aug 2026 14:49:09 -0400 [thread overview]
Message-ID: <1ffedf290548a2fbfb1670ad53ec5d57e0f27178.camel@linux.ibm.com> (raw)
In-Reply-To: <20260803131942.GB246496@pevik>
Hi Petr,
On Mon, 2026-08-03 at 15:19 +0200, Petr Vorel wrote:
[...]
> Do you agree that test2 in ima_policy.sh should be skipped on kernel < 4.5? If
> you consider useful running the test also on these old kernels I could just
> correct the commit message for older kernel or simply ignore that fact (just add
> a comment to the test that it's irrelevant for < 4.5. (I know 4.4 is not
> supported any more, in fact it's just for SLES and possibly other LTS distros
> still supporting this old kernel, but I still appreciate your opinion.
Test 2 says, ""verify that policy file is not opened concurrently and able to
loaded multiple times". Prior to 4.5, a policy cannot be loaded multiple times.
I agree ima_policy.sh: test2 should be skipped on kernels prior to 4.5.
>
>
> > > > Should test2 report TCONF (or split the two assertions) when
> > > > CONFIG_IMA_WRITE_POLICY is not available?
>
> FYI we could sooner or later start using kernel config (e.g. look into
> CONFIG_IMA_WRITE_POLICY and CONFIG_IMA_READ_POLICY as many LTP tests and now
> even LTP library require kernel config (we resisted long time add kernel config
> as a hard dependency, but finally Cyril added support in 2018).
Nice!
>
> But more important for me would be to migrate LTP IMA tests to shell loader [1]
> or even rewrite to C API. We have deprecated tst_test.sh API some time ago.
Oh! Sure, sounds good.
thanks,
Mimi
--
Mailing list info: https://lists.linux.it/listinfo/ltp
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: linuxtestproject.agent@gmail.com, ltp@lists.linux.it,
linux-integrity@vger.kernel.org
Subject: Re: ima_setup.sh: Fix check_policy_writable() for kernel < 4.5
Date: Fri, 07 Aug 2026 14:49:09 -0400 [thread overview]
Message-ID: <1ffedf290548a2fbfb1670ad53ec5d57e0f27178.camel@linux.ibm.com> (raw)
In-Reply-To: <20260803131942.GB246496@pevik>
Hi Petr,
On Mon, 2026-08-03 at 15:19 +0200, Petr Vorel wrote:
[...]
> Do you agree that test2 in ima_policy.sh should be skipped on kernel < 4.5? If
> you consider useful running the test also on these old kernels I could just
> correct the commit message for older kernel or simply ignore that fact (just add
> a comment to the test that it's irrelevant for < 4.5. (I know 4.4 is not
> supported any more, in fact it's just for SLES and possibly other LTS distros
> still supporting this old kernel, but I still appreciate your opinion.
Test 2 says, ""verify that policy file is not opened concurrently and able to
loaded multiple times". Prior to 4.5, a policy cannot be loaded multiple times.
I agree ima_policy.sh: test2 should be skipped on kernels prior to 4.5.
>
>
> > > > Should test2 report TCONF (or split the two assertions) when
> > > > CONFIG_IMA_WRITE_POLICY is not available?
>
> FYI we could sooner or later start using kernel config (e.g. look into
> CONFIG_IMA_WRITE_POLICY and CONFIG_IMA_READ_POLICY as many LTP tests and now
> even LTP library require kernel config (we resisted long time add kernel config
> as a hard dependency, but finally Cyril added support in 2018).
Nice!
>
> But more important for me would be to migrate LTP IMA tests to shell loader [1]
> or even rewrite to C API. We have deprecated tst_test.sh API some time ago.
Oh! Sure, sounds good.
thanks,
Mimi
next prev parent reply other threads:[~2026-08-07 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:42 [PATCH 1/1] ima_setup.sh: Fix check_policy_writable() for kernel < 4.5 Petr Vorel
2026-07-28 11:42 ` [LTP] " Petr Vorel
2026-07-28 12:58 ` [LTP] " linuxtestproject.agent
2026-07-28 13:35 ` Petr Vorel
2026-07-28 13:35 ` [LTP] " Petr Vorel
2026-07-29 6:54 ` Andrea Cervesato
2026-07-29 6:54 ` Andrea Cervesato via ltp
2026-07-29 17:55 ` Mimi Zohar
2026-07-29 17:55 ` Mimi Zohar
2026-08-03 13:19 ` [LTP] " Petr Vorel
2026-08-03 13:19 ` Petr Vorel
2026-08-07 18:49 ` Mimi Zohar [this message]
2026-08-07 18:49 ` Mimi Zohar
-- strict thread matches above, loose matches on Subject: below --
2026-08-10 14:33 [PATCH v2 1/2] " Petr Vorel
2026-08-10 14:59 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ffedf290548a2fbfb1670ad53ec5d57e0f27178.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.