From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Mark Brown <broonie@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/26] clk: amlogic: clock controllers clean-up and factorisation
Date: Sun, 21 Sep 2025 14:59:30 +0200 [thread overview]
Message-ID: <1jldm855cd.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <CAFBinCBe3LhN+3beovFVuWPpe3pDF5P1wSt7nPjm=ykRAx4zzQ@mail.gmail.com> (Martin Blumenstingl's message of "Sun, 21 Sep 2025 14:21:28 +0200")
On Sun 21 Sep 2025 at 14:21, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Mark,
>
> On Sun, Sep 21, 2025 at 1:25 PM Mark Brown <broonie@kernel.org> wrote:
>>
>> On Wed, Jul 02, 2025 at 05:25:58PM +0200, Jerome Brunet wrote:
>> > The work on this patchset started with the submission of the Amlogic t7
>> > peripheral clock controller [1]. This controller is fairly similar to
>> > existing controllers. Once again, it redefines the peripheral clock macro,
>> > the probe function and composite clock helpers, even if it is almost the
>> > same as in other controllers. This code duplication trend has been going on
>> > for too long and now is the time to properly address the problem.
>>
>> Friday's -next breaks the boot for me on the Libretch Alta. The system
>> doesn't show any output on the console unfortunately:
>>
>> https://lava.sirena.org.uk/scheduler/job/1853204#L1606
>>
>> Unfortunately earlycon isn't turned on, I'll try to do so at tomorrow or
>> Tuesday.
>>
>> A bisect points to the patch 4c4e17f27013 ("clk: amlogic: naming
>> consistency alignment") which looks like it's a squash of several of the
>> patches here. Due to issues with the bootloader it could potentially be
>> an adjacent commit but this looks suspiciously relevant. Bisect log, my
>> infrastructure does retry the boot a lot on these boards so even if the
>> final error is a bootloader issue there will likely have been boots that
>> start the kernel:
> A few days ago Marek reported problems on an Odroid-N2 and provided a fix: [0]
> It's not queued up for -next yet.
>
> Please give Marek's patch a try
>
>
> [0]
> https://lore.kernel.org/linux-amlogic/175834437006.4354.11933545174004616373@lazor/T/#m29128b0acec2db62d45971d94a1c38fedc8493a0
Hey Mark,
Being on the A311D as well, it is likely to be the same issue.
I suspect you would not see the crash it without earlycon indeed.
The fix is in clk-next already so linux-next should get it soon.
Sorry for the inconvenience and thanks for the report.
--
Jerome
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Mark Brown <broonie@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/26] clk: amlogic: clock controllers clean-up and factorisation
Date: Sun, 21 Sep 2025 14:59:30 +0200 [thread overview]
Message-ID: <1jldm855cd.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <CAFBinCBe3LhN+3beovFVuWPpe3pDF5P1wSt7nPjm=ykRAx4zzQ@mail.gmail.com> (Martin Blumenstingl's message of "Sun, 21 Sep 2025 14:21:28 +0200")
On Sun 21 Sep 2025 at 14:21, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hi Mark,
>
> On Sun, Sep 21, 2025 at 1:25 PM Mark Brown <broonie@kernel.org> wrote:
>>
>> On Wed, Jul 02, 2025 at 05:25:58PM +0200, Jerome Brunet wrote:
>> > The work on this patchset started with the submission of the Amlogic t7
>> > peripheral clock controller [1]. This controller is fairly similar to
>> > existing controllers. Once again, it redefines the peripheral clock macro,
>> > the probe function and composite clock helpers, even if it is almost the
>> > same as in other controllers. This code duplication trend has been going on
>> > for too long and now is the time to properly address the problem.
>>
>> Friday's -next breaks the boot for me on the Libretch Alta. The system
>> doesn't show any output on the console unfortunately:
>>
>> https://lava.sirena.org.uk/scheduler/job/1853204#L1606
>>
>> Unfortunately earlycon isn't turned on, I'll try to do so at tomorrow or
>> Tuesday.
>>
>> A bisect points to the patch 4c4e17f27013 ("clk: amlogic: naming
>> consistency alignment") which looks like it's a squash of several of the
>> patches here. Due to issues with the bootloader it could potentially be
>> an adjacent commit but this looks suspiciously relevant. Bisect log, my
>> infrastructure does retry the boot a lot on these boards so even if the
>> final error is a bootloader issue there will likely have been boots that
>> start the kernel:
> A few days ago Marek reported problems on an Odroid-N2 and provided a fix: [0]
> It's not queued up for -next yet.
>
> Please give Marek's patch a try
>
>
> [0]
> https://lore.kernel.org/linux-amlogic/175834437006.4354.11933545174004616373@lazor/T/#m29128b0acec2db62d45971d94a1c38fedc8493a0
Hey Mark,
Being on the A311D as well, it is likely to be the same issue.
I suspect you would not see the crash it without earlycon indeed.
The fix is in clk-next already so linux-next should get it soon.
Sorry for the inconvenience and thanks for the report.
--
Jerome
next prev parent reply other threads:[~2025-09-21 12:59 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 15:25 [PATCH 00/26] clk: amlogic: clock controllers clean-up and factorisation Jerome Brunet
2025-07-02 15:25 ` Jerome Brunet
2025-07-02 15:25 ` [PATCH 01/26] clk: amlogic: a1-peripherals: naming consistency alignment Jerome Brunet
2025-07-02 15:25 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 02/26] clk: amlogic: a1-pll: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 03/26] clk: amlogic: axg-ao: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 04/26] clk: amlogic: axg: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 05/26] clk: amlogic: c3-peripherals: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 2:51 ` Chuan Liu
2025-07-03 2:51 ` Chuan Liu
2025-07-03 7:48 ` Jerome Brunet
2025-07-03 7:48 ` Jerome Brunet
2025-07-03 8:31 ` Chuan Liu
2025-07-03 8:31 ` Chuan Liu
2025-07-03 9:02 ` Jerome Brunet
2025-07-03 9:02 ` Jerome Brunet
2025-07-03 9:23 ` Chuan Liu
2025-07-03 9:23 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 06/26] clk: amlogic: c3-pll: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 2:57 ` Chuan Liu
2025-07-03 2:57 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 07/26] clk: amlogic: g12a-ao: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 08/26] clk: amlogic: g12a: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 09/26] clk: amlogic: gxbb-ao: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 10/26] clk: amlogic: gxbb: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 11/26] clk: amlogic: meson8b: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 12/26] clk: amlogic: s4-peripherals: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 3:18 ` Chuan Liu
2025-07-03 3:18 ` Chuan Liu
2025-07-03 7:54 ` Jerome Brunet
2025-07-03 7:54 ` Jerome Brunet
2025-07-03 8:00 ` Chuan Liu
2025-07-03 8:00 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 13/26] clk: amlogic: s4-pll: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 3:19 ` Chuan Liu
2025-07-03 3:19 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 14/26] clk: amlogic: meson8-ddr: " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 15/26] clk: amlogic: drop meson-clkcee Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 16/26] clk: amlogic: add probe helper for mmio based controllers Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 3:29 ` Chuan Liu
2025-07-03 3:29 ` Chuan Liu
2025-07-03 8:35 ` Jerome Brunet
2025-07-03 8:35 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 17/26] clk: amlogic: use probe helper in " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 6:29 ` Chuan Liu
2025-07-03 6:29 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 18/26] clk: amlogic: aoclk: use clkc-utils syscon probe Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 19/26] clk: amlogic: move PCLK definition to clkc-utils Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 20/26] clk: amlogic: drop CLK_SET_RATE_PARENT from peripheral clocks Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 21/26] clk: amlogic: pclk explicitly use CLK_IGNORE_UNUSED Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 7:05 ` Chuan Liu
2025-07-03 7:05 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 22/26] clk: amlogic: introduce a common pclk definition Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 7:10 ` Chuan Liu
2025-07-03 7:10 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 23/26] clk: amlogic: use the " Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 7:16 ` Chuan Liu
2025-07-03 7:16 ` Chuan Liu
2025-07-03 8:39 ` Jerome Brunet
2025-07-03 8:39 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 24/26] clk: amlogic: add composite clock helpers Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 7:24 ` Chuan Liu
2025-07-03 7:24 ` Chuan Liu
2025-07-03 8:39 ` Jerome Brunet
2025-07-03 8:39 ` Jerome Brunet
2025-07-02 15:26 ` [PATCH 25/26] clk: amlogic: align s4 and c3 pwm clock descriptions Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 7:27 ` Chuan Liu
2025-07-03 7:27 ` Chuan Liu
2025-07-02 15:26 ` [PATCH 26/26] clk: amlogic: c3-peripherals: use helper for basic composite clocks Jerome Brunet
2025-07-02 15:26 ` Jerome Brunet
2025-07-03 7:56 ` Chuan Liu
2025-07-03 7:56 ` Chuan Liu
2025-07-03 8:44 ` Jerome Brunet
2025-07-03 8:44 ` Jerome Brunet
2025-08-06 7:10 ` [PATCH 00/26] clk: amlogic: clock controllers clean-up and factorisation Chuan Liu
2025-08-06 7:10 ` Chuan Liu
2025-08-25 14:24 ` Jerome Brunet
2025-08-25 14:24 ` Jerome Brunet
2025-09-21 11:25 ` Mark Brown
2025-09-21 11:25 ` Mark Brown
2025-09-21 12:21 ` Martin Blumenstingl
2025-09-21 12:21 ` Martin Blumenstingl
2025-09-21 12:59 ` Jerome Brunet [this message]
2025-09-21 12:59 ` Jerome Brunet
2025-09-22 9:40 ` Mark Brown
2025-09-22 9:40 ` Mark Brown
2025-09-22 11:02 ` Martin Blumenstingl
2025-09-22 11:02 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jldm855cd.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=broonie@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.