Re: [PATCH v7 3/5] dt-bindings: mfd: x-powers,axp152: Document AXP318W

[Jerome Brunet <jbrunet@baylibre.com>]

On jeu. 10 sept. 2026 at 09:42, sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The new `x-powers,axp318w` compatible string is omitted from the conditional block that makes the `interrupts` property optional for recent generation PMICs.
> --
>
> commit e4119d6ce87c67baf660bd6f040790fb69b77af3
> Author: Andre Przywara <andre.przywara@arm.com>
>
> dt-bindings: mfd: x-powers,axp152: Document AXP318W
>
> This commit adds the compatible string x-powers,axp318w for the AXP318W PMIC
> to the binding schema. It also adds new input supply properties and updates
> the regex for matching switched output nodes.
>
>> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> index 45f015d63df16..38556c32417b3 100644
>> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> @@ -83,6 +83,7 @@ allOf:
>>            contains:
>>              enum:
>>                - x-powers,axp313a
>> +              - x-powers,axp318w
>>                - x-powers,axp323
>>                - x-powers,axp15060
>>                - x-powers,axp717
>
> [Severity: Medium]
> Does the x-powers,axp318w compatible string also need to be added to the
> earlier if-then block that governs the interrupts requirement?

Ahhh, got it the other way around first time this poped - resending ...

>
> Just above this hunk in Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml,
> there is a block that makes interrupts mandatory for all PMICs except a select
> few:
>
>   - if:
>       not:
>         properties:
>           compatible:
>             contains:
>               enum:
>                 - x-powers,axp15060
>                 - x-powers,axp305
>                 - x-powers,axp313a
>                 - x-powers,axp323
>
>     then:
>       required:
>         - interrupts
>
> By omitting x-powers,axp318w from this enum, the interrupts property is
> mandatory for the new PMIC. Could this cause device trees with an unconnected
> AXP318W interrupt line to falsely fail dt_binding_check validation, given that
> similar recent generation PMICs operate fine without it?
>
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260910-axp318-regulator-v7-0-de720ceb9bac@baylibre.com?part=3

-- 
Jerome