From: sashiko-bot@kernel.org
To: "Jerome Brunet" <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, lee@kernel.org,
robh@kernel.org, linux-sunxi@lists.linux.dev,
conor+dt@kernel.org
Subject: Re: [PATCH v7 4/5] mfd: axp20x: Add support for AXP318W PMIC
Date: Thu, 10 Sep 2026 09:40:29 +0000 [thread overview]
Message-ID: <20260910094030.2C8791F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910-axp318-regulator-v7-4-de720ceb9bac@baylibre.com>
> From: Andre Przywara <andre.przywara@arm.com>
>
> The AXP318W is a PMIC chip produced by X-Powers, it can be connected to
> an I2C bus.
>
> It has a large number of regulators: 9(!) DCDC buck converters, and 28
> LDOs, also some ADCs, interrupts, and a power key.
>
> Describe the regmap and the MFD bits, along with the registers exposed
> via I2C only. This covers the regulators and interrupts for now.
> Advertise the device using the new compatible string.
>
> We use just "318" for the internal identifiers, for easier typing and
> less churn, but use "318W" for anything externally visible. If something
> else other than the "AXP318W" shows up, that's an easy change then.
>
> Reviewed-by: Chen-Yu Tsai <wens@kernel.org>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Co-developed-by: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-axp318-regulator-v7-0-de720ceb9bac@baylibre.com?part=4
next prev parent reply other threads:[~2026-09-10 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 9:31 [PATCH v7 0/5] regulator: Add X-Powers AXP318W PMIC support Jerome Brunet
2026-09-10 9:31 ` [PATCH v7 1/5] mfd: axp20x: Constify axp313 and axp717 cells Jerome Brunet
2026-09-10 9:34 ` sashiko-bot
2026-09-10 9:31 ` [PATCH v7 2/5] mfd: axp20x-i2c: Fix i2c instantiation Jerome Brunet
2026-09-10 9:40 ` sashiko-bot
2026-09-10 9:31 ` [PATCH v7 3/5] dt-bindings: mfd: x-powers,axp152: Document AXP318W Jerome Brunet
2026-09-10 9:42 ` sashiko-bot
2026-09-10 10:37 ` Jerome Brunet
2026-09-10 9:31 ` [PATCH v7 4/5] mfd: axp20x: Add support for AXP318W PMIC Jerome Brunet
2026-09-10 9:40 ` sashiko-bot [this message]
2026-09-10 9:31 ` [PATCH v7 5/5] regulator: axp20x: add support for the AXP318W Jerome Brunet
2026-09-10 9:39 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910094030.2C8791F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=lee@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.