* Re: -ac13 buffer.c MAJOR bug
[not found] ` <3943BFA0.445B747C@sls.lcs.mit.edu>
@ 2000-06-11 19:23 ` Stephen C. Tweedie
0 siblings, 0 replies; only message in thread
From: Stephen C. Tweedie @ 2000-06-11 19:23 UTC (permalink / raw)
To: I Lee Hetherington
Cc: Russell King, Alan Cox, sully, Bryan Paxton, linux-kernel,
Stephen Tweedie, linux-mm
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
Hi,
On Sun, Jun 11, 2000 at 12:34:40PM -0400, I Lee Hetherington wrote:
> I am not seeing this BUG in ac12. It is solid for me. It would seem to
> be an ac13 feature.
It is. The fix is below.
The problem is that with async write-behind, buffers on the per-inode
dirty list can be cleaned and I/O can complete before the vm scanner
identifies the clean buffer and refiles it (which will remove if from
the inode list). So, we can end up with clean buffers on the per-inode
dirty list. It is quite legal to recycle these buffers, and
try_to_free_buffers() already owns the necessary spinlocks to do so
by the time it gets this far.
--Stephen
[-- Attachment #2: osync-2.4.0-test1-ac13.diff1 --]
[-- Type: text/plain, Size: 337 bytes --]
--- linux-2.4.0-test1-ac13/fs/buffer.c.~1~ Sun Jun 11 19:50:22 2000
+++ linux-2.4.0-test1-ac13/fs/buffer.c Sun Jun 11 19:54:57 2000
@@ -2438,9 +2438,7 @@
* queues or on the free list..
*/
if (p->b_dev != B_FREE) {
- // @@@
- if (p->b_inode)
- BUG();
+ remove_inode_queue(p);
__remove_from_queues(p);
}
else
^ permalink raw reply [flat|nested] only message in thread