From: Kanoj Sarcar <kanoj@google.engr.sgi.com>
To: slpratt@us.ibm.com (Steve Pratt/Austin/IBM)
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com, linux-mm@kvack.org
Subject: Re: [PATCH] 2.4.0-test10-pre6 TLB flush race in establish_pte
Date: Mon, 30 Oct 2000 13:39:31 -0800 (PST) [thread overview]
Message-ID: <200010302139.NAA97387@google.engr.sgi.com> (raw)
In-Reply-To: <OFB4731A18.0D8D8BC1-ON85256988.0074562B@raleigh.ibm.com> from "Steve Pratt/Austin/IBM" at Oct 30, 2000 03:31:22 PM
>
> So while there may be a more elegant solution down the road, I would like
> to see the simple fix put back into 2.4. Here is the patch to essential
> put the code back to the way it was before the S/390 merge. Patch is
> against 2.4.0-test10pre6.
>
> --- linux/mm/memory.c Fri Oct 27 15:26:14 2000
> +++ linux-2.4.0-test10patch/mm/memory.c Fri Oct 27 15:45:54 2000
> @@ -781,8 +781,8 @@
> */
> static inline void establish_pte(struct vm_area_struct * vma, unsigned long address, pte_t *page_table, pte_t entry)
> {
> - flush_tlb_page(vma, address);
> set_pte(page_table, entry);
> + flush_tlb_page(vma, address);
> update_mmu_cache(vma, address, entry);
> }
>
Great, lets do it. Definitely solves one race.
Kanoj
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Kanoj Sarcar <kanoj@google.engr.sgi.com>
To: Steve Pratt/Austin/IBM <slpratt@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com, linux-mm@kvack.org
Subject: Re: [PATCH] 2.4.0-test10-pre6 TLB flush race in establish_pte
Date: Mon, 30 Oct 2000 13:39:31 -0800 (PST) [thread overview]
Message-ID: <200010302139.NAA97387@google.engr.sgi.com> (raw)
In-Reply-To: <OFB4731A18.0D8D8BC1-ON85256988.0074562B@raleigh.ibm.com> from "Steve Pratt/Austin/IBM" at Oct 30, 2000 03:31:22 PM
>
> So while there may be a more elegant solution down the road, I would like
> to see the simple fix put back into 2.4. Here is the patch to essential
> put the code back to the way it was before the S/390 merge. Patch is
> against 2.4.0-test10pre6.
>
> --- linux/mm/memory.c Fri Oct 27 15:26:14 2000
> +++ linux-2.4.0-test10patch/mm/memory.c Fri Oct 27 15:45:54 2000
> @@ -781,8 +781,8 @@
> */
> static inline void establish_pte(struct vm_area_struct * vma, unsigned long address, pte_t *page_table, pte_t entry)
> {
> - flush_tlb_page(vma, address);
> set_pte(page_table, entry);
> + flush_tlb_page(vma, address);
> update_mmu_cache(vma, address, entry);
> }
>
Great, lets do it. Definitely solves one race.
Kanoj
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-10-30 21:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-30 21:31 [PATCH] 2.4.0-test10-pre6 TLB flush race in establish_pte Steve Pratt/Austin/IBM
2000-10-30 21:31 ` Steve Pratt/Austin/IBM
2000-10-30 21:39 ` Kanoj Sarcar [this message]
2000-10-30 21:39 ` Kanoj Sarcar
2000-10-31 0:30 ` Andrea Arcangeli
2000-10-31 0:30 ` Andrea Arcangeli
2000-10-31 16:23 ` Steven Pratt
2000-10-31 16:44 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2000-10-31 18:42 Ulrich.Weigand
2000-10-31 18:42 ` Ulrich.Weigand
2000-10-31 19:13 ` Andrea Arcangeli
2000-10-31 19:13 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200010302139.NAA97387@google.engr.sgi.com \
--to=kanoj@google.engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=slpratt@us.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.