2.4.4-pre3: lvm.c patch results in "hanging" mount or swapon

2.4.4-pre3: lvm.c patch results in "hanging" mount or swapon

[Arjan Filius]

Hello,

While trying kernel 2.4.4-pre3 i found a "hanging" swapon (my swap is on
LVM), same effect for "mount -a". 2.4.3 works properly.

I found ./drivers/md/lvm.c is patched, and restoring the lvm.c from 2.4.3
resulted in normal operation.

I Found LVM/0.9.1_beta7 makes some notes about the patch, so i tried that
(beta7), but no luck, only 2.4.3:lvm.c worked ok.

Greatings,

-- 
Arjan Filius
mailto:iafilius@xs4all.nl

Re: 2.4.4-pre3: lvm.c patch results in "hanging" mount or swapon

[Jens Axboe]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On Sun, Apr 15 2001, Arjan Filius wrote:
> Hello,
> 
> While trying kernel 2.4.4-pre3 i found a "hanging" swapon (my swap is on
> LVM), same effect for "mount -a". 2.4.3 works properly.
> 
> I found ./drivers/md/lvm.c is patched, and restoring the lvm.c from 2.4.3
> resulted in normal operation.
> 
> I Found LVM/0.9.1_beta7 makes some notes about the patch, so i tried that
> (beta7), but no luck, only 2.4.3:lvm.c worked ok.

Small buglet in the buffer_IO_error out path, I maybe that's it...

-- 
Jens Axboe


[-- Attachment #2: lvm-eout-1 --]
[-- Type: text/plain, Size: 302 bytes --]

--- /opt/kernel/linux-2.4.4-pre3/drivers/md/lvm.c	Sun Apr 15 16:24:13 2001
+++ drivers/md/lvm.c	Sun Apr 15 16:23:36 2001
@@ -1675,8 +1675,10 @@
 			       struct buffer_head *bh)
 {
 	int ret = lvm_map(bh, rw);
-	if (ret < 0)
+	if (ret < 0) {
+		ret = 0;
 		buffer_IO_error(bh);
+	}
 	return ret;
 }
 

[linux-lvm] Re: 2.4.4-pre3: lvm.c patch results in "hanging" mount or swapon

[Arjan Filius]

Hello,

On Sun, 15 Apr 2001, Jens Axboe wrote:

> On Sun, Apr 15 2001, Arjan Filius wrote:
> > Hello,
> >
> > While trying kernel 2.4.4-pre3 i found a "hanging" swapon (my swap is on
> > LVM), same effect for "mount -a". 2.4.3 works properly.
> >
> > I found ./drivers/md/lvm.c is patched, and restoring the lvm.c from 2.4.3
> > resulted in normal operation.
> >
> > I Found LVM/0.9.1_beta7 makes some notes about the patch, so i tried that
> > (beta7), but no luck, only 2.4.3:lvm.c worked ok.
>
> Small buglet in the buffer_IO_error out path, I maybe that's it...

Dunno, i did som 'strace'ing and found it is waiting in read():
open("/dev/vg_4/lv_images", O_RDONLY)   = 4
lseek(4, 1024, SEEK_SET)                = 1024
read(4,
      (killed with SAK)


Greatings,



-- 
Arjan Filius
mailto:iafilius@xs4all.nl

Re: 2.4.4-pre3: lvm.c patch results in "hanging" mount or swapon

[Arjan Filius]

Hello,

On Sun, 15 Apr 2001, Jens Axboe wrote:

> On Sun, Apr 15 2001, Arjan Filius wrote:
> > Hello,
> >
> > While trying kernel 2.4.4-pre3 i found a "hanging" swapon (my swap is on
> > LVM), same effect for "mount -a". 2.4.3 works properly.
> >
> > I found ./drivers/md/lvm.c is patched, and restoring the lvm.c from 2.4.3
> > resulted in normal operation.
> >
> > I Found LVM/0.9.1_beta7 makes some notes about the patch, so i tried that
> > (beta7), but no luck, only 2.4.3:lvm.c worked ok.
>
> Small buglet in the buffer_IO_error out path, I maybe that's it...

Dunno, i did som 'strace'ing and found it is waiting in read():
open("/dev/vg_4/lv_images", O_RDONLY)   = 4
lseek(4, 1024, SEEK_SET)                = 1024
read(4,
      (killed with SAK)


Greatings,



-- 
Arjan Filius
mailto:iafilius@xs4all.nl