From: Pete Wyckoff <pw@osc.edu>
To: Rik van Riel <riel@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [docPATCH] mm.h documentation
Date: Mon, 18 Jun 2001 09:35:46 -0400 [thread overview]
Message-ID: <20010618093546.A9415@osc.edu> (raw)
In-Reply-To: <Pine.LNX.4.33.0106162309010.17512-100000@duckman.distro.conectiva>
In-Reply-To: <Pine.LNX.4.33.0106162309010.17512-100000@duckman.distro.conectiva>; from riel@conectiva.com.br on Sat, Jun 16, 2001 at 11:12:19PM -0300
riel@conectiva.com.br said:
> typedef struct page {
[..]
> + unsigned long index; /* Our offset within mapping. */
[..]
> + * A page may belong to an inode's memory mapping. In this case,
> + * page->mapping is the pointer to the inode, and page->offset is the
> + * file offset of the page (not necessarily a multiple of PAGE_SIZE).
Minor nit.
The field offset was renamed to index some time ago, but I can't
figure out if the usage changed. Can you fix the comment and educate
us?
-- Pete
WARNING: multiple messages have this Message-ID (diff)
From: Pete Wyckoff <pw@osc.edu>
To: Rik van Riel <riel@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [docPATCH] mm.h documentation
Date: Mon, 18 Jun 2001 09:35:46 -0400 [thread overview]
Message-ID: <20010618093546.A9415@osc.edu> (raw)
In-Reply-To: <Pine.LNX.4.33.0106162309010.17512-100000@duckman.distro.conectiva>; from riel@conectiva.com.br on Sat, Jun 16, 2001 at 11:12:19PM -0300
riel@conectiva.com.br said:
> typedef struct page {
[..]
> + unsigned long index; /* Our offset within mapping. */
[..]
> + * A page may belong to an inode's memory mapping. In this case,
> + * page->mapping is the pointer to the inode, and page->offset is the
> + * file offset of the page (not necessarily a multiple of PAGE_SIZE).
Minor nit.
The field offset was renamed to index some time ago, but I can't
figure out if the usage changed. Can you fix the comment and educate
us?
-- Pete
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-06-18 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-17 2:12 [docPATCH] mm.h documentation Rik van Riel
2001-06-17 2:12 ` Rik van Riel
2001-06-18 13:35 ` Pete Wyckoff [this message]
2001-06-18 13:35 ` Pete Wyckoff
2001-06-18 15:24 ` Ben LaHaise
2001-06-18 15:24 ` Ben LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010618093546.A9415@osc.edu \
--to=pw@osc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.