All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: "David S. Miller" <davem@redhat.com>,
	rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL] Warn users about machines with non-working WP bit
Date: Mon, 20 Aug 2001 20:03:16 +0000	[thread overview]
Message-ID: <20010820200315.A111@toy.ucw.cz> (raw)
In-Reply-To: <3D4F9A19.5040100@colorfullife.com>; from manfred@colorfullife.com on Tue, Aug 06, 2002 at 11:42:49AM +0200

Hi!

> >   From: Manfred Spraul <manfred@colorfullife.com>
> >   Date: Tue, 06 Aug 2002 11:17:33 +0200
> >
> >   > -		printk("No.\n");
> >   > +		printk("No (that's security hole).\n");
> >   >  #ifdef CONFIG_X86_WP_WORKS_OK
> >   
> >   Could you explain the hole?
> >   WP works for user space apps, only ring0 (or ring 0-2?) code
> >   ignores the WP bit on i386.
> >
> >So copy_to_user() could write to user areas that are write-proteced.
> >
> >verify_area() checks aren't enough, consider a threaded application
> >calling mprotect() while the copy is in progress.

> Then we should either fix copy_to_user(), or mark 80386 unsupported, or 
> disable multi-threading on 80386. It's a random memory corruption, far 
> worse than a security hole.

Fortunately app has to be seriously missbehaving for this to happen. Fixing
copy_to_user would be nicest; I do not think dropping 386 because of *this*
is good idea... [But it might force 386 users to fix copy_to_user ;-)]

									Pavel
-- 
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.


  reply	other threads:[~2002-08-19 20:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-06  9:17 [TRIVIAL] Warn users about machines with non-working WP bit Manfred Spraul
2002-08-06  9:28 ` David S. Miller
2002-08-06  9:42   ` Manfred Spraul
2001-08-20 20:03     ` Pavel Machek [this message]
2002-08-06 14:03   ` Kasper Dupont
2002-08-06 13:56     ` David S. Miller
2002-08-06 14:16       ` Kasper Dupont
2002-08-06 14:05         ` David S. Miller
2002-08-06 14:27           ` Kasper Dupont
2002-08-06 14:36             ` Manfred Spraul
2001-08-20 20:06               ` Pavel Machek
2002-08-19 22:04                 ` Alan Cox
2002-08-06 15:11               ` Kasper Dupont
2002-08-06 16:38               ` Willy Tarreau
2002-08-06 16:45               ` Zwane Mwaikambo
  -- strict thread matches above, loose matches on Subject: below --
2002-08-06  3:49 Rusty Trivial Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010820200315.A111@toy.ucw.cz \
    --to=pavel@suse.cz \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.