All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Kasper Dupont <kasperd@daimi.au.dk>
Cc: "David S. Miller" <davem@redhat.com>,
	rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL] Warn users about machines with non-working WP bit
Date: Tue, 06 Aug 2002 16:36:35 +0200	[thread overview]
Message-ID: <3D4FDEF3.8070207@colorfullife.com> (raw)
In-Reply-To: 3D4FDCDB.744EE7C9@daimi.au.dk

Kasper Dupont wrote:

>I just get another idea, that might be easier to get right. If
>the only problem is one process changing the mm while another
>process is doing a copy_to_user, we should be able to fix it by
>placing a readlock on the mm while the copy_to_user is in progress.
>  
>
Yes, that would work. copy_to_user is never called with the mmap 
semaphore locked, i.e.

#define copy_to_user(...) \
        down(&current->mm->mmap_sem); \
        check_wp_bit(); \
        real_copy_to_user(); \
        up(&current->mm->mmap_sem)

verify_area would just check that the pointer is below TASK_SIZE, and 
the wp bit is checked within copy_to_user().

But how many 80386 Linux systems that run the 2.4 kernel exist?

--
    Manfred


  reply	other threads:[~2002-08-06 14:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-06  9:17 [TRIVIAL] Warn users about machines with non-working WP bit Manfred Spraul
2002-08-06  9:28 ` David S. Miller
2002-08-06  9:42   ` Manfred Spraul
2001-08-20 20:03     ` Pavel Machek
2002-08-06 14:03   ` Kasper Dupont
2002-08-06 13:56     ` David S. Miller
2002-08-06 14:16       ` Kasper Dupont
2002-08-06 14:05         ` David S. Miller
2002-08-06 14:27           ` Kasper Dupont
2002-08-06 14:36             ` Manfred Spraul [this message]
2001-08-20 20:06               ` Pavel Machek
2002-08-19 22:04                 ` Alan Cox
2002-08-06 15:11               ` Kasper Dupont
2002-08-06 16:38               ` Willy Tarreau
2002-08-06 16:45               ` Zwane Mwaikambo
  -- strict thread matches above, loose matches on Subject: below --
2002-08-06  3:49 Rusty Trivial Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D4FDEF3.8070207@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=davem@redhat.com \
    --cc=kasperd@daimi.au.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.