All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@oss.sgi.com>
To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Cc: linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: Magic numbers about stack layout
Date: Wed, 22 Aug 2001 13:40:17 +0200	[thread overview]
Message-ID: <20010822134017.A18730@dea.linux-mips.net> (raw)
In-Reply-To: <20010822.144547.30190293.nemoto@toshiba-tops.co.jp>; from nemoto@toshiba-tops.co.jp on Wed, Aug 22, 2001 at 02:45:47PM +0900

On Wed, Aug 22, 2001 at 02:45:47PM +0900, Atsushi Nemoto wrote:

> There are some magic constant numbers about stack layout in
> thread_saved_pc() and get_wchan() function.
> 
> I made a patch to eliminate these magic numbers.  This patch analyzes
> some functions prologue codes in heuristic way at run-time.  "ps -l"
> (and "MAGIC SYSRQ" feature) works fine with this patch.

Very nice, this part of the kernel used to be rather fragile on all
architectures; when wchan computation broke usually nobody complained
and this looks like a major improvment!

Thanks,

  Ralf

  parent reply	other threads:[~2001-08-22 11:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-22  5:45 Magic numbers about stack layout Atsushi Nemoto
2001-08-22  6:46 ` Hartvig Ekner
2001-08-22  6:46   ` Hartvig Ekner
2001-08-22  7:15   ` Atsushi Nemoto
2001-08-22 11:40 ` Ralf Baechle [this message]
     [not found] ` <200205280611.g4S6BuEj006804@oss.sgi.com>
2002-05-28  8:26   ` Magic numbers about stack layout (again) Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010822134017.A18730@dea.linux-mips.net \
    --to=ralf@oss.sgi.com \
    --cc=linux-mips@fnet.fr \
    --cc=linux-mips@oss.sgi.com \
    --cc=nemoto@toshiba-tops.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.