From: Hartvig Ekner <hartvige@mips.com>
To: nemoto@toshiba-tops.co.jp (Atsushi Nemoto)
Cc: linux-mips@oss.sgi.com
Subject: Re: Magic numbers about stack layout
Date: Wed, 22 Aug 2001 08:46:01 +0200 (MET DST) [thread overview]
Message-ID: <200108220646.IAA13918@copsun17.mips.com> (raw)
In-Reply-To: <20010822.144547.30190293.nemoto@toshiba-tops.co.jp> from "Atsushi Nemoto" at Aug 22, 2001 02:45:47 PM
Hi,
what is the purpose of replacing the magic numbers with code analysis?
And what will happen when you run userland with MIPS16 or MIPS16e code?
We have it on our work-list to eventually clean up all the places in the
kernel that inspect code to allow MIPS16(e) code as well, so adding more
code inspection points is a bad idea unless it really is necessary.
/Hartvig
Atsushi Nemoto writes:
>
> ----Next_Part(Wed_Aug_22_14:45:47_2001_172)--
> Content-Type: Text/Plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> There are some magic constant numbers about stack layout in
> thread_saved_pc() and get_wchan() function.
>
> I made a patch to eliminate these magic numbers. This patch analyzes
> some functions prologue codes in heuristic way at run-time. "ps -l"
> (and "MAGIC SYSRQ" feature) works fine with this patch.
>
> ---
> Atsushi Nemoto
WARNING: multiple messages have this Message-ID (diff)
From: Hartvig Ekner <hartvige@mips.com>
To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Cc: linux-mips@oss.sgi.com
Subject: Re: Magic numbers about stack layout
Date: Wed, 22 Aug 2001 08:46:01 +0200 (MET DST) [thread overview]
Message-ID: <200108220646.IAA13918@copsun17.mips.com> (raw)
Message-ID: <20010822064601.ifDsYXdKnwZGgZ5sB1rytYW0Y1NV8zwx7IRAScY50dY@z> (raw)
In-Reply-To: <20010822.144547.30190293.nemoto@toshiba-tops.co.jp> from "Atsushi Nemoto" at Aug 22, 2001 02:45:47 PM
Hi,
what is the purpose of replacing the magic numbers with code analysis?
And what will happen when you run userland with MIPS16 or MIPS16e code?
We have it on our work-list to eventually clean up all the places in the
kernel that inspect code to allow MIPS16(e) code as well, so adding more
code inspection points is a bad idea unless it really is necessary.
/Hartvig
Atsushi Nemoto writes:
>
> ----Next_Part(Wed_Aug_22_14:45:47_2001_172)--
> Content-Type: Text/Plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> There are some magic constant numbers about stack layout in
> thread_saved_pc() and get_wchan() function.
>
> I made a patch to eliminate these magic numbers. This patch analyzes
> some functions prologue codes in heuristic way at run-time. "ps -l"
> (and "MAGIC SYSRQ" feature) works fine with this patch.
>
> ---
> Atsushi Nemoto
next prev parent reply other threads:[~2001-08-22 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-22 5:45 Magic numbers about stack layout Atsushi Nemoto
2001-08-22 6:46 ` Hartvig Ekner [this message]
2001-08-22 6:46 ` Hartvig Ekner
2001-08-22 7:15 ` Atsushi Nemoto
2001-08-22 11:40 ` Ralf Baechle
[not found] ` <200205280611.g4S6BuEj006804@oss.sgi.com>
2002-05-28 8:26 ` Magic numbers about stack layout (again) Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108220646.IAA13918@copsun17.mips.com \
--to=hartvige@mips.com \
--cc=linux-mips@oss.sgi.com \
--cc=nemoto@toshiba-tops.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.