[linux-lvm] min() and max() problems with 2.4.8 and 1.0.1

[linux-lvm] min() and max() problems with 2.4.8 and 1.0.1

[Jean-Eric Cuendet]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]


Hi,
I just patched my kernel with 1.0.1rc1 and have problems with min() and
max() functions. They are not found in lvm.c and lvm-snap.c .

FYI, I have also ext3, acls and quota3 patches applied. Could they make
that?

What to do?
-jec

---------------------------------------------------
Jean-Eric Cuendet
Linkvest SA
Av des Baumettes 19, 1020 Renens Switzerland
Tel +41 21 632 9043  Fax +41 21 632 9090
http://www.linkvest.com  E-mail: jean-eric.cuendet@linkvest.com
---------------------------------------------------

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Jean-Eric Cuendet.vcf --]
[-- Type: text/x-vcard; name="Jean-Eric Cuendet.vcf", Size: 178 bytes --]

BEGIN:VCARD
VERSION:2.1
N:Cuendet;Jean-Eric
FN:Jean-Eric Cuendet
ORG:Linkvest S.A.;CCSR
EMAIL;PREF;INTERNET:Jean-Eric.Cuendet@linkvest.com
REV:20010724T142411Z
END:VCARD

Re: [linux-lvm] min() and max() problems with 2.4.8 and 1.0.1

[Totoro]

On Thu, Aug 23, 2001 at 11:36:37AM +0200, Jean-Eric Cuendet wrote:
> 
> Hi,
> I just patched my kernel with 1.0.1rc1 and have problems with min() and
> max() functions. They are not found in lvm.c and lvm-snap.c .
> 
> FYI, I have also ext3, acls and quota3 patches applied. Could they make
> that?
No, the 1.0.1rc1 is against 2.4.9 and uses the new min() and max()
created by Linus.
I don't know if 1.0.1rc1 was maid to be compatible with 2.4.8.
1.0.0 works fine on 2.4.8.

Totoro

> 
> What to do?
> -jec
> 
> ---------------------------------------------------
> Jean-Eric Cuendet
> Linkvest SA
> Av des Baumettes 19, 1020 Renens Switzerland
> Tel +41 21 632 9043  Fax +41 21 632 9090
> http://www.linkvest.com  E-mail: jean-eric.cuendet@linkvest.com
> ---------------------------------------------------

Content-Description: Jean-Eric Cuendet.vcf

Re: [linux-lvm] min() and max() problems with 2.4.8 and 1.0.1

[Joe Thornber]

On Thu, Aug 23, 2001 at 05:27:46PM +0200, Totoro wrote:
> On Thu, Aug 23, 2001 at 11:36:37AM +0200, Jean-Eric Cuendet wrote:
> > 
> > Hi,
> > I just patched my kernel with 1.0.1rc1 and have problems with min() and
> > max() functions. They are not found in lvm.c and lvm-snap.c .
> > 
> > FYI, I have also ext3, acls and quota3 patches applied. Could they make
> > that?
> No, the 1.0.1rc1 is against 2.4.9 and uses the new min() and max()
> created by Linus.
> I don't know if 1.0.1rc1 was maid to be compatible with 2.4.8.
> 1.0.0 works fine on 2.4.8.

I put this code in to support older kernels:

#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 4, 9)
#undef min
#undef max
#define min(type, a, b) (((a) < (b)) ? (a) : (b))
#define max(type, a, b) (((a) > (b)) ? (a) : (b))
#endif

I tested 2.4.8 and Alasdair tested 2.4.7.

- Joe