[linux-lvm] LVM and -ac kernels?

[linux-lvm] LVM and -ac kernels?

[Benjamin Reed]

I've tried applying 1.0.1-rc2 to 2.4.9-ac9 and it appears
that something's not matching up; I was wondering if anyone
has had any luck with the 2.4.9 ac kernels?

I get a reject in the Makefile for something that Alan's
already added to his tree, and when I build, I get:

---(snip!)---
make[3]: Entering directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
gcc -D__KERNEL__ -I/usr/src/linux-2.4.9-ac9-eb1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686    -c -o lvm.o lvm.c
lvm.c: In function `__extend_reduce':
lvm.c:2329: warning: implicit declaration of function `min'
lvm.c:2329: parse error before `uint'
lvm.c:2343: parse error before `uint'
lvm.c:2280: warning: `end' might be used uninitialized in this function
lvm.c:2339: warning: `end' might be used uninitialized in this function
make[3]: *** [lvm.o] Error 1
make[3]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
make[1]: *** [_subdir_md] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers'
make: *** [_dir_drivers] Error 2
---(snip!)---

Feel free to tell me "don't bother with -ac kernels and LVM", all
I *truly* care about from the -ac tree is ext3, but it would be nice
if it's a simple fix.

TIA,

-- 
Ben Reed a.k.a. Ranger Rick (ranger@befunk.com)
http://defiance.dyndns.org/ / http://radio.scenespot.org/
The devil's in the broad, sweeping generalizations.

Re: [linux-lvm] LVM and -ac kernels?

[svetljo]

i couldn't compile 2.4.9-ac5 with lvm-1.0.1rc1 and rc2, but it worked 
with lvm-1.0

Benjamin Reed wrote:

>I've tried applying 1.0.1-rc2 to 2.4.9-ac9 and it appears
>that something's not matching up; I was wondering if anyone
>has had any luck with the 2.4.9 ac kernels?
>
>I get a reject in the Makefile for something that Alan's
>already added to his tree, and when I build, I get:
>
>---(snip!)---
>make[3]: Entering directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
>gcc -D__KERNEL__ -I/usr/src/linux-2.4.9-ac9-eb1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686    -c -o lvm.o lvm.c
>lvm.c: In function `__extend_reduce':
>lvm.c:2329: warning: implicit declaration of function `min'
>lvm.c:2329: parse error before `uint'
>lvm.c:2343: parse error before `uint'
>lvm.c:2280: warning: `end' might be used uninitialized in this function
>lvm.c:2339: warning: `end' might be used uninitialized in this function
>make[3]: *** [lvm.o] Error 1
>make[3]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
>make[2]: *** [first_rule] Error 2
>make[2]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
>make[1]: *** [_subdir_md] Error 2
>make[1]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers'
>make: *** [_dir_drivers] Error 2
>---(snip!)---
>
>Feel free to tell me "don't bother with -ac kernels and LVM", all
>I *truly* care about from the -ac tree is ext3, but it would be nice
>if it's a simple fix.
>
>TIA,
>

Re: [linux-lvm] LVM and -ac kernels?

[AJ Lewis]

[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]

On Sun, Sep 09, 2001 at 10:46:06AM -0400, Benjamin Reed wrote:
> I've tried applying 1.0.1-rc2 to 2.4.9-ac9 and it appears
> that something's not matching up; I was wondering if anyone
> has had any luck with the 2.4.9 ac kernels?
> 
> I get a reject in the Makefile for something that Alan's
> already added to his tree, and when I build, I get:
> 
> ---(snip!)---
> make[3]: Entering directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.9-ac9-eb1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686    -c -o lvm.o lvm.c
> lvm.c: In function `__extend_reduce':
> lvm.c:2329: warning: implicit declaration of function `min'

Yep, this is caused by the great MIN/MAX macro change in the 2.4.9 stock
kernel.   Alan didn't think it was a good idea, so his AC series kernels
still use the old style MIN/MAX macros.  Unfortunately, the way the patches
are currently generated, any kernel above 2.4.9 is assumed to have the new
format.

> Feel free to tell me "don't bother with -ac kernels and LVM", all
> I *truly* care about from the -ac tree is ext3, but it would be nice
> if it's a simple fix.

I'm not sure what the best way to fix this is.  You possibly could go in and
manually change the kernel version in the PATCHES/Makefile file to be
2.4.8-ac9; this shouldn't change anything but which versions of the patches
are put into the patch and the patch name, but it may not work.  I would try
this first...if that doesn't work, we'll have to start looking at
alternatives.

Regards,
-- 
AJ Lewis
Sistina Software Inc.                  Voice:  612-638-0500
1313 5th St SE, Suite 111              Fax:    612-638-0500
Minneapolis, MN 55414                  E-Mail: lewis@sistina.com
http://www.sistina.com

Current GPG fingerprint = 60F3 160D C0D5 2C4B 751B  4FF9 6F67 E9BC 44CD DE95

-----Begin Obligatory Humorous Quote----------------------------------------
Employment tip #127: Never take a beer to a job interview.
-----End Obligatory Humorous Quote------------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [linux-lvm] LVM and -ac kernels?

[Jim Cromie]

Benjamin Reed wrote:

> I've tried applying 1.0.1-rc2 to 2.4.9-ac9 and it appears
> that something's not matching up; I was wondering if anyone
> has had any luck with the 2.4.9 ac kernels?
>
> I get a reject in the Makefile for something that Alan's
> already added to his tree, and when I build, I get:
>
> ---(snip!)---
> make[3]: Entering directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.9-ac9-eb1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686    -c -o lvm.o lvm.c
> lvm.c: In function `__extend_reduce':
> lvm.c:2329: warning: implicit declaration of function `min'
> lvm.c:2329: parse error before `uint'
> lvm.c:2343: parse error before `uint'
> lvm.c:2280: warning: `end' might be used uninitialized in this function
> lvm.c:2339: warning: `end' might be used uninitialized in this function
> make[3]: *** [lvm.o] Error 1
> make[3]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> make[2]: *** [first_rule] Error 2
> make[2]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> make[1]: *** [_subdir_md] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers'
> make: *** [_dir_drivers] Error 2
> ---(snip!)---
>
> Feel free to tell me "don't bother with -ac kernels and LVM", all
> I *truly* care about from the -ac tree is ext3, but it would be nice
> if it's a simple fix.
>
> TIA,

simple enough.

in line 2329, s/uint, /
again on 2343,

recompile, find similar errors in lvm-snap.c,

again remove 1st of 3 parameters.

reason:

min( type, a, b )  now restored to min ( a, b)

cuz

#define min (a, b)
is redefined to be type-safe ( new macro def  insists that typeof (a) == typeof (b) )
without requireing type param