All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Berra <bluca@comedia.it>
To: linux-lvm@sistina.com
Subject: Re: [linux-lvm] pvcreate fails on a software RAID metadisk
Date: Fri, 5 Oct 2001 21:31:21 +0200	[thread overview]
Message-ID: <20011005213121.A4811@colombina.comedia.it> (raw)
In-Reply-To: <NEBBLHFAEINCLDICDLOAIENJCHAA.yves.alloyer@slpinfoware.com>; from Yves.ALLOYER@slpinfoware.com on Fri, Oct 05, 2001 at 11:13:35AM +0200

On Fri, Oct 05, 2001 at 11:13:35AM +0200, yves.alloyer wrote:
> I did a quick and dirty patch which fixed it for me.
> Please be aware: I am new to this list, new to linux LVM...
> I know the patch will prevent you from using any partitioned MD device in
> LVM. I have no idea of further implications.
Yves, thanks this seems to have fixed this, i still agree with Andreas that lvm_check_partitioned_dev should be
checked.
i wuld use LVM_DEVICE_TYPE_MD instead of 2 in the patch
as for partitioned md device i believe the major is different from 9, but i would not suggest using them
with lvm anyway.

patch with my mod follows for the lazy,
pleas check it in cvs for the time being.

--- tools/lib/lvm_check_partitioned_dev.c.bluca	Thu Aug 23 07:51:53 2001
+++ tools/lib/lvm_check_partitioned_dev.c	Fri Oct  5 21:18:51 2001
@@ -55,6 +55,8 @@
 	switch (lvm_get_device_type(st_rdev)) {
 	case LVM_DEVICE_TYPE_INVALID:
 	    break;
+	case LVM_DEVICE_TYPE_MD:
+	    break;
 	default:
 	    ret = TRUE;
 	}

-- 
Luca Berra -- bluca@comedia.it
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \

      reply	other threads:[~2001-10-05 19:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-04 16:16 [linux-lvm] pvcreate fails on a software RAID metadisk Bill Ellis
2001-10-04 19:59 ` Bill Ellis
2001-10-04 20:46   ` Andreas Dilger
2001-10-05  8:30     ` Luca Berra
2001-10-05  9:31       ` Andreas Dilger
2001-10-05  9:13 ` yves.alloyer
2001-10-05 19:31   ` Luca Berra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011005213121.A4811@colombina.comedia.it \
    --to=bluca@comedia.it \
    --cc=linux-lvm@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.