Re: [PATCH] updated preempt-kernel

[Taral <taral@taral.net>]

On Sun, Oct 21, 2001 at 02:16:18PM -0400, Robert Love wrote:
> Colin, can you try Andrew's patch and report back?  This problem has
> been reported before -- its a tty bug that preempt (and SMP I wager)
> just aggravate.  I have a patch that I know fixes it, but Andrew's is
> _much_ simpler.  I will send you that if this fails.  Please let me
> know.

This also looks a bit wrong:
> > +	if (vt) {
> > +		/*
> > +		 * If we raced with con_close(), `vt' may be null.
> > +		 * Hence this bandaid.   - akpm
> > +		 */
> > +		acquire_console_sem();
> > +		set_cursor(vt->vc_num);
> > +		release_console_sem();
> > +	}

Maybe should be:

acquire_console_sem();
if (vt) set_cursor(vt->vc_num);
release_console_sem();

??

-- 
Taral <taral@taral.net>
This message is digitally signed. Please PGP encrypt mail to me.
"Any technology, no matter how primitive, is magic to those who don't
understand it." -- Florence Ambrose