[PATCH] Simplify serverworks workaround.

[PATCH] Simplify serverworks workaround.

[Dave Jones]

Linus, Richard,
 Patch below makes the workaround for Serverworks LE chipsets
 a little simpler, and also adds a printk to let people know
 why they can't use Write-combining.

regards,

Dave.


diff -urN --exclude-from=/home/davej/.exclude linux/arch/i386/kernel/mtrr.c ../2.5/linux-dj/arch/i386/kernel/mtrr.c
--- linux/arch/i386/kernel/mtrr.c	Fri Oct 12 16:29:57 2001
+++ linux-dj/arch/i386/kernel/mtrr.c	Sat Oct 13 12:08:34 2001
@@ -473,25 +473,16 @@
     unsigned long config, dummy;
     struct pci_dev *dev = NULL;
     
-   /* ServerWorks LE chipsets have problems with  write-combining 
-      Don't allow it and  leave room for other chipsets to be tagged */
+   /* ServerWorks LE chipsets have problems with write-combining 
+      Don't allow it and leave room for other chipsets to be tagged */
 
-    if ((dev = pci_find_class(PCI_CLASS_BRIDGE_HOST << 8, NULL)) != NULL) {
-	switch(dev->vendor) {
-        case PCI_VENDOR_ID_SERVERWORKS:
- 	    switch (dev->device) {
-	    case PCI_DEVICE_ID_SERVERWORKS_LE:
+	if ((dev = pci_find_class(PCI_CLASS_BRIDGE_HOST << 8, NULL)) != NULL) {
+		if ((dev->vendor == PCI_VENDOR_ID_SERVERWORKS) &&
+			(dev->device == PCI_DEVICE_ID_SERVERWORKS_LE)) {
+		printk (KERN_INFO "mtrr: Serverworks LE detected. Write-combining disabled.\n");
 		return 0;
-		break;
-	    default:
-		break;
-	    }
-	    break;
-	default:
-	    break;
+		}
 	}
-    }
-
 
     switch ( mtrr_if )
     {


-- 
| Dave Jones.                    http://www.codemonkey.org.uk
| SuSE Labs .

Re: [PATCH] Simplify serverworks workaround.

[EvilTypeGuy]

On Wed, Oct 24, 2001 at 06:55:12PM +0100, Dave Jones wrote:
> Linus, Richard,
>  Patch below makes the workaround for Serverworks LE chipsets
>  a little simpler, and also adds a printk to let people know
>  why they can't use Write-combining.

Do the serverworks HE chipsets have the same problem?