[linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Adrian Phillips]

The problem seems to be (and I believe GRUB had the same problem) that
the device name for DAC960 changed from rd to dac960 in 2.4.

This patch fixes the partition checking code :-

--- tools/lib/lvm_check_partitioned_dev.c.orig  Tue Nov 27 09:16:03 2001
+++ tools/lib/lvm_check_partitioned_dev.c       Tue Nov 27 09:42:38 2001
@@ -140,7 +140,8 @@
        "md",                   /* Multiple Disk driver (SoftRAID)   */
        "loop",                 /* Loop device              */
        "dasd",                 /* DASD disk (IBM S/390, zSeries)      */
-       "dac960",               /* DAC960              */
+       "rd",                   /* DAC960 2.2          */
+       "dac960",               /* DAC960 2.4          */
        "nbd",                  /* Network Block Device              */
        "ida",                  /* Compaq SMART2              */
        "cciss",                /* Compaq CCISS array              */


Sincerely,

Adrian Phillips

-- 
Your mouse has moved.
Windows NT must be restarted for the change to take effect.
Reboot now?  [OK]

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Heinz J . Mauelshagen]

Checked it in.

Heinz

On Tue, Nov 27, 2001 at 09:44:47AM +0100, Adrian Phillips wrote:
> 
> The problem seems to be (and I believe GRUB had the same problem) that
> the device name for DAC960 changed from rd to dac960 in 2.4.
> 
> This patch fixes the partition checking code :-
> 
> --- tools/lib/lvm_check_partitioned_dev.c.orig  Tue Nov 27 09:16:03 2001
> +++ tools/lib/lvm_check_partitioned_dev.c       Tue Nov 27 09:42:38 2001
> @@ -140,7 +140,8 @@
>         "md",                   /* Multiple Disk driver (SoftRAID)   */
>         "loop",                 /* Loop device              */
>         "dasd",                 /* DASD disk (IBM S/390, zSeries)      */
> -       "dac960",               /* DAC960              */
> +       "rd",                   /* DAC960 2.2          */
> +       "dac960",               /* DAC960 2.4          */
>         "nbd",                  /* Network Block Device              */
>         "ida",                  /* Compaq SMART2              */
>         "cciss",                /* Compaq CCISS array              */
> 
> 
> Sincerely,
> 
> Adrian Phillips
> 
> -- 
> Your mouse has moved.
> Windows NT must be restarted for the change to take effect.
> Reboot now?  [OK]
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://www.sistina.com/lvm/Pages/howto.html

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Andreas Dilger]

On Nov 27, 2001  11:14 +0100, Heinz J . Mauelshagen wrote:
> 
> Checked it in.

But now it is broken.

> On Tue, Nov 27, 2001 at 09:44:47AM +0100, Adrian Phillips wrote:
> > --- tools/lib/lvm_check_partitioned_dev.c.orig  Tue Nov 27 09:16:03 2001
> > +++ tools/lib/lvm_check_partitioned_dev.c       Tue Nov 27 09:42:38 2001
> > @@ -140,7 +140,8 @@
> >         "md",                   /* Multiple Disk driver (SoftRAID)   */
> >         "loop",                 /* Loop device              */
> >         "dasd",                 /* DASD disk (IBM S/390, zSeries)      */
> > -       "dac960",               /* DAC960              */
> > +       "rd",                   /* DAC960 2.2          */
> > +       "dac960",               /* DAC960 2.4          */
> >         "nbd",                  /* Network Block Device              */
> >         "ida",                  /* Compaq SMART2              */
> >         "cciss",                /* Compaq CCISS array              */

Note that this will break other things, because you also need to update
the LVM_DEVICE_TYPE_<foo> defines when you change this array (it was
Joe or Alistair that wrote it this way, not me).  It would also break to
add a new enum value for DAC960, because it means we need to look for two
values elsewhere in the code (e.g. lvm_partition_count).

I just checked in a fix, which cleans up this code a bit and makes it
impossible to get wrong in the future.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Adrian Phillips]

>>>>> "Andreas" == Andreas Dilger <adilger@turbolabs.com> writes:
<snip>

    Andreas> Note that this will break other things, because you also
    Andreas> need to update the LVM_DEVICE_TYPE_<foo> defines when you
    Andreas> change this array (it was Joe or Alistair that wrote it
    Andreas> this way, not me).  It would also break to add a new enum
    Andreas> value for DAC960, because it means we need to look for
    Andreas> two values elsewhere in the code
    Andreas> (e.g. lvm_partition_count).

Thanks for noticing this. My patch "seemed" to work but I have almost
no experience with LVM code so missed the further reaching
consequences of my change.

    Andreas> I just checked in a fix, which cleans up this code a bit
    Andreas> and makes it impossible to get wrong in the future.

It would be useful if people could post patches to this list so that
individual changes could be tested by individuals on this list without
checking out the whole CVS which may include other patches which may
possibly break things.

Sincerely,

Adrian Phillips

-- 
Your mouse has moved.
Windows NT must be restarted for the change to take effect.
Reboot now?  [OK]

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Adrian Phillips]

>>>>> "Adrian" == Adrian Phillips <a.phillips@dnmi.no> writes:

<snip>
    Andreas> I just checked in a fix, which cleans up this code a bit
    Andreas> and makes it impossible to get wrong in the future.

    Adrian> It would be useful if people could post patches to this
    Adrian> list so that individual changes could be tested by
    Adrian> individuals on this list without checking out the whole
    Adrian> CVS which may include other patches which may possibly
    Adrian> break things.

Okay, forget this. I checked the web page and saw the CVS commit
mailing list which should give enough information to see which files
have changed.

Sorry about that.

Another question. I see from the commit list that various changes have
been made but doing an cvs update doesn't get me the latest changes :-

adilger     2001/11/27 11:41:24 CST

This is Andreas changes. Wiping the whole lot and checking out again
still doesn't give me the latest changes.

- Is this because changes are added to a tagged version ?
- or changes are made to a developers CVS and synced to the anonymous
  CVS ?

Sincerely,

Adrian Phillips

-- 
Your mouse has moved.
Windows NT must be restarted for the change to take effect.
Reboot now?  [OK]

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Joe Thornber]

On Tue, Nov 27, 2001 at 10:28:08AM -0700, Andreas Dilger wrote:
> On Nov 27, 2001  11:14 +0100, Heinz J . Mauelshagen wrote:
> > 
> > Checked it in.
> 
> But now it is broken.
> 
> > On Tue, Nov 27, 2001 at 09:44:47AM +0100, Adrian Phillips wrote:
> > > --- tools/lib/lvm_check_partitioned_dev.c.orig  Tue Nov 27 09:16:03 2001
> > > +++ tools/lib/lvm_check_partitioned_dev.c       Tue Nov 27 09:42:38 2001
> > > @@ -140,7 +140,8 @@
> > >         "md",                   /* Multiple Disk driver (SoftRAID)   */
> > >         "loop",                 /* Loop device              */
> > >         "dasd",                 /* DASD disk (IBM S/390, zSeries)      */
> > > -       "dac960",               /* DAC960              */
> > > +       "rd",                   /* DAC960 2.2          */
> > > +       "dac960",               /* DAC960 2.4          */
> > >         "nbd",                  /* Network Block Device              */
> > >         "ida",                  /* Compaq SMART2              */
> > >         "cciss",                /* Compaq CCISS array              */
> 
> Note that this will break other things, because you also need to update
> the LVM_DEVICE_TYPE_<foo> defines when you change this array (it was
> Joe or Alistair that wrote it this way, not me).

No, Stefan Bader wrote it that way.

- Joe

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Andreas Dilger]

On Nov 28, 2001  08:00 +0000, Joe Thornber wrote:
> On Tue, Nov 27, 2001 at 10:28:08AM -0700, Andreas Dilger wrote:
> > Note that this will break other things, because you also need to update
> > the LVM_DEVICE_TYPE_<foo> defines when you change this array (it was
> > Joe or Alistair that wrote it this way, not me).
> 
> No, Stefan Bader wrote it that way.

OK, sorry.  It was my impression that one of you had gone through and
re-done the whole device cache and identification code.  In any case,
it doesn't really matter - the problem is fixed.

Any objection to me digging out my changes to pv_read_all_pv_of_vg()
and friends and cleaning that lot up?  That was the source of the
other problem that Lars had, and it has been nasty for a long time.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Joe Thornber]

Andreas,

On Wed, Nov 28, 2001 at 09:17:27AM -0700, Andreas Dilger wrote:
> Any objection to me digging out my changes to pv_read_all_pv_of_vg()
> and friends and cleaning that lot up?  That was the source of the
> other problem that Lars had, and it has been nasty for a long time.

That would be most welcome, but can you post to the lists when your
code in CVS is ready for testing please (maybe use a tag) ?  I'm
worried that some changes (by all of us) aren't getting tested much
before they suddenly appear in a release.

- Joe

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Heinz J . Mauelshagen]

Well,

actually it was mostly me who shouldn't check something in sitting at
a the "Linux-Kongress" conference in Enschede ;-)

Peace folks!

Regards,
Heinz    -- The LVM Guy --


On Wed, Nov 28, 2001 at 08:19:24AM +0100, Adrian Phillips wrote:
> >>>>> "Adrian" == Adrian Phillips <a.phillips@dnmi.no> writes:
> 
> <snip>
>     Andreas> I just checked in a fix, which cleans up this code a bit
>     Andreas> and makes it impossible to get wrong in the future.
> 
>     Adrian> It would be useful if people could post patches to this
>     Adrian> list so that individual changes could be tested by
>     Adrian> individuals on this list without checking out the whole
>     Adrian> CVS which may include other patches which may possibly
>     Adrian> break things.
> 
> Okay, forget this. I checked the web page and saw the CVS commit
> mailing list which should give enough information to see which files
> have changed.
> 
> Sorry about that.
> 
> Another question. I see from the commit list that various changes have
> been made but doing an cvs update doesn't get me the latest changes :-
> 
> adilger     2001/11/27 11:41:24 CST
> 
> This is Andreas changes. Wiping the whole lot and checking out again
> still doesn't give me the latest changes.
> 
> - Is this because changes are added to a tagged version ?
> - or changes are made to a developers CVS and synced to the anonymous
>   CVS ?
> 
> Sincerely,
> 
> Adrian Phillips
> 
> -- 
> Your mouse has moved.
> Windows NT must be restarted for the change to take effect.
> Reboot now?  [OK]
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://www.sistina.com/lvm/Pages/howto.html

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] lvm-1.0.1 not working with DAC960/2.2.20

[Adrian Phillips]

>>>>> "Heinz" == Heinz J Mauelshagen <mauelshagen@sistina.com> writes:

    Heinz> Well,

    Heinz> actually it was mostly me who shouldn't check something in
    Heinz> sitting at a the "Linux-Kongress" conference in Enschede
    Heinz> ;-)

Great, thanks for letting me know. Anyway I got the patches I needed
out of CVS (ie. the correct DAC960 fix).

Sincerely,

Adrian Phillips

-- 
Your mouse has moved.
Windows NT must be restarted for the change to take effect.
Reboot now?  [OK]