All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@oss.sgi.com>
To: Vivien Chappelier <vivien.chappelier@enst-bretagne.fr>
Cc: linux-mips@oss.sgi.com
Subject: Re: patches for SGI O2
Date: Sat, 15 Dec 2001 23:27:57 -0200	[thread overview]
Message-ID: <20011215232757.A1863@dea.linux-mips.net> (raw)
In-Reply-To: <Pine.LNX.4.21.0112152332470.11851-400000@melkor>; from vivien.chappelier@enst-bretagne.fr on Sat, Dec 15, 2001 at 11:52:58PM +0100

On Sat, Dec 15, 2001 at 11:52:58PM +0100, Vivien Chappelier wrote:

> The first one (O2-asid) concerns the TLB initialization the IP32. The
> asid_cache is not initialized, which leads to MMU context = 0 being
> considered valid! Thus when switching task, in switch_mm, a new context is
> not created.

Correct finding.  It's just that you shouldn't have to apply this patch
to the IP32 code and that shows that mips64 needs quite a cleanup there.
Applied anyway.

> Finaly, with my configuration (SGI O2 R5000 @ 180Mhz) I've to change
> PAGE_OFFSET in page.h to the one used for IP22 rather than the one used
> for IP32.. here is a third patch (O2-page) to change this, but I'm not
> sure about other configurations (R10000?)

> -#if defined(CONFIG_SGI_IP27) || defined(CONFIG_SGI_IP32)
> +#if defined(CONFIG_SGI_IP27)
>  #define PAGE_OFFSET	0xa800000000000000UL
>  #endif

0xa8 is caching mode 5 which is not defined for the R5000, thus undefined
behaviour.  You can be almost certain that the CPU use that as an
excuse in order to do really funny things.

As the O2 is a non-cachecoherent machine this should also be correct for
the R10000 / R12000.

  Ralf

      reply	other threads:[~2001-12-16  2:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-15 22:52 patches for SGI O2 Vivien Chappelier
2001-12-16  1:27 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011215232757.A1863@dea.linux-mips.net \
    --to=ralf@oss.sgi.com \
    --cc=linux-mips@oss.sgi.com \
    --cc=vivien.chappelier@enst-bretagne.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.