* sysirix.c returns wrong error ?
@ 2002-01-01 19:36 GOTO Masanori
2002-01-01 23:36 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: GOTO Masanori @ 2002-01-01 19:36 UTC (permalink / raw)
To: linux-mips
Hi,
The following patch is for kernel/sysirix.c kernel vanilla 2.4.17,
I think this routine returns wrong error... Is it ok?
--- arch/mips/kernel/sysirix.c.vanilla Wed Jan 2 04:29:13 2002
+++ arch/mips/kernel/sysirix.c Wed Jan 2 04:30:19 2002
@@ -1908,7 +1908,7 @@
}
if (put_user(0, eob) < 0) {
- error = EFAULT;
+ error = -EFAULT;
goto out_putf;
}
-- gotom
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sysirix.c returns wrong error ?
2002-01-01 19:36 sysirix.c returns wrong error ? GOTO Masanori
@ 2002-01-01 23:36 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2002-01-01 23:36 UTC (permalink / raw)
To: GOTO Masanori; +Cc: linux-mips
On Wed, Jan 02, 2002 at 04:36:12AM +0900, GOTO Masanori wrote:
> The following patch is for kernel/sysirix.c kernel vanilla 2.4.17,
> I think this routine returns wrong error... Is it ok?
Yes, it's ok. I've applied the patch. I should mention though that I
have not received ANY user reports about the IRIX 5 compat code since I've
put it into the kernel in June 97 so chances the code is actually working
are not so bright ;-)
Thanks anyway,
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-01-02 4:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-01 19:36 sysirix.c returns wrong error ? GOTO Masanori
2002-01-01 23:36 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.